From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC0FC433EF for ; Fri, 11 Feb 2022 00:52:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C2DA6B0073; Thu, 10 Feb 2022 19:52:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 170C26B0075; Thu, 10 Feb 2022 19:52:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 039216B0078; Thu, 10 Feb 2022 19:52:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id EB7226B0073 for ; Thu, 10 Feb 2022 19:52:02 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A22AF181AC9C6 for ; Fri, 11 Feb 2022 00:52:02 +0000 (UTC) X-FDA: 79128672084.10.2310DE4 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf16.hostedemail.com (Postfix) with ESMTP id 3619F180002 for ; Fri, 11 Feb 2022 00:52:02 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id t4-20020a17090a510400b001b8c4a6cd5dso7264365pjh.5 for ; Thu, 10 Feb 2022 16:52:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=D3EjEoLgjS5BYa16RZ5JcaZGfnj2NCy9e6R/DsxWvD0=; b=mYDb9T7V8vVpb4vvbK6zkA0h1yevImaISwFUxjrIIoz62k/wF/zDHu5zFn6qzE7kUp 87hdaz0kZHUo4I24hP9Ypim/bw0UCqkm9B/sqsnXEiXBwa22hYfKiyLvWUhlNNdLK62v jkpZSMR3Qi6h9sWFPRK7ScuIfziA7yI6AE748= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=D3EjEoLgjS5BYa16RZ5JcaZGfnj2NCy9e6R/DsxWvD0=; b=J4262ZmqT6Vk9RSwowqvpvKM8PPbLGE5qms5Yllq+y3QpdpkdV/I3PVO4eh5h0pXIY VwWGj5L6MO6IqGzFKYyAETzoGsAgjeDxtlpdCb4uLWEd1arXJHxBRbXibnNdOwDKU+uJ ZfGbFwFtaPj8cM0Alqlm9xQFJPfqpjT2ivXT7KggaiZos/VBxadXAu5Sx2TJWkFoE0qZ En+UdEhL4coBJIbAk+M9Y6w99MFe3hwV30vrjG9W7XB3O6khl1gMEuTBsk/Ib1FkSEVN kbpyJJTHhD+0CmGGv+DcLFESHJyp1o2sVnSE0fdG0TZNCOGEcmKUUlAg0cWcWTHLHLxp BbBg== X-Gm-Message-State: AOAM531bw092+Jr+UdIFlHUiRQACj5MC0YJtIlzuFwoP1DNIw06vhCI3 u3Pss2818SPsd24DdKamCcLXzA== X-Google-Smtp-Source: ABdhPJw/vLSGOWe5ccZEegSZ0CyTgYC43nd3Y1R3YkYl+lBMWAImTOS4id0LQup7bw2RNv5XlqIpWQ== X-Received: by 2002:a17:90a:5206:: with SMTP id v6mr71812pjh.220.1644540721159; Thu, 10 Feb 2022 16:52:01 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z22sm24478493pfe.42.2022.02.10.16.52.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 16:52:00 -0800 (PST) Date: Thu, 10 Feb 2022 16:51:59 -0800 From: Kees Cook To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 01/12] powerpc: Move and rename func_descr_t Message-ID: <202202101651.E6AACB3D4F@keescook> References: <637a9a11263afa216fdfa7fb470a54479c67c61c.1634457599.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <637a9a11263afa216fdfa7fb470a54479c67c61c.1634457599.git.christophe.leroy@csgroup.eu> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3619F180002 X-Stat-Signature: kz6udgg9u9dfsjf8u9mn9jy1jk9obz9h X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=mYDb9T7V; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf16.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.48 as permitted sender) smtp.mailfrom=keescook@chromium.org X-HE-Tag: 1644540722-819884 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 17, 2021 at 02:38:14PM +0200, Christophe Leroy wrote: > There are three architectures with function descriptors, try to > have common names for the address they contain in order to > refactor some functions into generic functions later. > > powerpc has 'entry' > ia64 has 'ip' > parisc has 'addr' > > Vote for 'addr' and update 'func_descr_t' accordingly. > > Move it in asm/elf.h to have it at the same place on all > three architectures, remove the typedef which hides its real > type, and change it to a smoother name 'struct func_desc'. > > Signed-off-by: Christophe Leroy I like the name. :) Reviewed-by: Kees Cook -- Kees Cook