linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Xavier Roche <xavier.roche@algolia.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Hugh Dickins <hughd@google.com>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH RFC v1] tmpfs: support for file creation time
Date: Wed, 9 Feb 2022 15:27:30 +0100	[thread overview]
Message-ID: <20220209152730.13f52fa2@endymion.delvare> (raw)
In-Reply-To: <20220205141233.GA938324@xavier-xps>

On Sat, 5 Feb 2022 15:12:33 +0100, Xavier Roche wrote:
> Various filesystems (including ext4) now support file creation time.
> This patch tentatively adds such support for tmpfs-based filesystems.
> 
> The reason is that creation time has been supported on an increasing number
> of filesystems (this information can be retrieved through the statx()
> userland function), and its support for tmpfs would add consistency.
> Example of use includes checking the creation time of an ephemeral status file
> being updated (such as a "work in progress" placeholder), to get two time
> points (starting point and last update).
> 
> Note that I am nothing but a new contributor, and while this patch has
> been tested (and userland results checked), the logic might be broken.
> 
> Signed-off-by: Xavier Roche <xavier.roche@algolia.com>
> ---
>  include/linux/shmem_fs.h |  1 +
>  mm/shmem.c               | 11 +++++++++++
>  2 files changed, 12 insertions(+)
> (...)

Tested-by: Jean Delvare <jdelvare@suse.de>

Code looks reasonable, but take my review with a grain of salt as this
isn't my area.

Reviewed-by: Jean Delvare <jdelvare@suse.de>

-- 
Jean Delvare
SUSE L3 Support


      reply	other threads:[~2022-02-09 14:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-05 14:12 Xavier Roche
2022-02-09 14:27 ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220209152730.13f52fa2@endymion.delvare \
    --to=jdelvare@suse.de \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=xavier.roche@algolia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox