From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C03FDC433FE for ; Wed, 9 Feb 2022 13:53:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF6A46B0073; Wed, 9 Feb 2022 08:53:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E7F196B0074; Wed, 9 Feb 2022 08:53:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6D4D6B0075; Wed, 9 Feb 2022 08:53:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0133.hostedemail.com [216.40.44.133]) by kanga.kvack.org (Postfix) with ESMTP id C2E826B0073 for ; Wed, 9 Feb 2022 08:53:56 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8073E8249980 for ; Wed, 9 Feb 2022 13:53:56 +0000 (UTC) X-FDA: 79123384872.29.BD80269 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf11.hostedemail.com (Postfix) with ESMTP id C7BB340009 for ; Wed, 9 Feb 2022 13:53:55 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id D733867373; Wed, 9 Feb 2022 14:53:51 +0100 (CET) Date: Wed, 9 Feb 2022 14:53:51 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: Christoph Hellwig , Dan Williams , Andrew Morton , Felix Kuehling , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "Pan, Xinhui" , Ben Skeggs , Karol Herbst , Lyude Paul , Alistair Popple , Logan Gunthorpe , Ralph Campbell , Linux Kernel Mailing List , amd-gfx list , Maling list - DRI developers , nouveau@lists.freedesktop.org, Linux NVDIMM , Linux MM Subject: Re: [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount Message-ID: <20220209135351.GA20631@lst.de> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-8-hch@lst.de> <20220209062345.GB7739@lst.de> <20220209122956.GI49147@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220209122956.GI49147@ziepe.ca> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: e9un9h9ce51kbajir6p4fzp8wmscdcan X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=none (imf11.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C7BB340009 X-HE-Tag: 1644414835-914491 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 09, 2022 at 08:29:56AM -0400, Jason Gunthorpe wrote: > It is nice, but the other series are still impacted by the fsdax mess > - they still stuff pages into ptes without proper refcounts and have > to carry nonsense to dance around this problem. > > I certainly would be unhappy if the amd driver, for instance, gained > the fsdax problem as well and started pushing 4k pages into PMDs. As said before: I think this all needs to be fixed. But I'd rather fix it gradually and I think this series is a nice step forward. After that we can look at the pte mappings.