From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9281AC433F5 for ; Mon, 7 Feb 2022 17:39:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 235B96B0078; Mon, 7 Feb 2022 12:39:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E5EB6B007B; Mon, 7 Feb 2022 12:39:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 087796B007D; Mon, 7 Feb 2022 12:39:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id EE76A6B0078 for ; Mon, 7 Feb 2022 12:39:32 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A194A180ED797 for ; Mon, 7 Feb 2022 17:39:32 +0000 (UTC) X-FDA: 79116695784.08.27C46D6 Received: from server.lespinasse.org (server.lespinasse.org [63.205.204.226]) by imf17.hostedemail.com (Postfix) with ESMTP id 2C4E74000E for ; Mon, 7 Feb 2022 17:39:32 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-54-ed; t=1644255571; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=uMxP1uR1GMWjz5rQCuyF02GDhukH9s01AnuJsjrwSno=; b=YlBq92pzvV6ya+NxhmqpzQOrb15Dwe/fCJvDg1qVIuo/P+nsf2ovRUDnQLI1I/Rey+1lg kvVPsbEDOvV8ypFAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-54-rsa; t=1644255571; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=uMxP1uR1GMWjz5rQCuyF02GDhukH9s01AnuJsjrwSno=; b=dxYnoH/bYBJyklvC9tRz+aeodgNpOM0VcG+peohHQaS5dJtQCyBQpOAbQZZXjSC5on2YN A+i+MqkpSvABdWH2JY8xGcGLEOOVTcTkYdww8IYIrPvmTAHxH3j5nZDLOsiSdu2NdW0kHxp 1EzEDHfmW1GnML4Q6VwZKEAALEdRifabCWm14KLcDyigEbD9RpHWscW7vNmnkE+yOlTj59a qzULzgraGjWEd/qIr089ANyTZkdCzhxVzR/eKUXDRLMxrq55/TCDHzZFfBwg0ZPd6l2BIEq VOgGdoa6W+uPcGFd1b56YE9tCCZpiUQ7qJiL910tQNX+bwumvprkT0Hzsj4w== Received: by server.lespinasse.org (Postfix, from userid 1000) id 4C0E5160B2E; Mon, 7 Feb 2022 09:39:31 -0800 (PST) Date: Mon, 7 Feb 2022 09:39:31 -0800 From: Michel Lespinasse To: Liam Howlett Cc: Michel Lespinasse , Linux-MM , "linux-kernel@vger.kernel.org" , Andrew Morton , "kernel-team@fb.com" , Laurent Dufour , Jerome Glisse , Peter Zijlstra , Michal Hocko , Vlastimil Babka , Davidlohr Bueso , Matthew Wilcox , Rik van Riel , Paul McKenney , Song Liu , Suren Baghdasaryan , Minchan Kim , Joel Fernandes , David Rientjes , Axel Rasmussen , Andy Lutomirski Subject: Re: [PATCH v2 13/35] x86/mm: attempt speculative mm faults first Message-ID: <20220207173931.GC12302@lespinasse.org> References: <20220128131006.67712-1-michel@lespinasse.org> <20220128131006.67712-14-michel@lespinasse.org> <20220201171617.z5zgafitgolyv5np@revolver> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220201171617.z5zgafitgolyv5np@revolver> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspam-User: nil X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2C4E74000E X-Stat-Signature: t4z1gg8syf5edhcssj9kxjccor8kmsec Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=lespinasse.org header.s=srv-54-ed header.b=YlBq92pz; dkim=pass header.d=lespinasse.org header.s=srv-54-rsa header.b="dxYnoH/b"; dmarc=pass (policy=none) header.from=lespinasse.org; spf=pass (imf17.hostedemail.com: domain of michel@lespinasse.org designates 63.205.204.226 as permitted sender) smtp.mailfrom=michel@lespinasse.org X-HE-Tag: 1644255572-121400 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 01, 2022 at 05:16:43PM +0000, Liam Howlett wrote: > > + vma = __find_vma(mm, address); > > + if (!vma || vma->vm_start > address) { > > This fits the vma_lookup() pattern - although you will have to work > around the locking issue still. This is the same for the other > platforms too; they fit the pattern also. In this case, I think it's just as well to follow the lines of the non-speculative path, which itself can't use vma_lookup() because it needs to handle the stack expansion case... -- Michel "walken" Lespinasse