From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7418C433EF for ; Fri, 4 Feb 2022 20:21:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E93D6B0072; Fri, 4 Feb 2022 15:21:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 472336B0073; Fri, 4 Feb 2022 15:21:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33A4C6B0074; Fri, 4 Feb 2022 15:21:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 23EDE6B0072 for ; Fri, 4 Feb 2022 15:21:31 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D44AB18274109 for ; Fri, 4 Feb 2022 20:21:30 +0000 (UTC) X-FDA: 79106217540.07.B1D43AF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id 11FD52000B for ; Fri, 4 Feb 2022 20:21:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=AzouEe87CsHrOlz5lRWmw/qpbTgwgFiUall9RgwPTEY=; b=IU/1vPxIrZ5iK1dda6fsfPhSPr Kr1ElB1+QqS88UY/rmdfuYasDUH0tanagwRQItuSqyf8evtlPBm64ReevTLCotJVcydRWg6ehPTuI YYYsFuirs0s30u2QlZfbnMSCsHMTe8hkTYcTrP/KtdSGrG6CzlxlC0qd6mJFvcwwWz+YglBveVMej +KBbbxKueK7FhOGBTVc83itLTGgM92ZzRWl2lXE+ODdgsRMVJHB1FWxrP6NX/wz9XeHbrlLR2wfPV lt3UdLA/qj/ib32sGfhD+u2AAs6mpOAOWN6U8PZhFL9UcjaVnHzi/q1LdHpz18P0ZRrvfCpdYIFi+ xZmIwuIw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nG4jb-007Lqx-IQ; Fri, 04 Feb 2022 19:59:07 +0000 From: "Matthew Wilcox (Oracle)" To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org Subject: [PATCH 68/75] mm: Fix READ_ONLY_THP warning Date: Fri, 4 Feb 2022 19:58:45 +0000 Message-Id: <20220204195852.1751729-69-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220204195852.1751729-1-willy@infradead.org> References: <20220204195852.1751729-1-willy@infradead.org> MIME-Version: 1.0 X-Rspam-User: nil X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 11FD52000B X-Stat-Signature: qp16mip1xs4xkp5m193wtkn8ewnzfbw3 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="IU/1vPxI"; dmarc=none; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1644006089-797354 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: These counters only exist if CONFIG_READ_ONLY_THP_FOR_FS is defined, but we do not need to warn if the filesystem natively supports large folios. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagemap.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index dddd660da24f..39115f75962c 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -212,7 +212,7 @@ static inline void filemap_nr_thps_inc(struct address= _space *mapping) if (!mapping_large_folio_support(mapping)) atomic_inc(&mapping->nr_thps); #else - WARN_ON_ONCE(1); + WARN_ON_ONCE(mapping_large_folio_support(mapping) =3D=3D 0); #endif } =20 @@ -222,7 +222,7 @@ static inline void filemap_nr_thps_dec(struct address= _space *mapping) if (!mapping_large_folio_support(mapping)) atomic_dec(&mapping->nr_thps); #else - WARN_ON_ONCE(1); + WARN_ON_ONCE(mapping_large_folio_support(mapping) =3D=3D 0); #endif } =20 --=20 2.34.1