From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2F23C433FE for ; Thu, 3 Feb 2022 10:16:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41C7A8D0140; Thu, 3 Feb 2022 05:16:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CBCD8D0129; Thu, 3 Feb 2022 05:16:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26CCD8D0140; Thu, 3 Feb 2022 05:16:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154]) by kanga.kvack.org (Postfix) with ESMTP id 18FE18D0129 for ; Thu, 3 Feb 2022 05:16:42 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id CC3AD18229946 for ; Thu, 3 Feb 2022 10:16:41 +0000 (UTC) X-FDA: 79101064602.07.547C443 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf13.hostedemail.com (Postfix) with ESMTP id 4221A20003 for ; Thu, 3 Feb 2022 10:16:41 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 2247F210F5; Thu, 3 Feb 2022 10:16:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1643883400; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nMtUiTADLXvATyPy55s5v2jIbp3M1SDdfjBzYLxVQaY=; b=uy2A4dJPId5ZjWCWAB7xzjfv13TBL3uksbYhtD+kKBZhrAucoFYo7wWTV4GGe0bSvNLiZg /TASBHNd2GhHxG8IXnxdCpSOmo6tXKy/zRv5lEnzQFTGOlVqJYjcu5NXWm80JkNcmnW25s 2wbAYsBhMPGEqliDZhIuMJnb1yi8F+o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1643883400; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nMtUiTADLXvATyPy55s5v2jIbp3M1SDdfjBzYLxVQaY=; b=vcVcbh2mnYakFOI5KUfh516xdmKnxbolVU4Edct5Wyh+ucnXTTj5p+shSiuZgqtlRy2NAd 0gSKvXRm2L/1iWDw== Received: from quack3.suse.cz (unknown [10.100.200.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 7694EA3B88; Thu, 3 Feb 2022 10:16:39 +0000 (UTC) Received: by quack3.suse.cz (Postfix, from userid 1000) id E2601A05B6; Thu, 3 Feb 2022 11:16:38 +0100 (CET) Date: Thu, 3 Feb 2022 11:16:38 +0100 From: Jan Kara To: Muchun Song Cc: dan.j.williams@intel.com, willy@infradead.org, jack@suse.cz, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, apopple@nvidia.com, shy828301@gmail.com, rcampbell@nvidia.com, hughd@google.com, xiyuyang19@fudan.edu.cn, kirill.shutemov@linux.intel.com, zwisler@kernel.org, hch@infradead.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com Subject: Re: [PATCH v2 1/6] mm: rmap: fix cache flush on THP pages Message-ID: <20220203101638.5sibdhu4owokhfex@quack3.lan> References: <20220202143307.96282-1-songmuchun@bytedance.com> <20220202143307.96282-2-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220202143307.96282-2-songmuchun@bytedance.com> X-Rspam-User: nil X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4221A20003 X-Stat-Signature: sxbawxyzhfckeiom91y8k8qix1qfuanr Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uy2A4dJP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vcVcbh2m; spf=pass (imf13.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none X-HE-Tag: 1643883401-835744 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 02-02-22 22:33:02, Muchun Song wrote: > The flush_cache_page() only remove a PAGE_SIZE sized range from the cache. > However, it does not cover the full pages in a THP except a head page. > Replace it with flush_cache_range() to fix this issue. At least, no > problems were found due to this. Maybe because the architectures that > have virtual indexed caches is less. > > Fixes: f27176cfc363 ("mm: convert page_mkclean_one() to use page_vma_mapped_walk()") > Signed-off-by: Muchun Song > Reviewed-by: Yang Shi Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/rmap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index b0fd9dc19eba..0ba12dc9fae3 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -974,7 +974,8 @@ static bool page_mkclean_one(struct page *page, struct vm_area_struct *vma, > if (!pmd_dirty(*pmd) && !pmd_write(*pmd)) > continue; > > - flush_cache_page(vma, address, page_to_pfn(page)); > + flush_cache_range(vma, address, > + address + HPAGE_PMD_SIZE); > entry = pmdp_invalidate(vma, address, pmd); > entry = pmd_wrprotect(entry); > entry = pmd_mkclean(entry); > -- > 2.11.0 > -- Jan Kara SUSE Labs, CR