linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Peter Xu <peterx@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>
Cc: David Hildenbrand <david@redhat.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>, Jan Kara <jack@suse.cz>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH v3 0/4] mm/gup: some cleanups
Date: Thu, 3 Feb 2022 01:32:28 -0800	[thread overview]
Message-ID: <20220203093232.572380-1-jhubbard@nvidia.com> (raw)

Hi Peter, Jason and all,

Changes since v2:

    * Patch 2: Removed an unnecessary line that was causing a
      clang-analyzer complaint, as reported by Lukas Bulwahn
      [1] (thanks!), and retested locally.

      Jason: I've boldly left your Reviewed-by tag on this patch,
      because I am predicting you'll agree with it...

    * Added Reviewed-by tags from Jan Kara, Christoph Hellwig, and
      Jason Gunthorpe that have collected since v2.


Changes since v1:
    * Patch 4: changed from get_user_pages(), to get_user_pages_fast().

    * Patch 4: Rewrote the commit description--thanks to Jan Kara for
               that feedback.

    * Patch 1: Removed Jerome's Cc from patch 1, due to a stale email
               address.

    * Added Reviewed-by's from David Hildenbrand and Jason Gunthorpe.

Original cover letter, updated as necessary:

I'm including Peter's patch as the first one in this tiny series. (The
commit description has my r-b tag in place of my Cc, and removes
Jerome's Cc because he is no longer at redhat.com) The second patch is
what I had in mind for a follow-up to that, when we were discussing that
fix [2].

Plus, a couple more small removals that I had queued up:

The third patch removes a completely unused routine:
pin_user_pages_locked().

The forth patch removes a similar routine, get_user_pages_locked(), that
only has one caller. It now calls get_user_pages_fast(), instead.

v1 of this patchset is here:
https://lore.kernel.org/all/20220131051752.447699-1-jhubbard@nvidia.com/

v2 of this patchset is here:
https://lore.kernel.org/r/20220201101108.306062-1-jhubbard@nvidia.com

[1] https://lore.kernel.org/r/CAKXUXMxFK9bo8jDoRZbQ0r2j-JwAGg3Xc5cpAcLaHfwHddJ7ew@mail.gmail.com

[2] https://lore.kernel.org/all/20220125033700.69705-1-peterx@redhat.com/


thanks,
John Hubbard

John Hubbard (3):
  mm/gup: clean up follow_pfn_pte() slightly
  mm/gup: remove unused pin_user_pages_locked()
  mm/gup: remove get_user_pages_locked()

Peter Xu (1):
  mm: Fix invalid page pointer returned with FOLL_PIN gups

 include/linux/mm.h |  4 --
 mm/gup.c           | 99 +++-------------------------------------------
 mm/mempolicy.c     | 21 +++++-----
 3 files changed, 15 insertions(+), 109 deletions(-)


base-commit: 88808fbbead481aedb46640a5ace69c58287f56a
--
2.35.1




             reply	other threads:[~2022-02-03  9:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-03  9:32 John Hubbard [this message]
2022-02-03  9:32 ` [PATCH v3 1/4] mm: Fix invalid page pointer returned with FOLL_PIN gups John Hubbard
2022-02-03 12:10   ` Claudio Imbrenda
2022-02-03 21:25     ` John Hubbard
2022-02-03 14:00   ` Christoph Hellwig
2022-02-03 21:13     ` John Hubbard
2022-02-03  9:32 ` [PATCH v3 2/4] mm/gup: clean up follow_pfn_pte() slightly John Hubbard
2022-02-03 13:31   ` Claudio Imbrenda
2022-02-03 20:53     ` John Hubbard
2022-02-03 13:53   ` Jan Kara
2022-02-03 15:01     ` Jason Gunthorpe
2022-02-03 15:18       ` Matthew Wilcox
2022-02-03 21:19         ` John Hubbard
2022-02-03  9:32 ` [PATCH v3 3/4] mm/gup: remove unused pin_user_pages_locked() John Hubbard
2022-02-03 11:52   ` Claudio Imbrenda
2022-02-03  9:32 ` [PATCH v3 4/4] mm/gup: remove get_user_pages_locked() John Hubbard
2022-02-03 12:04   ` Claudio Imbrenda
2022-02-03 14:01   ` Christoph Hellwig
2022-02-03 21:27     ` John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220203093232.572380-1-jhubbard@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex.williamson@redhat.com \
    --cc=david@redhat.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=jack@suse.cz \
    --cc=jgg@ziepe.ca \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=peterx@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox