From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A26DC433EF for ; Wed, 2 Feb 2022 14:57:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE8A86B02C5; Wed, 2 Feb 2022 09:57:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E96CF6B02C6; Wed, 2 Feb 2022 09:57:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5F766B02C7; Wed, 2 Feb 2022 09:57:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id C43B06B02C5 for ; Wed, 2 Feb 2022 09:57:57 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7D5609A7E8 for ; Wed, 2 Feb 2022 14:57:57 +0000 (UTC) X-FDA: 79098144594.13.8F43671 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf23.hostedemail.com (Postfix) with ESMTP id DC172140008 for ; Wed, 2 Feb 2022 14:57:56 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 49B1A68B05; Wed, 2 Feb 2022 15:57:52 +0100 (CET) Date: Wed, 2 Feb 2022 15:57:50 +0100 From: Christoph Hellwig To: Andrew Morton Cc: Alex Sierra , Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jgg@nvidia.com, jglisse@redhat.com, apopple@nvidia.com, willy@infradead.org Subject: Re: [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping Message-ID: <20220202145750.GA25170@lst.de> References: <20220127030949.19396-1-alex.sierra@amd.com> <20220127143258.8da663659948ad1e6f0c0ea8@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220127143258.8da663659948ad1e6f0c0ea8@linux-foundation.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DC172140008 X-Stat-Signature: 7b34ozq7bjpnkq6q5t7q4kfrsyrtnb9b Authentication-Results: imf23.hostedemail.com; dkim=none; spf=none (imf23.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspam-User: nil X-HE-Tag: 1643813876-554390 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 27, 2022 at 02:32:58PM -0800, Andrew Morton wrote: > On Wed, 26 Jan 2022 21:09:39 -0600 Alex Sierra wrote: > > > This patch series introduces MEMORY_DEVICE_COHERENT, a type of memory > > owned by a device that can be mapped into CPU page tables like > > MEMORY_DEVICE_GENERIC and can also be migrated like > > MEMORY_DEVICE_PRIVATE. > > Some more reviewer input appears to be desirable here. > > I was going to tentatively add it to -mm and -next, but problems. > 5.17-rc1's mm/migrate.c:migrate_vma_check_page() is rather different > from the tree you patched. Please redo, refresh and resend? I really hate adding more types with the weird one off page refcount. We need to clean that mess up first.