From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48744C433FE for ; Wed, 2 Feb 2022 01:07:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 898078D009C; Tue, 1 Feb 2022 20:07:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 821E68D0094; Tue, 1 Feb 2022 20:07:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69A348D009C; Tue, 1 Feb 2022 20:07:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 564008D0094 for ; Tue, 1 Feb 2022 20:07:55 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 02F9C18239AD4 for ; Wed, 2 Feb 2022 01:07:55 +0000 (UTC) X-FDA: 79096052910.13.5610479 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf31.hostedemail.com (Postfix) with ESMTP id 9A1B920008 for ; Wed, 2 Feb 2022 01:07:54 +0000 (UTC) Received: by mail-pf1-f171.google.com with SMTP id u130so17419297pfc.2 for ; Tue, 01 Feb 2022 17:07:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RSo0lKBxOCaeF2/Z6BYia50YxeJQ1xKTwofT0YCtOAQ=; b=B3j4wMvjt0cGoNPIVXr6D80603KlI3Z7B+sUmYIOhoFgfE2zf3NRTDe4GSRjHWwW31 fk1LI0CfMYHlx/H3SeBT1X5DbmR63YNeyglveui0E8zE97a081Ul3E7Sx99BKqcCnCaw Qnk20qVNZEqsc0IgJ6FgFIXWg838wQWG1FbXo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RSo0lKBxOCaeF2/Z6BYia50YxeJQ1xKTwofT0YCtOAQ=; b=pnTJ7qIT8ifInkXVF5sI8tVkBpFzt3RoWr83SxId7vVQjA8v8Y4d6+P4rNLkk8508y DNwdxKKXCoOmDMU8wqJGuLMztF16f6NN4n9wmr1nvfFxeWPziajVpuO8s2erH7rj455H P67MRysOno1YY+55bT1vKw5wkMFJKTAptrfW87M6MmarPz6dFqMhqZvRY3kH1C3TOpin cbwpj1ZKICdp3MWlfF1NR4ediWv28u1PkpNOfYqkCBOM9jUpWIOL2ccLH37m0XJT8QSk K/EyfhsmXHgUudDWQa6UDcO2bPmNUHhwyOop1P0y2vQmm9h5v5FmqRKvkTAPgnpGDT7P JVag== X-Gm-Message-State: AOAM533pwdDS7+hFGvN+bSXIGUS3TC4EMuXyShsW7kJQQ8ZqRCqBLaa7 9hipqVi409INXmjw1fq1UpcK2w== X-Google-Smtp-Source: ABdhPJxPjwMwuYyjXbYv75EsIRWlL4woTQ0yr1bgcp5S7GmLVGAyQU2AJPAJggFeEX/0dz94hZOq7A== X-Received: by 2002:a63:343:: with SMTP id 64mr22646388pgd.463.1643764073491; Tue, 01 Feb 2022 17:07:53 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id nv13sm4471158pjb.17.2022.02.01.17.07.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 17:07:53 -0800 (PST) Date: Tue, 1 Feb 2022 17:07:52 -0800 From: Kees Cook To: Andrew Morton Cc: Alexey Dobriyan , Magnus =?iso-8859-1?Q?Gro=DF?= , Alexander Viro , Eric Biederman , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] elf: Relax assumptions about vaddr ordering Message-ID: <202202011707.F4137C55B@keescook> References: <202201260845.FCBC0B5A06@keescook> <202201262230.E16DF58B@keescook> <202201281347.F36AEA5B61@keescook> <20220201144816.f84bafcf45c21d01fbc3880a@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220201144816.f84bafcf45c21d01fbc3880a@linux-foundation.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9A1B920008 X-Rspam-User: nil Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=B3j4wMvj; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf31.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.171 as permitted sender) smtp.mailfrom=keescook@chromium.org X-Stat-Signature: djewifkzymddqh948k6ttw7o4hcz9iyh X-HE-Tag: 1643764074-126981 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 01, 2022 at 02:48:16PM -0800, Andrew Morton wrote: > On Fri, 28 Jan 2022 14:30:12 -0800 Kees Cook wrote: > > > Andrew, can you update elf-fix-overflow-in-total-mapping-size-calculation.patch > > to include: > > > > Fixes: 5f501d555653 ("binfmt_elf: reintroduce using MAP_FIXED_NOREPLACE") > > Cc: stable@vger.kernel.org > > Acked-by: Kees Cook > > Done. > > I'm taking it that we can omit this patch ("elf: Relax assumptions > about vaddr ordering") and that Alexey's "ELF: fix overflow in total > mapping size calculation" will suffice? Yes, it has the same result. Thanks! -- Kees Cook