From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E94BC433EF for ; Tue, 1 Feb 2022 02:42:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C6B98D0050; Mon, 31 Jan 2022 21:42:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 24E6F8D0028; Mon, 31 Jan 2022 21:42:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A1CB8D0050; Mon, 31 Jan 2022 21:42:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0141.hostedemail.com [216.40.44.141]) by kanga.kvack.org (Postfix) with ESMTP id E936E8D0028 for ; Mon, 31 Jan 2022 21:42:40 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B34F896350 for ; Tue, 1 Feb 2022 02:42:40 +0000 (UTC) X-FDA: 79092662880.10.C31E21D Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf27.hostedemail.com (Postfix) with ESMTP id 3D08540002 for ; Tue, 1 Feb 2022 02:42:40 +0000 (UTC) Received: by mail-ej1-f48.google.com with SMTP id jx6so49678756ejb.0 for ; Mon, 31 Jan 2022 18:42:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LSd1fDrOzA4Dpcv+XNORtddH3JxeWWMsppEtjfZhhrw=; b=BYaxG+0tXuPpIfa6C23ZIGmte2gD6VJFdpAmSvBZ3N0s/kODdzYUEF8RUj1vuSLPTo h/+AfGAsiL2Q0Oj/pY3+lN8kmgeBvSK0wxB9jvIxnOmJkqP9r1dJnjY6HQgQZeUsLMhq gUKoXIgsK9MxqgVhoGt1YfH1yj5mIID8NoXrE4fxz/rTFbw4Cvo4Rze23vokUbW2PB0W 3gcDO1ebPicdTyzmCPzFHE07oSancb+5aQADB47a0PRoziULZAsbBc/o1hgJt36GBKds CXoOwb6+BLlInbqx0/ylFWpY3FIUFxusx1PCJr6eU5cLUdxPIcuXdv+9xbaiYy9OX0Wy jOIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=LSd1fDrOzA4Dpcv+XNORtddH3JxeWWMsppEtjfZhhrw=; b=jNiIE1qieLFr3pAWVOMYaZTiD6Fm1WJ2HX9PMMNXMosKxf+CYz0W/HZy4EoKro/6va pq3cnO7hJJhR/Cc4Xm5/UAN0beQ5JvmY2Z8OFUic+xWo7Cq872Ni2rIYLBVBGJ/V4m+T e53lu7qkAvgakXKYqxHE1rmR8RvMeEcm6SE4Wy2DJD+09mHOC81+DbGwAu9KUasu0sS9 K8KjtxNLuUtqLUmTbnNDlg3s5Tq4zK0k9QVKeDBRvT96eWnhDHP9cpjL6zystzX5Jl59 JDzEestiChMzf6mzKqv8qNMrCFwmUfKGWABhu4/bfllIeyZq62WFwZhW+pFZTG/z/nUm yi7w== X-Gm-Message-State: AOAM531HtzPAngbRvyIEm9EU5KK8gNNBfUGov3hf+CPx6dH4LpoxHoqA o2KHYazh4kV5c5g0OBLckjk= X-Google-Smtp-Source: ABdhPJyuN1wfBF6igMEAFuxiSZEGqTTJ6jx591QRlEMlgkDxs4u+SaRp29ssmVnlRUCdqfOPxPRtQQ== X-Received: by 2002:a17:907:1c0b:: with SMTP id nc11mr19037817ejc.665.1643683359160; Mon, 31 Jan 2022 18:42:39 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a7sm18823701edr.34.2022.01.31.18.42.38 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 31 Jan 2022 18:42:38 -0800 (PST) Date: Tue, 1 Feb 2022 02:42:38 +0000 From: Wei Yang To: Michal Hocko Cc: Andrew Morton , linux-mm@kvack.org, LKML , David Hildenbrand , Alexey Makhalov , Dennis Zhou , Eric Dumazet , Oscar Salvador , Tejun Heo , Christoph Lameter , Nico Pache , Wei Yang , Rafael Aquini , Michal Hocko Subject: Re: [PATCH 4/6] mm, memory_hotplug: reorganize new pgdat initialization Message-ID: <20220201024238.ihq477dgayy6oxeg@master> Reply-To: Wei Yang References: <20220127085305.20890-1-mhocko@kernel.org> <20220127085305.20890-5-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220127085305.20890-5-mhocko@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: nil X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3D08540002 X-Stat-Signature: kctjuftfq1k9mnh67c5c3hwf7ii1p8kf Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BYaxG+0t; spf=pass (imf27.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1643683360-237363 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 27, 2022 at 09:53:03AM +0100, Michal Hocko wrote: >From: Michal Hocko > >When a !node_online node is brought up it needs a hotplug specific >initialization because the node could be either uninitialized yet or it >could have been recycled after previous hotremove. hotadd_init_pgdat is >responsible for that. > >Internal pgdat state is initialized at two places currently > - hotadd_init_pgdat > - free_area_init_core_hotplug >There is no real clear cut what should go where but this patch's chosen to >move the whole internal state initialization into free_area_init_core_hotplug. >hotadd_init_pgdat is still responsible to pull all the parts together - >most notably to initialize zonelists because those depend on the overall topology. > >This patch doesn't introduce any functional change. > >Acked-by: Rafael Aquini >Signed-off-by: Michal Hocko Reviewed-by: Wei Yang -- Wei Yang Help you, Help me