From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0744AC433F5 for ; Tue, 1 Feb 2022 01:01:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 224AD8D0041; Mon, 31 Jan 2022 20:01:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D5058D0028; Mon, 31 Jan 2022 20:01:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C4548D0041; Mon, 31 Jan 2022 20:01:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id ED1E18D0028 for ; Mon, 31 Jan 2022 20:01:27 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A0D6997307 for ; Tue, 1 Feb 2022 01:01:27 +0000 (UTC) X-FDA: 79092407814.06.1311CFC Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf05.hostedemail.com (Postfix) with ESMTP id 28560100007 for ; Tue, 1 Feb 2022 01:01:27 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DA1CDB82CA2; Tue, 1 Feb 2022 01:01:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A2B1C340EC; Tue, 1 Feb 2022 01:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1643677284; bh=0gFRkMeBrEbAJtvV7jiZaYWjZsJplBWCxekudIaSp9A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qVY6JB8ceUixUrS/C2NR5cD+aF6hRCO00ofiUauUPVPyEHCcvBXiO1N1E5SOaqL8Z 3mPjfEK4a/hIKGi9VvvbDBZKyvIlOHCq0mp/xE4l14hkCBJcHtu1i/Um6BGldYqaLO DN1QgqpNs8tHSQ151UisvL2O0jv4M916ev+7OnWk= Date: Mon, 31 Jan 2022 17:01:23 -0800 From: Andrew Morton To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , Michal Hocko , Oscar Salvador Subject: Re: [PATCH v1] drivers/base/memory: add memory block to memory group after registration succeeded Message-Id: <20220131170123.42d7f46ecea0da1cb1579113@linux-foundation.org> In-Reply-To: <20220128144540.153902-1-david@redhat.com> References: <20220128144540.153902-1-david@redhat.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: mtjqfenrz586czmw9j4ij4wipshcsi6b X-Rspam-User: nil Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=qVY6JB8c; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 28560100007 X-HE-Tag: 1643677287-306837 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 28 Jan 2022 15:45:40 +0100 David Hildenbrand wrote: > If register_memory() fails, we freed the memory block but already added > the memory block to the group list, not good. Let's defer adding the > block to the memory group to after registering the memory block device. > > We do handle it properly during unregister_memory(), but that's not > called when the registration fails. > I guess this has never been known to happen. So I queued the fix for 5.18-rc1, cc:stable.