From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CC3BC433EF for ; Mon, 31 Jan 2022 21:59:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75F338D0029; Mon, 31 Jan 2022 16:59:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 70E8A8D0028; Mon, 31 Jan 2022 16:59:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D6188D0029; Mon, 31 Jan 2022 16:59:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id 507688D0028 for ; Mon, 31 Jan 2022 16:59:48 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0F79794FDC for ; Mon, 31 Jan 2022 21:59:48 +0000 (UTC) X-FDA: 79091950056.18.FA102B7 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf16.hostedemail.com (Postfix) with ESMTP id 53946180004 for ; Mon, 31 Jan 2022 21:59:47 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 63E7DCE128B; Mon, 31 Jan 2022 21:59:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55909C340E8; Mon, 31 Jan 2022 21:59:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1643666381; bh=vNlLgrPBYYVLtyrSiMdjfL/qJCb4K3K6IhJIJV2Y96U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ddqgOcAOpEQDMmnkqDH9mzjGwcK0/itBNcvh7267A1cu82AEZgDp2XVFoUkWCSqJs 22jOnS9lho9WOAKWSJ0xmydlBWAs9YjhMVXTneKGEWiP2NEMeqO05sZiir4V9mEdrW +oS4crPs0fdnLGL4EFqaUDEwmhclMXIqcKvly5vc= Date: Mon, 31 Jan 2022 13:59:40 -0800 From: Andrew Morton To: Christian Brauner Cc: Matthew Wilcox , kernel test robot , Kees Cook , Ariadne Conill , 0day robot , Michael Kerrisk , Rich Felker , Eric Biederman , Alexander Viro , LKML , lkp@lists.01.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [fs/exec] 80bd5afdd8: xfstests.generic.633.fail Message-Id: <20220131135940.20790cff1747e79dd855aaf4@linux-foundation.org> In-Reply-To: <20220131171344.77iifun5wdilbqdz@wittgenstein> References: <20220127000724.15106-1-ariadne@dereferenced.org> <20220131144352.GE16385@xsang-OptiPlex-9020> <20220131150819.iuqlz3rz6q7cheap@wittgenstein> <20220131153707.oe45h7tuci2cbfuv@wittgenstein> <20220131161415.wlvtsd4ecehyg3x5@wittgenstein> <20220131171344.77iifun5wdilbqdz@wittgenstein> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: bm1sb46ohzr785b5m34ptwqzj1c6ry6f X-Rspam-User: nil Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ddqgOcAO; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 53946180004 X-HE-Tag: 1643666387-89535 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 31 Jan 2022 18:13:44 +0100 Christian Brauner wrote: > > in other words, the changes that you see CMD_ARGS[0] == NULL for > > execveat() seem higher than for path-based exec. > > > > To counter that we should probably at least update the execveat() > > manpage with a recommendation what CMD_ARGS[0] should be set to if it > > isn't allowed to be set to NULL anymore. This is why was asking what > > argv[0] is supposed to be if the binary doesn't take any arguments. > > Sent a fix to our fstests now replacing the argv[0] as NULL with "". As we hit this check so quickly, I'm thinking that Ariadne's patch "fs/exec: require argv[0] presence in do_execveat_common()" (which added the check) isn't something we'll be able to merge into mainline?