From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3DA6C433FE for ; Wed, 26 Jan 2022 21:11:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 271356B0071; Wed, 26 Jan 2022 16:11:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 220DA6B0072; Wed, 26 Jan 2022 16:11:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1110B6B0073; Wed, 26 Jan 2022 16:11:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id 0327A6B0071 for ; Wed, 26 Jan 2022 16:11:58 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B6EB2901C2 for ; Wed, 26 Jan 2022 21:11:57 +0000 (UTC) X-FDA: 79073685474.08.E8FBBA0 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by imf29.hostedemail.com (Postfix) with ESMTP id 54CA512005B for ; Wed, 26 Jan 2022 21:11:57 +0000 (UTC) Received: by mail-oi1-f169.google.com with SMTP id e81so2073591oia.6 for ; Wed, 26 Jan 2022 13:11:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=slBq4NHY0ygv8QW43vJ34+YaiAj8G4SyoF0HzZkCQHc=; b=YaD7LUIzV2ATPTv9SR3UQu+BkZ+pYRAYbI+veHC6Socrf7xUMvGRKtQPQkx/BLof2L vaGQCXUVt5RdGdmBnedu/mQzs41AsJhsPP5Juxum3ktgAMIqYGdDYDkmO75V/bN5AfjP lbOXG3Zt1UAu1rEfLhC+s2TsSHYqgGcYphNz0LHdMtvU7oR+gOqNJjcaIXQGBgvkPF8U g5xexwalvuKZL7Sw0bVCcO3rlkdue4E4xwg+g/i3sNp2O3yerSdJFB1TM8hi9iK/P/16 9ODH1PFD3fY+BSBGIFIx6lXNoBW/BrMKYP+tmbILW7R2M8L8HCVUJfJFCERbRx8RZ4wV LTfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=slBq4NHY0ygv8QW43vJ34+YaiAj8G4SyoF0HzZkCQHc=; b=Fsbo3cZttW1kCj2X0FOb1zvNoBic7TQ07wVmyN4TA/kgj8htwi5RSlz5YyJrDlUeDl +iLNNuilppymy0sbs88aA5Z2pTcyBmCTqPfAdNoRbiOZSyQCzOfLdi5PlAWHCTiYCkPY 09WKskhP2DV8oRQNGOXTRfE4SzeLmygK2SSvDzMxgMjgOa45gBSXMavFsW4vd3lVG3wd pwfIJqeIJeerEngmc56YckfREAyQFq+5h/oK0r8iDPpIehPSL4R8chYWVtUsq8p6u7Jt XgGZsNPsR2gyb3l9ExTq6M0jm6T1Gry5tg94ybzBe4rcR0ofDrU+gyKut3FE6I4Ihtjo 3RlQ== X-Gm-Message-State: AOAM531bbrW1oe6AOUk6bbD+Vmjp6rZKAtq8gAQA8x0Ew39EJEHzb/sK 95a3NTMHkALTjWAbBQdrV1M= X-Google-Smtp-Source: ABdhPJwKfUKG9txRxsfQ+FzsJFtRrkqOmIVVEbdM1wXY1/zmmO9x4aBYV4sFVvSCUCm88ecZcTwyww== X-Received: by 2002:a05:6808:2003:: with SMTP id q3mr4830914oiw.254.1643231516493; Wed, 26 Jan 2022 13:11:56 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id p26sm5956722oth.14.2022.01.26.13.11.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jan 2022 13:11:55 -0800 (PST) Date: Wed, 26 Jan 2022 13:11:54 -0800 From: Guenter Roeck To: Chen Wandun Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, guillaume.tucker@collabora.com Subject: Re: [PATCH] Revert "mm/page_isolation: unset migratetype directly for non Buddy page" Message-ID: <20220126211154.GA3371726@roeck-us.net> References: <20220117142712.3967624-1-chenwandun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220117142712.3967624-1-chenwandun@huawei.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 54CA512005B X-Stat-Signature: 6mrxunp7npg3jgodsqqmcnkbcxbd99dh Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YaD7LUIz; dmarc=none; spf=pass (imf29.hostedemail.com: domain of groeck7@gmail.com designates 209.85.167.169 as permitted sender) smtp.mailfrom=groeck7@gmail.com X-Rspam-User: nil X-HE-Tag: 1643231517-866662 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 17, 2022 at 10:27:12PM +0800, Chen Wandun wrote: > This reverts commit 075782149abff45ee22f27315eced44d02b96779. > > commit 075782149abf ("mm/page_isolation: unset migratetype directly for > non Buddy page") will result memory that should in buddy disappear by > mistake. move_freepages_block move all pages in pageblock instead of > pages indicated by input parameter, so if input pages is not in buddy > but other pages in pageblock is in buddy, it will result in page out of > control. > > Reported-by: "kernelci.org bot" > Signed-off-by: Chen Wandun I see a number of qemu emulations fail with memory allocation errors in v5.17-rc1. This revert fixes the problem. Tested-by: Guenter Roeck Guenter > --- > mm/page_isolation.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index 6a0ddda6b3c5..f67c4c70f17f 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -115,7 +115,7 @@ static void unset_migratetype_isolate(struct page *page, unsigned migratetype) > * onlining - just onlined memory won't immediately be considered for > * allocation. > */ > - if (!isolated_page && PageBuddy(page)) { > + if (!isolated_page) { > nr_pages = move_freepages_block(zone, page, migratetype, NULL); > __mod_zone_freepage_state(zone, nr_pages, migratetype); > } > -- > 2.18.0.huawei.25 > >