From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF23EC2BA4C for ; Wed, 26 Jan 2022 16:37:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1E386B0073; Wed, 26 Jan 2022 11:37:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CCD676B0074; Wed, 26 Jan 2022 11:37:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBBA86B0075; Wed, 26 Jan 2022 11:37:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0096.hostedemail.com [216.40.44.96]) by kanga.kvack.org (Postfix) with ESMTP id AF12A6B0073 for ; Wed, 26 Jan 2022 11:37:18 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 614998249980 for ; Wed, 26 Jan 2022 16:37:18 +0000 (UTC) X-FDA: 79072993356.28.36BD52F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 87DD4160023 for ; Wed, 26 Jan 2022 16:37:17 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 796E661A3E; Wed, 26 Jan 2022 16:37:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95BFFC340E3; Wed, 26 Jan 2022 16:37:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643215035; bh=Wvh+j4ViOhP5lyh7Ldj6SkzunVt2K7HTtCp2ap0/Cj0=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=ZlMHr2A0wa+PyYj4ZJGYfrFb3iYH33IlBUZlqtYd9/LR8Ia0sHwJZj7RMKo3IJzri F8ymXD9B84cTOUTGAQ0Lps76t/hLgMy2Wo9GdcX8n6mrzLKVTW1Cp70kyVE37L77sy foUcDUtULVMrPSQMmceSanFTKXxc+0dd1tFidDo7gmwpNezEGOqcEhmjOlZSaZoCx5 x8Z+HbO8mrNts3mIPmegRoCZmKaTsavPn6o9yI/8uuARvp6Hu7ui33WvCKpd3ENNuK GrK6xDucF0Iku4biMgOEcA0KewFmegv3xKjjQFKaF9E6cEniw25dRBrfRdTca2L8QS 2kHpd6fGXw1Gg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] Remove the type-unclear target id concept Date: Wed, 26 Jan 2022 16:37:13 +0000 Message-Id: <20220126163713.8058-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211230182059.6535f9201eba9e420a08445a@linux-foundation.org> X-Rspam-User: nil X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 87DD4160023 X-Stat-Signature: de187iprxijme4mb9beueqq9cj5ezaa7 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZlMHr2A0; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org X-HE-Tag: 1643215037-936827 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 30 Dec 2021 18:20:59 -0800 Andrew Morton wrote: > On Thu, 30 Dec 2021 10:07:19 +0000 SeongJae Park wrote: > > > DAMON asks each monitoring target ('struct damon_target') to have one > > 'unsigned long' integer called 'id', which should be unique among the > > targets of same monitoring context. Meaning of it is, however, totally > > up to the monitoring primitives that registered to the monitoring > > context. For example, the virtual address spaces monitoring primitives > > treats the id as a 'struct pid' pointer. > > > > This makes the code flexible but ugly, not well-documented, and > > type-unsafe[1]. Also, identification of each target can be done via its > > index. For the reason, this patchset removes the concept and uses clear > > type definition. > > Thanks. This doesn't appear to be urgent, so I'll park it until after 5.17-rc1. Just for a remind. I confirmed this patchset is cleanly applicable on the latest -next tree. Thanks, SJ