From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6746DC433EF for ; Mon, 24 Jan 2022 08:26:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 074556B0083; Mon, 24 Jan 2022 03:26:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F3FB16B0085; Mon, 24 Jan 2022 03:26:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE1736B0087; Mon, 24 Jan 2022 03:26:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id CC3EE6B0083 for ; Mon, 24 Jan 2022 03:26:28 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 929F090F78 for ; Mon, 24 Jan 2022 08:26:28 +0000 (UTC) X-FDA: 79064498856.29.9B9A898 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf29.hostedemail.com (Postfix) with ESMTP id 9E8E5120031 for ; Mon, 24 Jan 2022 08:26:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643012787; x=1674548787; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Rux9J+VSLdbgWUxsBOOX1krXPu5RScfzXKkMHtGrIAA=; b=gUQhyFm0nWFTYLkOWQzmnh/vyN6UTEZJnBFc6Z1UuEEpW3eH1qXLkDDN WgWX6vUlVrUbrGIYFl8/0A7C+KaTyj8sADoVMen09FsJ0xDI+TPIjRqeh oHdncH06I2m+8pAUb5AoqnUsbQ5eUzyuMmUCxia30fCDdMTd4k7WwGAbi jm1wqL0tLLfR7thYIz7+gszeF50Q2Og+eftOA1hs3wcvC3oWYlazV5Y22 XSe+eltWjL1Ln5AoCswp7qvOvykw6qQ6I7i2dJ8vMPZ9XAKGlBGLr6diS DDgsw19Jz96RW/LCueIXPkjBY36jFTWmVz6NsBzwCKDdcdLvi9dbeUzSP Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10236"; a="245775958" X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="245775958" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2022 00:26:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="695340539" Received: from lkp-server01.sh.intel.com (HELO 276f1b88eecb) ([10.239.97.150]) by orsmga005.jf.intel.com with ESMTP; 24 Jan 2022 00:26:23 -0800 Received: from kbuild by 276f1b88eecb with local (Exim 4.92) (envelope-from ) id 1nBugA-000Hzt-GI; Mon, 24 Jan 2022 08:26:22 +0000 Date: Mon, 24 Jan 2022 16:25:22 +0800 From: kernel test robot To: NeilBrown , Trond Myklebust , Anna Schumaker , Chuck Lever , Andrew Morton , Mel Gorman , Christoph Hellwig , David Howells Cc: kbuild-all@lists.01.org, Linux Memory Management List , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/23] MM: submit multipage reads for SWP_FS_OPS swap-space Message-ID: <202201241613.8J5z5arQ-lkp@intel.com> References: <164299611278.26253.14950274629759580371.stgit@noble.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164299611278.26253.14950274629759580371.stgit@noble.brown> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gUQhyFm0; spf=none (imf29.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9E8E5120031 X-Stat-Signature: suwkx1f3sp3giejqy8yugsuy3o7rqx8n X-HE-Tag: 1643012787-290490 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi NeilBrown, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.17-rc1 next-20220124] [cannot apply to trondmy-nfs/linux-next cifs/for-next hnaz-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/NeilBrown/Repair-SWAP-over_NFS/20220124-115716 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd81e1c7d5fb126e5fbc5c9e334d7b3ec29a16a0 config: powerpc-allnoconfig (https://download.01.org/0day-ci/archive/20220124/202201241613.8J5z5arQ-lkp@intel.com/config) compiler: powerpc-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/63bff668aa0537d7ccef9ed428809fc16c1a6b6c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review NeilBrown/Repair-SWAP-over_NFS/20220124-115716 git checkout 63bff668aa0537d7ccef9ed428809fc16c1a6b6c # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All error/warnings (new ones prefixed by >>): In file included from mm/vmscan.c:61: mm/swap.h:66:40: warning: 'struct swap_iocb' declared inside parameter list will not be visible outside of this definition or declaration 66 | struct swap_iocb **plug); | ^~~~~~~~~ >> mm/swap.h:67:1: error: expected identifier or '(' before '{' token 67 | { | ^ mm/swap.h:65:19: warning: 'swap_readpage' declared 'static' but never defined [-Wunused-function] 65 | static inline int swap_readpage(struct page *page, bool do_poll, | ^~~~~~~~~~~~~ -- In file included from mm/memory.c:89: mm/swap.h:66:40: warning: 'struct swap_iocb' declared inside parameter list will not be visible outside of this definition or declaration 66 | struct swap_iocb **plug); | ^~~~~~~~~ >> mm/swap.h:67:1: error: expected identifier or '(' before '{' token 67 | { | ^ >> mm/swap.h:65:19: warning: 'swap_readpage' used but never defined 65 | static inline int swap_readpage(struct page *page, bool do_poll, | ^~~~~~~~~~~~~ -- In file included from mm/page_alloc.c:84: mm/swap.h:66:40: warning: 'struct swap_iocb' declared inside parameter list will not be visible outside of this definition or declaration 66 | struct swap_iocb **plug); | ^~~~~~~~~ >> mm/swap.h:67:1: error: expected identifier or '(' before '{' token 67 | { | ^ mm/page_alloc.c:3821:15: warning: no previous prototype for 'should_fail_alloc_page' [-Wmissing-prototypes] 3821 | noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order) | ^~~~~~~~~~~~~~~~~~~~~~ In file included from mm/page_alloc.c:84: mm/swap.h:65:19: warning: 'swap_readpage' declared 'static' but never defined [-Wunused-function] 65 | static inline int swap_readpage(struct page *page, bool do_poll, | ^~~~~~~~~~~~~ vim +67 mm/swap.h 50dceef273a619 NeilBrown 2022-01-24 45 50dceef273a619 NeilBrown 2022-01-24 46 struct page *read_swap_cache_async(swp_entry_t, gfp_t, 50dceef273a619 NeilBrown 2022-01-24 47 struct vm_area_struct *vma, 50dceef273a619 NeilBrown 2022-01-24 48 unsigned long addr, 63bff668aa0537 NeilBrown 2022-01-24 49 bool do_poll, 63bff668aa0537 NeilBrown 2022-01-24 50 struct swap_iocb **plug); 50dceef273a619 NeilBrown 2022-01-24 51 struct page *__read_swap_cache_async(swp_entry_t, gfp_t, 50dceef273a619 NeilBrown 2022-01-24 52 struct vm_area_struct *vma, 50dceef273a619 NeilBrown 2022-01-24 53 unsigned long addr, 50dceef273a619 NeilBrown 2022-01-24 54 bool *new_page_allocated); 50dceef273a619 NeilBrown 2022-01-24 55 struct page *swap_cluster_readahead(swp_entry_t entry, gfp_t flag, 50dceef273a619 NeilBrown 2022-01-24 56 struct vm_fault *vmf); 50dceef273a619 NeilBrown 2022-01-24 57 struct page *swapin_readahead(swp_entry_t entry, gfp_t flag, 50dceef273a619 NeilBrown 2022-01-24 58 struct vm_fault *vmf); 50dceef273a619 NeilBrown 2022-01-24 59 12cf545fe71035 NeilBrown 2022-01-24 60 static inline unsigned int page_swap_flags(struct page *page) 12cf545fe71035 NeilBrown 2022-01-24 61 { 12cf545fe71035 NeilBrown 2022-01-24 62 return page_swap_info(page)->flags; 12cf545fe71035 NeilBrown 2022-01-24 63 } 50dceef273a619 NeilBrown 2022-01-24 64 #else /* CONFIG_SWAP */ 63bff668aa0537 NeilBrown 2022-01-24 @65 static inline int swap_readpage(struct page *page, bool do_poll, 63bff668aa0537 NeilBrown 2022-01-24 @66 struct swap_iocb **plug); 50dceef273a619 NeilBrown 2022-01-24 @67 { 50dceef273a619 NeilBrown 2022-01-24 68 return 0; 50dceef273a619 NeilBrown 2022-01-24 69 } 50dceef273a619 NeilBrown 2022-01-24 70 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org