From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4BB1C433F5 for ; Thu, 20 Jan 2022 02:10:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 549FD6B00D8; Wed, 19 Jan 2022 21:10:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F9296B00D9; Wed, 19 Jan 2022 21:10:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E8236B00DA; Wed, 19 Jan 2022 21:10:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id 2FCB46B00D8 for ; Wed, 19 Jan 2022 21:10:42 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E5F4A8104230 for ; Thu, 20 Jan 2022 02:10:41 +0000 (UTC) X-FDA: 79049036682.05.0F8486B Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf07.hostedemail.com (Postfix) with ESMTP id 7E24C4002F for ; Thu, 20 Jan 2022 02:10:41 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7EBDAB81911; Thu, 20 Jan 2022 02:10:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09730C004E1; Thu, 20 Jan 2022 02:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1642644639; bh=1buiz3LHKvr/5IDVWEP49jRTxNZHKmv7vHP3bJrx57E=; h=Date:From:To:Subject:In-Reply-To:From; b=Zds32Qt7DOdiLkcSbfYL6i6QGhRjF7ge8d3WcSd0RLLOxBG+6PNpyq+c3IE65LMeJ nkpG0LWfj+CN5Hg3Opx26kPinPBYBK43HemmV7v5LBT3aXj+8p3SQ/cVC5w3cLX7dv I5ywOvcRWaz4jhE+WXq9br/NCkIUcdxVmDe4sMmk= Date: Wed, 19 Jan 2022 18:10:38 -0800 From: Andrew Morton To: akpm@linux-foundation.org, colin.i.king@gmail.com, jarkko@kernel.org, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 55/55] lib: remove redundant assignment to variable ret Message-ID: <20220120021038.j92W3L8QA%akpm@linux-foundation.org> In-Reply-To: <20220119180714.9e187ce100e4510de3cd9f7d@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7E24C4002F X-Stat-Signature: w1xkgcuf3u77uc6tbh1g74ts4roxziwq Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Zds32Qt7; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1642644641-367473 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Colin Ian King Subject: lib: remove redundant assignment to variable ret Variable ret is being assigned a value that is never read. If the for-loop is entered then ret is immediately re-assigned a new value. If the for-loop is not executed ret is never read. The assignment is redundant and can be removed. Link: https://lkml.kernel.org/r/20211230134557.83633-1-colin.i.king@gmail.com Signed-off-by: Colin Ian King Reviewed-by: Jarkko Sakkinen Signed-off-by: Andrew Morton --- lib/asn1_encoder.c | 2 -- 1 file changed, 2 deletions(-) --- a/lib/asn1_encoder.c~lib-remove-redundant-assignment-to-variable-ret +++ a/lib/asn1_encoder.c @@ -164,8 +164,6 @@ asn1_encode_oid(unsigned char *data, con data_len -= 3; - ret = 0; - for (i = 2; i < oid_len; i++) { ret = asn1_encode_oid_digit(&d, &data_len, oid[i]); if (ret < 0) _