From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 102A9C4332F for ; Thu, 20 Jan 2022 02:08:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2E7E6B0082; Wed, 19 Jan 2022 21:08:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DE5C6B0083; Wed, 19 Jan 2022 21:08:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CD286B0085; Wed, 19 Jan 2022 21:08:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id 79FE76B0082 for ; Wed, 19 Jan 2022 21:08:06 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 38278181CB2CC for ; Thu, 20 Jan 2022 02:08:06 +0000 (UTC) X-FDA: 79049030172.22.7E9F924 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id A43E118001E for ; Thu, 20 Jan 2022 02:08:05 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BFD3A61546; Thu, 20 Jan 2022 02:08:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF03BC004E1; Thu, 20 Jan 2022 02:08:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1642644484; bh=AflCnBXLUWeAvAcbs1hf0gtmL5D1A0nl1HN1bIdEWsg=; h=Date:From:To:Subject:In-Reply-To:From; b=XoZz1iQoTqAMJmw0ERavmVfB4KHleSEpn06oUCDdGiV40ZccwwsaoTYL0nLCytYGV ox0WGtCMxfe7MXa66HVbXfbvy3dC1Snq7AidvN3XNYRZx7U7qIq0S/5S7G5HhUpgWv NrNOGcco8z+GX04kJYJ1ZtadCrLwC/O47eGIaxic= Date: Wed, 19 Jan 2022 18:08:03 -0800 From: Andrew Morton To: adobriyan@gmail.com, akpm@linux-foundation.org, keescook@chromium.org, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org, zhengqi.arch@bytedance.com Subject: [patch 07/55] proc: convert the return type of proc_fd_access_allowed() to be boolean Message-ID: <20220120020803.B1AdljNwl%akpm@linux-foundation.org> In-Reply-To: <20220119180714.9e187ce100e4510de3cd9f7d@linux-foundation.org> User-Agent: s-nail v14.8.16 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=XoZz1iQo; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: 3x6j8bbrp1k6kybzx89at3qoc8okiusa X-Rspamd-Queue-Id: A43E118001E X-Rspamd-Server: rspam12 X-HE-Tag: 1642644485-903448 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Qi Zheng Subject: proc: convert the return type of proc_fd_access_allowed() to be boolean Convert return type of proc_fd_access_allowed() and the 'allowed' in it to be boolean since the return type of ptrace_may_access() is boolean. Link: https://lkml.kernel.org/r/20211219024404.29779-1-zhengqi.arch@bytedance.com Signed-off-by: Qi Zheng Cc: Kees Cook Cc: Alexey Dobriyan Signed-off-by: Andrew Morton --- fs/proc/base.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/proc/base.c~proc-convert-the-return-type-of-proc_fd_access_allowed-to-be-boolean +++ a/fs/proc/base.c @@ -670,10 +670,10 @@ static int proc_pid_syscall(struct seq_f /************************************************************************/ /* permission checks */ -static int proc_fd_access_allowed(struct inode *inode) +static bool proc_fd_access_allowed(struct inode *inode) { struct task_struct *task; - int allowed = 0; + bool allowed = false; /* Allow access to a task's file descriptors if it is us or we * may use ptrace attach to the process and find out that * information. _