From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A515DC433EF for ; Sat, 15 Jan 2022 22:10:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 914AA6B0092; Sat, 15 Jan 2022 17:10:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C2FB6B0093; Sat, 15 Jan 2022 17:10:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78B5A6B0096; Sat, 15 Jan 2022 17:10:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id 68D086B0092 for ; Sat, 15 Jan 2022 17:10:27 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1AD1C824C429 for ; Sat, 15 Jan 2022 22:10:27 +0000 (UTC) X-FDA: 79033916094.26.E450EF6 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf24.hostedemail.com (Postfix) with ESMTP id B87BB180005 for ; Sat, 15 Jan 2022 22:10:26 +0000 (UTC) Received: by mail-ed1-f50.google.com with SMTP id t24so48346564edi.8 for ; Sat, 15 Jan 2022 14:10:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EPbI8Tt0WfUMwAmaR0DL4u0NGyT4Pfp5ibYD0UcG0DI=; b=agj6fChYEnKrSoNxBVq48eG35QoBd5Z4IF+iAiicRpU2JWeJ9LfMJNox6L4q2g2RBL 4ETDJyBfAyhwTeit7qORH7ag0LnhF2LlADK4vfaVOzEQi/ZW5lHvfa82MDys4hXQK+C3 4hJN/NnQMc73yqTl5qISSYt5yrcUMzgCFAXwTi3GLM1kOeIw6js15Tx/R0XIYwz6PTXa 4ZwyvjW7pSAjcoWl9BMhmTQ0SloTVQLPkExYXobQE08n1ZfTuuww4aVBjSKCVRKtf75l UwhvkbPdJkfEIcvOk0IyuUjkHa+J6Ffexa9DabrExe6AtDsr+WdXHHvkyFsvbMoVt92K o4yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=EPbI8Tt0WfUMwAmaR0DL4u0NGyT4Pfp5ibYD0UcG0DI=; b=5Jy3ceKY228+kISh8XuJCAAIhX22838bmAdAUV3/bF/y4S+3o5I/4X33lhiEPnvYQy A8RtGlZfhAlU2D3ze/mea+ZLJ72P+wtKkolIKYAVPvUq3cSLpKNQzfAF+yT5gOl8alvU YraSu8+jF44uf6wec0eOGbnmVVV0RZHDEAWu8NkR/DDMHRMn99wZjETwDYIpeLohMRNl XNq5g0n/XLkmZNMYXMdToLwJuNOhTkJSmEPKz93kXxruGrO1S3xmjjTuGNvO5vU2q/SC w1/9PKZHaJ3eX90hs8DWdFFEmEjZBdWjzQcgf8g4G2zWpSBdhjMacCNPAqs4KD1uroVb sHRw== X-Gm-Message-State: AOAM533pxNWXZU1VVHR+Tty8cEtxHmUPN/KhiLCmD1hKr5pAPHhxKacR hcl+ytmuMYkcyJopo2gqFyw= X-Google-Smtp-Source: ABdhPJyyNWOlbijFCkXzof9hTCK0gRxJs24hN60XetvbzrKmVaUKeHF2ngn5PutlX7rMQmoqy+A9jQ== X-Received: by 2002:a17:907:9085:: with SMTP id ge5mr12006871ejb.128.1642284624835; Sat, 15 Jan 2022 14:10:24 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id j5sm2957736ejo.177.2022.01.15.14.10.24 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 15 Jan 2022 14:10:24 -0800 (PST) Date: Sat, 15 Jan 2022 22:10:23 +0000 From: Wei Yang To: Michal Hocko Cc: Wei Yang , hannes@cmpxchg.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, shakeelb@google.com, guro@fb.com, vbabka@suse.cz, willy@infradead.org, songmuchun@bytedance.com, shy828301@gmail.com, surenb@google.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/4] mm/memcg: use NUMA_NO_NODE to indicate allocation from unspecified node Message-ID: <20220115221023.qndjlehjxdrj5r6b@master> Reply-To: Wei Yang References: <20220111010302.8864-1-richard.weiyang@gmail.com> <20220112004634.dc5suwei4ymyxaxg@master> <20220114002937.fnyq3yyk36j4nb3d@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: B87BB180005 X-Stat-Signature: qgargay19778r9t3ok8h443qp83o13x9 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=agj6fChY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com X-Rspamd-Server: rspam03 X-HE-Tag: 1642284626-823620 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 14, 2022 at 09:51:31AM +0100, Michal Hocko wrote: >On Fri 14-01-22 00:29:37, Wei Yang wrote: >> On Wed, Jan 12, 2022 at 09:56:15AM +0100, Michal Hocko wrote: >> >On Wed 12-01-22 00:46:34, Wei Yang wrote: >> >> On Tue, Jan 11, 2022 at 09:40:20AM +0100, Michal Hocko wrote: >> >> >On Tue 11-01-22 01:02:59, Wei Yang wrote: >> >> >> Instead of use "-1", let's use NUMA_NO_NODE for consistency. >> >> >> >> >> >> Signed-off-by: Wei Yang >> >> > >> >> >I am not really sure this is worth it. After the merge window I plan to >> >> >post http://lkml.kernel.org/r/20211214100732.26335-1-mhocko@kernel.org. >> >> >> >> Give me some time to understand it :-) >> > >> >Just for the record, here is what I have put on top of that series: >> >> Ok, I got what you try to resolve. I am ok with the following change except >> one point. >> >> >--- >> >>From b7195eba02fe6308a6927450f4630057c05e808e Mon Sep 17 00:00:00 2001 >> >From: Wei Yang >> >Date: Tue, 11 Jan 2022 09:45:25 +0100 >> >Subject: [PATCH] memcg: do not tweak node in alloc_mem_cgroup_per_node_info >> > >> >alloc_mem_cgroup_per_node_info is allocated for each possible node and >> >this used to be a problem because not !node_online nodes didn't have >> >appropriate data structure allocated. This has changed by "mm: handle >> >uninitialized numa nodes gracefully" so we can drop the special casing >> >here. >> > >> >Signed-off-by: Wei Yang >> >Signed-off-by: Michal Hocko >> >--- >> > mm/memcontrol.c | 14 ++------------ >> > 1 file changed, 2 insertions(+), 12 deletions(-) >> > >> >diff --git a/mm/memcontrol.c b/mm/memcontrol.c >> >index 781605e92015..ed19a21ee14e 100644 >> >--- a/mm/memcontrol.c >> >+++ b/mm/memcontrol.c >> >@@ -5044,18 +5044,8 @@ struct mem_cgroup *mem_cgroup_from_id(unsigned short id) >> > static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) >> > { >> > struct mem_cgroup_per_node *pn; >> >- int tmp = node; >> >- /* >> >- * This routine is called against possible nodes. >> >- * But it's BUG to call kmalloc() against offline node. >> >- * >> >- * TODO: this routine can waste much memory for nodes which will >> >- * never be onlined. It's better to use memory hotplug callback >> >- * function. >> >- */ >> >> Do you think this TODO is not related to this change? > >It is not really related but I am not sure how useful it is. Essentially >any allocation that is per-possible node is in the same situation and if >we really need to deal with large and sparse possible nodes masks. > Sounds reasonable :-) >If you want me to keep the TODO I will do it though. > >-- >Michal Hocko >SUSE Labs -- Wei Yang Help you, Help me