From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E7ECC433F5 for ; Fri, 14 Jan 2022 22:05:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C615B6B00E2; Fri, 14 Jan 2022 17:05:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C10946B00E4; Fri, 14 Jan 2022 17:05:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8BAE6B00E6; Fri, 14 Jan 2022 17:05:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0239.hostedemail.com [216.40.44.239]) by kanga.kvack.org (Postfix) with ESMTP id 8C5C56B00E2 for ; Fri, 14 Jan 2022 17:05:35 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 58C008EC06 for ; Fri, 14 Jan 2022 22:05:35 +0000 (UTC) X-FDA: 79030275030.19.A43CA94 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id E9BF4140008 for ; Fri, 14 Jan 2022 22:05:34 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C3F4061FF0; Fri, 14 Jan 2022 22:05:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E834FC36AE9; Fri, 14 Jan 2022 22:05:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1642197933; bh=2dP30ttTaKtwyHMkE9iApBpNEEQRRLNZqJO6/Y8n2eE=; h=Date:From:To:Subject:In-Reply-To:From; b=Gcz+tMtM5C77uFuemT4Ze5ZNv7esbd32Ybx//cC3yb41GkF0MVnZeNB1Ss+uxIwy4 MLrD7HKzEFmukqpRIRBvWE25qS1i/evYAjVHkQD+G+OorUcUitXspH0uHi92pS+yrj uNngePFWXte15EI80ZpHSnsV9uCNLSxVzqyUjSS0= Date: Fri, 14 Jan 2022 14:05:32 -0800 From: Andrew Morton To: akpm@linux-foundation.org, dqiao@redhat.com, guro@fb.com, hannes@cmpxchg.org, linux-mm@kvack.org, mhocko@kernel.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 049/146] mm/page_counter: remove an incorrect call to propagate_protected_usage() Message-ID: <20220114220532.E3LmAAg_1%akpm@linux-foundation.org> In-Reply-To: <20220114140222.6b14f0061194d3200000c52d@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E9BF4140008 X-Stat-Signature: bhxksogqdhd6npfxb3ha61cyejbyjpd9 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Gcz+tMtM; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1642197934-897320 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Donghai Qiao Subject: mm/page_counter: remove an incorrect call to propagate_protected_usage() propagate_protected_usage() is called to propagate the usage change in the page_counter structure. But there is a call to this function from page_counter_try_charge() when there is actually no usage change. Hence this call should be removed. Link: https://lkml.kernel.org/r/20211118181125.3918222-1-dqiao@redhat.com Signed-off-by: Donghai Qiao Reviewed-by: Roman Gushchin Cc: Michal Hocko Cc: Johannes Weiner Signed-off-by: Andrew Morton --- mm/page_counter.c | 1 - 1 file changed, 1 deletion(-) --- a/mm/page_counter.c~mm-page_counter-remove-an-incorrect-call-to-propagate_protected_usage +++ a/mm/page_counter.c @@ -120,7 +120,6 @@ bool page_counter_try_charge(struct page new = atomic_long_add_return(nr_pages, &c->usage); if (new > c->max) { atomic_long_sub(nr_pages, &c->usage); - propagate_protected_usage(c, new); /* * This is racy, but we can live with some * inaccuracy in the failcnt which is only used _