From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9D9DC433F5 for ; Fri, 14 Jan 2022 22:05:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44C8E6B00D5; Fri, 14 Jan 2022 17:05:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FB4C6B00D7; Fri, 14 Jan 2022 17:05:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C3526B00D8; Fri, 14 Jan 2022 17:05:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 165D86B00D5 for ; Fri, 14 Jan 2022 17:05:14 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CE8788EC06 for ; Fri, 14 Jan 2022 22:05:13 +0000 (UTC) X-FDA: 79030274106.12.94DA57A Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf21.hostedemail.com (Postfix) with ESMTP id 615081C0006 for ; Fri, 14 Jan 2022 22:05:13 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3E31AB82630; Fri, 14 Jan 2022 22:05:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFDB2C36AE5; Fri, 14 Jan 2022 22:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1642197911; bh=/twb55yQS27uFy5si8zT+X4JSRlJUwALW3K1cG2Y3Jo=; h=Date:From:To:Subject:In-Reply-To:From; b=pEtNffu4lJWbtlZK1niuqiYA4dclWY47QVesHdOW+2PTUxm4nhqOjzQ83Ruh9tA/V zDHDciHRQymnMTf6+PdhpmzxvT0kErbotnK+D1Px8IBC+Uy0QCZnGYMckE0aZiNnwg PiDMBVBQvd5OVWjL0jMYaLRzQi6Zup7r27NLStDI= Date: Fri, 14 Jan 2022 14:05:10 -0800 From: Andrew Morton To: akpm@linux-foundation.org, chi.minghao@zte.com.cn, david@redhat.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, pankaj.gupta@ionos.com, songmuchun@bytedance.com, torvalds@linux-foundation.org, zealci@zte.com.cm Subject: [patch 042/146] mm/truncate.c: remove unneeded variable Message-ID: <20220114220510.-gWU9LZq3%akpm@linux-foundation.org> In-Reply-To: <20220114140222.6b14f0061194d3200000c52d@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 615081C0006 X-Stat-Signature: od8ckasxeijdiwyszdam7wo5dthk8g3t Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=pEtNffu4; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1642197913-51488 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: chiminghao Subject: mm/truncate.c: remove unneeded variable Return value directly instead of taking this in another redundant variable. Link: https://lkml.kernel.org/r/20211207083222.401594-1-chi.minghao@zte.com.cn Signed-off-by: chiminghao Reported-by: Zeal Robot Reviewed-by: David Hildenbrand Reviewed-by: Pankaj Gupta Reviewed-by: Muchun Song Signed-off-by: Andrew Morton --- mm/truncate.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/mm/truncate.c~mm-remove-unneeded-variable +++ a/mm/truncate.c @@ -205,7 +205,6 @@ static void truncate_cleanup_page(struct static int invalidate_complete_page(struct address_space *mapping, struct page *page) { - int ret; if (page->mapping != mapping) return 0; @@ -213,9 +212,7 @@ invalidate_complete_page(struct address_ if (page_has_private(page) && !try_to_release_page(page, 0)) return 0; - ret = remove_mapping(mapping, page); - - return ret; + return remove_mapping(mapping, page); } int truncate_inode_page(struct address_space *mapping, struct page *page) _