From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97A19C433EF for ; Fri, 14 Jan 2022 22:03:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 204BF6B009E; Fri, 14 Jan 2022 17:03:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 18D506B009F; Fri, 14 Jan 2022 17:03:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 005C16B00A0; Fri, 14 Jan 2022 17:03:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0100.hostedemail.com [216.40.44.100]) by kanga.kvack.org (Postfix) with ESMTP id DCAB66B009E for ; Fri, 14 Jan 2022 17:03:38 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9E3C982F4BEE for ; Fri, 14 Jan 2022 22:03:38 +0000 (UTC) X-FDA: 79030270116.19.E1850DE Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf05.hostedemail.com (Postfix) with ESMTP id 37081100007 for ; Fri, 14 Jan 2022 22:03:38 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3F7ADB8262F; Fri, 14 Jan 2022 22:03:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A27FDC36AE9; Fri, 14 Jan 2022 22:03:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1642197816; bh=u+LK7xStWhkzJS7v1TapIAfJyzhoww3EmEoACQ3I534=; h=Date:From:To:Subject:In-Reply-To:From; b=YDqU61Qf0lRKCRlJ80SD8Yc7jX/vRN2kZ2LntfVdaB2Jnvm0sIaGeqme7SMDE2Xqd VGxjQS96StrCTZyE/6tt2m9NBb4t4lAvDZ6UyIUwRg8ZAN4lvj/1MMmen20hlzvNhE y484cfc+ThkwrhHsRg4tBZLVqxlWiymBQb5p2K9o= Date: Fri, 14 Jan 2022 14:03:35 -0800 From: Andrew Morton To: akpm@linux-foundation.org, gechangwei@live.cn, ghe@suse.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, junxiao.bi@oracle.com, linux-mm@kvack.org, mark@fasheh.com, mm-commits@vger.kernel.org, piaojun@huawei.com, torvalds@linux-foundation.org, zealci@zte.com.cn, zhang.mingyu@zte.com.cn Subject: [patch 014/146] ocfs2: use BUG_ON instead of if condition followed by BUG. Message-ID: <20220114220335.-FP0r81CP%akpm@linux-foundation.org> In-Reply-To: <20220114140222.6b14f0061194d3200000c52d@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 37081100007 X-Stat-Signature: 71pb93gj4m53bixrhiwy5dycemqoh3m1 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=YDqU61Qf; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1642197818-681757 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000574, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Zhang Mingyu Subject: ocfs2: use BUG_ON instead of if condition followed by BUG. This issue was detected with the help of Coccinelle. Link: https://lkml.kernel.org/r/20211105014424.75372-1-zhang.mingyu@zte.com.cn Signed-off-by: Zhang Mingyu Reported-by: Zeal Robot Acked-by: Joseph Qi Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Gang He Cc: Jun Piao Signed-off-by: Andrew Morton --- fs/ocfs2/journal.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/fs/ocfs2/journal.c~ocfs2-use-bug_on-instead-of-if-condition-followed-by-bug +++ a/fs/ocfs2/journal.c @@ -1669,8 +1669,7 @@ static int ocfs2_replay_journal(struct o status = jbd2_journal_load(journal); if (status < 0) { mlog_errno(status); - if (!igrab(inode)) - BUG(); + BUG_ON(!igrab(inode)); jbd2_journal_destroy(journal); goto done; } @@ -1699,8 +1698,7 @@ static int ocfs2_replay_journal(struct o if (status < 0) mlog_errno(status); - if (!igrab(inode)) - BUG(); + BUG_ON(!igrab(inode)); jbd2_journal_destroy(journal); _