From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5535C433FE for ; Fri, 14 Jan 2022 22:03:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AD4B6B0083; Fri, 14 Jan 2022 17:03:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 535976B0085; Fri, 14 Jan 2022 17:03:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D7116B0087; Fri, 14 Jan 2022 17:03:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0091.hostedemail.com [216.40.44.91]) by kanga.kvack.org (Postfix) with ESMTP id 216C16B0083 for ; Fri, 14 Jan 2022 17:03:17 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D6D9A1826B6AD for ; Fri, 14 Jan 2022 22:03:16 +0000 (UTC) X-FDA: 79030269192.18.6F85778 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf01.hostedemail.com (Postfix) with ESMTP id 526E54000A for ; Fri, 14 Jan 2022 22:03:16 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4DFE3B82A26; Fri, 14 Jan 2022 22:03:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA8C8C36AE9; Fri, 14 Jan 2022 22:03:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1642197794; bh=nn0CO68Tivwlt2P/Mnr6cdxvJP90N3hXPXfcfMMqJqw=; h=Date:From:To:Subject:In-Reply-To:From; b=V8oMPiRYlEtTcfr49iFfTNFP2Ud0+o2xB9cgwZ3ozaJrBMALGSwfqU1oDfupmUsrt SqviG6K+C1c0Kwp26p23e4vNwkuMqvbPrW6R/didNeJaHbmH9Rl/4BDQ1GorEypbeu HbhnPz4QgB7b7aTCSZdtiqF/bVim1um3PfYmcSAU= Date: Fri, 14 Jan 2022 14:03:13 -0800 From: Andrew Morton To: akpm@linux-foundation.org, davidcomponentone@gmail.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org, yang.guang5@zte.com.cn, zealci@zte.com.cn Subject: [patch 007/146] ia64: module: use swap() to make code cleaner Message-ID: <20220114220313._cn9cqHJT%akpm@linux-foundation.org> In-Reply-To: <20220114140222.6b14f0061194d3200000c52d@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Queue-Id: 526E54000A X-Stat-Signature: 8qgpaticbc13rqfiqsdghub583tqiaao Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=V8oMPiRY; dmarc=none; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam03 X-HE-Tag: 1642197796-929788 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Yang Guang Subject: ia64: module: use swap() to make code cleaner Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid opencoding it. Link: https://lkml.kernel.org/r/20211104062642.1506539-1-yang.guang5@zte.com.cn Signed-off-by: Yang Guang Reported-by: Zeal Robot Cc: David Yang Signed-off-by: Andrew Morton --- arch/ia64/kernel/module.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/arch/ia64/kernel/module.c~ia64-module-use-swap-to-make-code-cleaner +++ a/arch/ia64/kernel/module.c @@ -848,7 +848,7 @@ register_unwind_table (struct module *mo { struct unw_table_entry *start = (void *) mod->arch.unwind->sh_addr; struct unw_table_entry *end = start + mod->arch.unwind->sh_size / sizeof (*start); - struct unw_table_entry tmp, *e1, *e2, *core, *init; + struct unw_table_entry *e1, *e2, *core, *init; unsigned long num_init = 0, num_core = 0; /* First, count how many init and core unwind-table entries there are. */ @@ -865,9 +865,7 @@ register_unwind_table (struct module *mo for (e1 = start; e1 < end; ++e1) { for (e2 = e1 + 1; e2 < end; ++e2) { if (e2->start_offset < e1->start_offset) { - tmp = *e1; - *e1 = *e2; - *e2 = tmp; + swap(*e1, *e2); } } } _