From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21C4CC433EF for ; Wed, 12 Jan 2022 00:24:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 481296B00FC; Tue, 11 Jan 2022 19:24:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4312A6B00FD; Tue, 11 Jan 2022 19:24:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31E456B00FE; Tue, 11 Jan 2022 19:24:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id 269B36B00FC for ; Tue, 11 Jan 2022 19:24:25 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BD7F01817B082 for ; Wed, 12 Jan 2022 00:24:24 +0000 (UTC) X-FDA: 79019738448.22.88EC087 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf22.hostedemail.com (Postfix) with ESMTP id 3747CC0011 for ; Wed, 12 Jan 2022 00:24:24 +0000 (UTC) Received: by mail-ed1-f41.google.com with SMTP id b13so3278401edn.0 for ; Tue, 11 Jan 2022 16:24:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dFpazlv+lywoGwl9/cFSYAAABBv6zxWMmcLpH0m+3/M=; b=Jvwa9TaIcLtrQXSCOZEpvt5o4j62C2t3W/QMQ/KHJ/fiv10OoW6JKvXj5KBsR6XAd9 YTJX3yMs+oReKUEusB6HXOycLwagLJUD3wZlEY4LzzdZZk2UhbnmiM2kmyYYwY3bXcry I5k+BCombR71JSn6bX3+5Knoym/PI1ut2Mzwc/VjfVDq/AqE04o8xf4fXQz5FmaHuweo JkXPznZqOnmSwakVWgUKEGUyT9xIufjGXDTNb8kX1g956DAXLnicAHPkoZITy9/nV74M TdhGyqIuaWMDnKnhm95W6/P6RSpUBTjyJ0EQAGayOmRlDg58JOSj8qZKnbD+IR6TiQkT Fhdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=dFpazlv+lywoGwl9/cFSYAAABBv6zxWMmcLpH0m+3/M=; b=VjTU+IgSdXUdzqsGfAHhh7YNrzJtMHm2YT931UDMEW2/SbtAUsiA9IMAmTjxmNaXKa eAmXHJ/T0J2OlIFyrELDu/+EN3e8zZ6cq++d3gTAzImiZKBm9wBfDPJ5TM5N5fLWlv31 SsMBNQZ5jbGN86MPIi5C+j+vJq4F5mt+JYOrMAxKRwigct7oyf7ERUC5O/gdcjKjSqgM yWKkDpW96YCZdcw1XHfdWmLmMhNfirRFJpSpi1gfoM6RlVvdiBlZeDTPScS3XCVGIl4v 8RfG6CpwgLNC2PiB1eHXSSJM3Ka4kQeiEKGlYaTwZ1b3AxIzOs1HxA3vl/wn/0RW2taF ab3g== X-Gm-Message-State: AOAM531B/yjlOelEFh51uZ3kYMRKdiWyYQnmuxvfM9N3XPRGfGte8PYB Z/e6oxZDMjPmbEZynJ6PLyA= X-Google-Smtp-Source: ABdhPJxbp1jqOMEDjz32OniUVIm0N2DkA9bp6QjRfoPbyPBgiQ99JQe7N3wdX7/klyg2U5f09KGbYA== X-Received: by 2002:a05:6402:1764:: with SMTP id da4mr6500959edb.324.1641947062977; Tue, 11 Jan 2022 16:24:22 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id w17sm183314edr.68.2022.01.11.16.24.22 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Jan 2022 16:24:22 -0800 (PST) Date: Wed, 12 Jan 2022 00:24:21 +0000 From: Wei Yang To: Roman Gushchin Cc: Wei Yang , hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, shakeelb@google.com, vbabka@suse.cz, willy@infradead.org, songmuchun@bytedance.com, shy828301@gmail.com, surenb@google.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/4] mm/memcg: retrieve parent memcg from css.parent Message-ID: <20220112002421.m3fyktkkz55fup3v@master> Reply-To: Wei Yang References: <20220111010302.8864-1-richard.weiyang@gmail.com> <20220111010302.8864-3-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3747CC0011 X-Stat-Signature: sy7u3oxs8bp48tzb9usqwn7ei5t757xz Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Jvwa9TaI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com X-HE-Tag: 1641947064-830192 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000170, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 11, 2022 at 10:09:52AM -0800, Roman Gushchin wrote: >On Tue, Jan 11, 2022 at 01:03:01AM +0000, Wei Yang wrote: >> The parent we get from page_counter is correct, while this is two >> different hierarchy. >> >> Let's retrieve the parent memcg from css.parent just like parent_cs(), >> blkcg_parent(), etc. > >Does it bring any benefits except consistency? > I am afraid no. >> >> Signed-off-by: Wei Yang > >Reviewed-by: Roman Gushchin > >Thanks! -- Wei Yang Help you, Help me