From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7941FC433EF for ; Thu, 6 Jan 2022 09:12:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F5F66B0073; Thu, 6 Jan 2022 04:12:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A6576B0074; Thu, 6 Jan 2022 04:12:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 645FB6B0075; Thu, 6 Jan 2022 04:12:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id 52DA26B0073 for ; Thu, 6 Jan 2022 04:12:24 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 010BE823368B for ; Thu, 6 Jan 2022 09:12:24 +0000 (UTC) X-FDA: 78999296208.28.F0A714D Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf14.hostedemail.com (Postfix) with ESMTP id A13DB100003 for ; Thu, 6 Jan 2022 09:12:21 +0000 (UTC) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2067Xmqf013477; Thu, 6 Jan 2022 09:12:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2021-07-09; bh=K8FcUX9dog4QptB4wHKDA+47O3CPnEl2eSfgQyb4wkQ=; b=Y0ragyf5F+yTRRmX4h/3Q8ouCB1nv64KUn+Jh2MddkOCL8kgZDxkip4HapDLXDvNG/19 ZUMcN6v35prp8tfN4l38jkiLjOwB6IuoIbBZXaYMjDu/IOlUdw0r1anCi5qzvXfMjWO5 jDpwP84Ul21mGja1q+DhnJjetsZwBEBxWOvcVLYHpXPiUvG74IwUg3dw2lfHaodIspol 2TxMRHosK57f5zyucXKWyNchiGD4J7m/UKcN5SrfpfQkc6HB678uK9ANU3azsgG+PW3R fmsgSItMlC7N1z4i3Pt8l9bVJumNFWn72VYrPHY2QPaWFuUkYvSqs8hzIJjniuJbpIzs dQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3ddmpmh5ju-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Jan 2022 09:12:22 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 20695gVr127437; Thu, 6 Jan 2022 09:12:21 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2176.outbound.protection.outlook.com [104.47.56.176]) by aserp3020.oracle.com with ESMTP id 3ddmqajtht-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Jan 2022 09:12:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S0ll7AFZOnX9kpmRrtjzjBW9DEWPD+t51sQLTt13F+6OrrkpuaTDusuNDpbG3tlvekSXJaqRfE0yCTwgZUqE4efDJf1hw5Yh9WIoCvbeKBiylQt0qImWl3zwbabJ3AYxJb5fAmqpfzrTn+D0Btonby2eorj5sVLbrGFZUESsNHfOcGnI790RDEJo4tr3xtaI+QyVqlFfLDX6WjO8QoUfowHRMyggp6jDi60Fhwj1GyOvCEeHMk7J849/mBclJ7rUMwf0I+0YEElkiMYI/376aBr6Y9K7/zZ3UhIhUKGGVdJVFzE2CBzXjCPL8y91MP/x03HqWozP1viaARpd90HDAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K8FcUX9dog4QptB4wHKDA+47O3CPnEl2eSfgQyb4wkQ=; b=GdCWy656XPpzYxtF+R42FwWWA9QpzqA+dFJQ8Y07o6BJFhXwJXfCBHATYYALRkVA5Cz2PSvyYE3SDqpDiod+/EQcZgMd5l1VxBHzuYNLC3eRlbFmr3NGnrYBNpc69GTvPpejJdXvx/BWj2JX8zMuCxwJdJgHy3QsPvKKp5bWUO9dW0//hR4f0P580/N9Ymwp214DTAzen8gDa0uxwyQQsrs7rSBToqH4pNk78Yd7SrDOkl8JftKka2M075z2XBbyOU8q3uZxbX4uTGcd14t//6JU0Ouc/8nYKxhsvI40etpPGjhfM3v0FjtP0F5nB0DlmBztXVmg04XxCogsjpxvzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K8FcUX9dog4QptB4wHKDA+47O3CPnEl2eSfgQyb4wkQ=; b=YZYXn5oft/prnGtFDwJrMdg5pZzFqTSIeOhMl+dkefK4gwwi4csx7bZbEOuu+rIBORCIWdVLvRbitAkUILQB9eLnzywbg+kN98DXRUG+Yy97DwSBmtTqa1i/o7DbuTrwqQIn/Kjp+H6fTVfzM/DzM9jGjHqBUknF2w573DkMfCw= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by MWHPR1001MB2159.namprd10.prod.outlook.com (2603:10b6:301:2c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.16; Thu, 6 Jan 2022 09:12:18 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::b889:5c86:23c0:82b8]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::b889:5c86:23c0:82b8%4]) with mapi id 15.20.4844.016; Thu, 6 Jan 2022 09:12:18 +0000 Date: Thu, 6 Jan 2022 12:12:00 +0300 From: Dan Carpenter To: baolin.wang@linux.alibaba.com Cc: linux-mm@kvack.org Subject: [bug report] mm/damon: add access checking for hugetlb pages Message-ID: <20220106091200.GA14564@kili> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: ZR0P278CA0111.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::8) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cf102cb5-51c4-4a20-feff-08d9d0f4a377 X-MS-TrafficTypeDiagnostic: MWHPR1001MB2159:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0vHuoFAfBGnWekAXkElTUWJvN+SQnMPLYXKEeM51pCX0aLU13yVhokq66ZqFScFm3y10B/LpGp0gtGMtVMFsRVqRQpyHQJPIF4yjotTTbHyNfcrnPXuNh8rHsLhiuCEamjYPc2hhelFb3lGSd57n9TGE7zJBjiHd3T//hk6i9XEs1HCd5+djwqu2knYZL0QJaDLONNAasLnvWr9tjUpjy26MXvceoUwVzQmS0DfQ9BZ8WqqIvMrYIwg1JxrcKN/BhG3jLyqZEHNHC6Ux53Z/oLek53zOVjYuwkOTrTqTmcYQJl2Q9X4GdsgFWR2ehIw+8BAaEBmkA5h2HubWmj5PRQ4gOeAjTmXdPsOly4YXhOZxddMYUV/HH8Q2/ENbZR1j/YWUP2PPruDsNoI7MbeJniZVl5P0ztrOEN3NJPkhHFfaneeR/89qiAT8t2VnMp8iJvOjOFM4cowcDmFR+GhYV5yOi2VsSO3+OTruMoyV/AwKkfR2nJDoEkWGTlsMIcEe9hsPioYuM0RN/ZBnBqlEbCBknCpGVdpmwAjndjbXUxniugf/oLFRJ+r1VinF0E1H/KwqMi1cjz4ZvT/E+2FpwnpKJna1BIzr4kHoJ42wc4hr23ciBmRUGN2tbuK4FkPIxGG82z7yd7Ypycbpx2jJfrjBP4KDgcUwT4wggpb4ZjWrBbySTgdjptP2ySYMX7aYf/8V5+zk6/zefqdGidexfA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(366004)(26005)(66476007)(1076003)(66946007)(4744005)(9686003)(186003)(38350700002)(33656002)(6916009)(66556008)(83380400001)(33716001)(38100700002)(44832011)(8676002)(508600001)(6512007)(316002)(4326008)(6506007)(2906002)(6666004)(8936002)(86362001)(5660300002)(52116002)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wuT7jZj7vHSriNDy0KLcmgXpfG0JiJJT0f4lKNbtxl0GUgqT8Y0E6Di+Ji0q?= =?us-ascii?Q?GQvSrS7aaxO8lQPdy5vNGmiRv9wiVTP7BAOtSVtk2IP/Y4fzsKsEyjpjQn4W?= =?us-ascii?Q?OMtmWISqlcYhpIq05+3+3y2gEcXMOV1ngtPKEy+e5zvkPHOGeP3FF9bP/A/a?= =?us-ascii?Q?R45cZtHBLsU95uP0+PSFjDGxVscu+b2Z65eIgeKEekv+9I1Fs4n15rj+u9bL?= =?us-ascii?Q?2XtyEGo6OD7selZL8UyOcMs2eWPHz8H64eLjbXil/mVsxw03Ns2nRl8SxLGn?= =?us-ascii?Q?UEcxrS81RTn5mc1dj3lbPH8C2BuaWwPlHkRq9ZGRI36tJ1hA6jBnowaBb36w?= =?us-ascii?Q?islKPvgbCM2qtP0pzJ3Ewq2d+Igl3DMA+7D2q8onoBjouHI1IN8y0C3cmfaM?= =?us-ascii?Q?oHE7Gd3obrc4lFmhZ5c1dG1tqqLTpXjF4rNY5WMJm60eVCEmThlp/bwcBqQT?= =?us-ascii?Q?aRwHeMs4qtml+XvdQsnB0228rzf7VjBQjyfQnTX8JhGt+nFRcFQaodiHfbZp?= =?us-ascii?Q?NXOBeS19YvGWUIBTTL7gGEpPzweZm2DF7ZdiuUIuFGN6xQAI6Euw7LaIUpeJ?= =?us-ascii?Q?OCXbsjk7wolbrmh6PfsSzp9qcOCzY8KDtaMxPFQ9CFQeRR+JVZ8IN8KdJglN?= =?us-ascii?Q?GysurLeZDBFwccf2ce17ThlVPhAgaGupE3pg5J+k+YriZoBnTczqbdSPwwLn?= =?us-ascii?Q?dqgru261fpG4lnT0kdV5CDgIWpmHxVCufkqc1W3Y/r3pSLzpTIkF/owYJXwC?= =?us-ascii?Q?e7W3/26lfbiKDY3QxfLJJQ3KmLmXZfmt3YQxDw8W7StxUwRzQGOHWhosUPp4?= =?us-ascii?Q?Xo9kokuerL194Tuq0SPFi1yJdKa+1L3CKCAMVz3iw3a0mkl53ShYGp/gbmRo?= =?us-ascii?Q?26FfqwS6WM8arqDE6ximm4o3W9mmu1V6MQ692LJStll3RW7KSDhcXpi7TOtM?= =?us-ascii?Q?xHFCbmJQYfk9jJZj25SLtgE34X/CpesMD+ySjTXooE9IpDz46jJRXlf9KZKO?= =?us-ascii?Q?4EwMAYtCgQkqrAvG6WTzZQcWlc0H8a4IZ9Rm225cEAC0KAY86wRucpOyOUoa?= =?us-ascii?Q?9PrWCt92xVhY/dIWf7NSDvc86u/3HGzZ6UYA+2vGu8G3ajWtU6WzJ7RF7CdY?= =?us-ascii?Q?j4c3klHuVjHblQuZynvfF0TZ3VykMqaDyRrPCVFp7AGg8XLLMgWA4XMCJMr+?= =?us-ascii?Q?C4DwgmfLqN5HVrvxS+4ILv+W+/WiyPnaXAvSLZV8Ubi43CU5oNwYNd0SdG5c?= =?us-ascii?Q?mo4W8AtMEVDUUv5HK7yBBgRiy2FG6pFXWv2U8QI3EvbR3P7LArW3qIASGzoG?= =?us-ascii?Q?mtVf38ybiK8/q9im4GkaLKJMESOWPCVB79f2fzjGMnICfIgCifFLlnZEfepx?= =?us-ascii?Q?5IgYIJHbHmZ3VuxP6Oe4rm51wtgcI7hiMgPH9YSZoMbLpnWui1EGTYaMF8MN?= =?us-ascii?Q?H8A+HX/10A64TCqRMx2M80VPMusa3FjOlS2f0ferOoZsEtLTWRJC8Eqa3Ylc?= =?us-ascii?Q?QqN9XlPZpSvg/5fIkkmCbgvzv6wv0znHfl0GL+BCB/Kh+IwPrW+vrr7wtZQj?= =?us-ascii?Q?W+4VTQsCGh37WPXDSHW1gzW3PdsCtQPLCbtvAxoOjMF+TYJT8057Nbh2hKpz?= =?us-ascii?Q?etRffBb1LeTiliGSHXz4t2v970euJ4trhGMjGotqvg68mlqYL2jp+dtIaDVd?= =?us-ascii?Q?OqYWclJeqUre7+8/2GvzPekOlCQ=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf102cb5-51c4-4a20-feff-08d9d0f4a377 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2022 09:12:18.5752 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mBbHVxx8QRMl3GMFLh5AYakrBhE/2FmfNVIYk4iY9CZoJ7FGA9abQnJ6q8UnNG90rcD3/2YX5XghJTuvaNW64W2C6+p3q1eOiXhV6KteoCw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2159 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10218 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 suspectscore=0 bulkscore=0 mlxlogscore=995 phishscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2112160000 definitions=main-2201060065 X-Proofpoint-GUID: mhePakzbXvLnU7XWJtiwpm6PKSD7qWaa X-Proofpoint-ORIG-GUID: mhePakzbXvLnU7XWJtiwpm6PKSD7qWaa X-Rspamd-Queue-Id: A13DB100003 X-Stat-Signature: xof6re6kks5c78uer1rmkgb6r97yrjc8 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=Y0ragyf5; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=YZYXn5of; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf14.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=dan.carpenter@oracle.com X-Rspamd-Server: rspam11 X-HE-Tag: 1641460341-977408 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Baolin Wang, The patch 86522923bb29: "mm/damon: add access checking for hugetlb pages" from Dec 30, 2021, leads to the following Smatch static checker warning: mm/damon/vaddr.c:405 damon_hugetlb_mkold() warn: 'page' can't be NULL. mm/damon/vaddr.c 398 static void damon_hugetlb_mkold(pte_t *pte, struct mm_struct *mm, 399 struct vm_area_struct *vma, unsigned long addr) 400 { 401 bool referenced = false; 402 pte_t entry = huge_ptep_get(pte); 403 struct page *page = pte_page(entry); 404 --> 405 if (!page) I don't think it makes sense to check "page" because we're already dead if pte_page() starts returning NULL. Maybe check "entry"? 406 return; 407 408 get_page(page); 409 410 if (pte_young(entry)) { 411 referenced = true; 412 entry = pte_mkold(entry); 413 huge_ptep_set_access_flags(vma, addr, pte, entry, 414 vma->vm_flags & VM_WRITE); 415 } regards, dan carpenter