From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14E09C433F5 for ; Wed, 5 Jan 2022 16:15:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 764506B0071; Wed, 5 Jan 2022 11:15:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 713F76B0073; Wed, 5 Jan 2022 11:15:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B4236B0074; Wed, 5 Jan 2022 11:15:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 44D9B6B0071 for ; Wed, 5 Jan 2022 11:15:48 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EE7F18249980 for ; Wed, 5 Jan 2022 16:15:47 +0000 (UTC) X-FDA: 78996734334.31.63EDA1E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 0E3D61A000E for ; Wed, 5 Jan 2022 16:15:46 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0BF08615CE; Wed, 5 Jan 2022 16:15:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 416F1C36AE0; Wed, 5 Jan 2022 16:15:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641399345; bh=pZlRF3le9nUMegXYE2tpnktW+4enPpOkQCJARy70NME=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dzUBYh+3tvwVlOFhAKfQLQDtVRFmce9fKTbY5IUefgFV+/u4elNy6wXUiXRW+40dL HeCKUBMdBYstx3JkxLhTtiMv0wK1xwkgYKc8o5Jlf3KI2DrSZc1bc6zFOUT8IStcZx 3BKtyJA5FaqiUQpzui93b989yqHzB6E7kgDj2+gj8c1dLwyPAQziBPAts0JJvKfDFd 4Z5IMMFGtdQNCuV4nsf8Fyy1m4BYvmHK+cYc/gwdlZzAI3kc+dkFkXKMudj3BTUxWq QzTm+lThSOWpe+Gm3DcdXGW/dzvkFHGnsuWxhSKfkWgiY9Ikt2jBTfh3Q6Vmbnig9M ar5yK4O02t13A== Date: Wed, 5 Jan 2022 08:15:43 -0800 From: Jakub Kicinski To: kernel test robot , kbuild-all@lists.01.org Cc: Linux Memory Management List , Alexei Starovoitov Subject: Re: [linux-next:master 9576/10864] include/linux/rcupdate.h:412:36: error: dereferencing pointer to incomplete type 'struct bpf_prog' Message-ID: <20220105081543.3ee0eae4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <202201051741.TQVhjCyh-lkp@intel.com> References: <202201051741.TQVhjCyh-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dzUBYh+3; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0E3D61A000E X-Stat-Signature: 3xhgunydw9wfuwjn7uagkzp5xn9zka6w X-HE-Tag: 1641399346-661771 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 5 Jan 2022 17:21:31 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 7a769a3922d81cfc74ab4d90a9cc69485f260976 > commit: b6459415b384cb829f0b2a4268f211c789f6cf0b [9576/10864] net: Don't include filter.h from net/sock.h Thanks for the report! I'm slightly confused how to read it. The issues is already fixed by commit 7d714ff14d64 ("net: fixup build after bpf header changes"), which is present in linux-next. Should this report be marked as "already fixed" or "transient" somehow? Why is head reported to be at 7a769a39 when it must in fact be at b6459415 for the build to fail. HEAD has a special meaning in git, it's the currently checked out commit. Perhaps we can avoid using it with a different meaning? Maybe put the hash on the "tree:" line in brackets instead? tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master (7a769a3922d8) > config: i386-randconfig-m021-20220105 (https://download.01.org/0day-ci/archive/20220105/202201051741.TQVhjCyh-lkp@intel.com/config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce (this is a W=1 build): > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b6459415b384cb829f0b2a4268f211c789f6cf0b > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout b6459415b384cb829f0b2a4268f211c789f6cf0b > # save the config file to linux build tree > mkdir build_dir > make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/mellanox/mlx5/core/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > In file included from ./arch/x86/include/generated/asm/rwonce.h:1, > from include/linux/compiler.h:266, > from arch/x86/include/asm/atomic.h:5, > from include/linux/atomic.h:7, > from include/linux/refcount.h:95, > from include/net/act_api.h:9, > from include/net/tc_act/tc_gact.h:5, > from drivers/net/ethernet/mellanox/mlx5/core/en_main.c:33: > drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_alloc_rq': > >> include/linux/rcupdate.h:412:36: error: dereferencing pointer to incomplete type 'struct bpf_prog' > 412 | #define RCU_INITIALIZER(v) (typeof(*(v)) __force __rcu *)(v) > | ^~~~ > include/asm-generic/rwonce.h:55:33: note: in definition of macro '__WRITE_ONCE' > 55 | *(volatile typeof(x) *)&(x) = (val); \ > | ^~~ > include/linux/rcupdate.h:854:3: note: in expansion of macro 'WRITE_ONCE' > 854 | WRITE_ONCE(p, RCU_INITIALIZER(v)); \ > | ^~~~~~~~~~ > include/linux/rcupdate.h:854:17: note: in expansion of macro 'RCU_INITIALIZER' > 854 | WRITE_ONCE(p, RCU_INITIALIZER(v)); \ > | ^~~~~~~~~~~~~~~ > drivers/net/ethernet/mellanox/mlx5/core/en_main.c:569:2: note: in expansion of macro 'RCU_INIT_POINTER' > 569 | RCU_INIT_POINTER(rq->xdp_prog, params->xdp_prog); > | ^~~~~~~~~~~~~~~~ > > > vim +412 include/linux/rcupdate.h > > ca5ecddfa8fcbd Paul E. McKenney 2010-04-28 407 > 462225ae47d717 Paul E. McKenney 2013-11-11 408 /** > 462225ae47d717 Paul E. McKenney 2013-11-11 409 * RCU_INITIALIZER() - statically initialize an RCU-protected global variable > 462225ae47d717 Paul E. McKenney 2013-11-11 410 * @v: The value to statically initialize with. > 462225ae47d717 Paul E. McKenney 2013-11-11 411 */ > 462225ae47d717 Paul E. McKenney 2013-11-11 @412 #define RCU_INITIALIZER(v) (typeof(*(v)) __force __rcu *)(v) > 462225ae47d717 Paul E. McKenney 2013-11-11 413 > > :::::: The code at line 412 was first introduced by commit > :::::: 462225ae47d7175f886281d8a91708550cd5178c rcu: Add an RCU_INITIALIZER for global RCU-protected pointers > > :::::: TO: Paul E. McKenney > :::::: CC: Paul E. McKenney > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org