From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA3B5C433FE for ; Tue, 4 Jan 2022 00:11:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D6936B009E; Mon, 3 Jan 2022 19:11:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E9DA36B00A4; Mon, 3 Jan 2022 19:11:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEB9F6B00A0; Mon, 3 Jan 2022 19:11:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id 7F11A6B00A4 for ; Mon, 3 Jan 2022 19:11:01 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4283B8B305 for ; Tue, 4 Jan 2022 00:11:01 +0000 (UTC) X-FDA: 78990674322.22.5513448 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf13.hostedemail.com (Postfix) with ESMTP id A724D20006 for ; Tue, 4 Jan 2022 00:10:43 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7C8631F3A1; Tue, 4 Jan 2022 00:10:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1641255059; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UizTnTN+7G/BHS2wZsmWzy7dIrTBPYl0VkFCBetvouA=; b=sR6r3SvVeZl3XvqCqfCABqQpMot7IWmgvE7XZaUHhos9ky1joBHuxVr/WDQRkRFbl+Kden vZGX5y6WqvljO+TXYKSiAFHYsUTz78U9boQpaNxR6fqbqxJ41KaPb6dToVljQa1VvNO5tT jr8caaijCJuJS0Tciv/Bwxvsz4tNI7s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1641255059; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UizTnTN+7G/BHS2wZsmWzy7dIrTBPYl0VkFCBetvouA=; b=Gk79NO/JFq96kZfYCrqBYe7d02S8clSIKWTpR/whug5VRYx39oNoijKqb0O6EvrJ1ol8TH IsdfV8njg2hfkHAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 09352139EE; Tue, 4 Jan 2022 00:10:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UF2IAZOQ02FEQwAAMHmgww (envelope-from ); Tue, 04 Jan 2022 00:10:59 +0000 From: Vlastimil Babka To: Matthew Wilcox , Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg Cc: linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, patches@lists.linux.dev, Vlastimil Babka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" Subject: [PATCH v4 31/32] bootmem: Use page->index instead of page->freelist Date: Tue, 4 Jan 2022 01:10:45 +0100 Message-Id: <20220104001046.12263-32-vbabka@suse.cz> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220104001046.12263-1-vbabka@suse.cz> References: <20220104001046.12263-1-vbabka@suse.cz> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3140; i=vbabka@suse.cz; h=from:subject; bh=6GzVzvaGvCknexRKBXymCykgz3NpcRW3H7Lj58WadRM=; b=owEBbQGS/pANAwAIAeAhynPxiakQAcsmYgBh05CEl0cNGQUsQF+2vGU0lmv5VYN6QHBkBJBOfV+u fIcbGEiJATMEAAEIAB0WIQSNS5MBqTXjGL5IXszgIcpz8YmpEAUCYdOQhAAKCRDgIcpz8YmpEMHaCA COtc0gFdEkzOgl9/aaScAgO4YcQ7ZH574wkgn24AHmRwe/eMaC82JkRnb8YNK21AMTEeZFaChusgEa 7D24istrSigzNzsyKfE3+vgVqixKdRQNZ1+p4Beo+KAUfVW/b4+Rs93Pdp7vrjeqRGUsIwJ9voPWQj knEVJ02D+spo81X+RxILyqNf4D4MHLbrX2CLrkINQR4L46t1AziHJVFkkBO3dRoCGaYKQ2Ks+bAQog JbAXinx8Xc1P+E/kZVHpAo1tEY6M5mbOkKROGCTLmjS1ggsWJBZ5Ojtq9LyX7TpbUhbiva43LnemLX IlpZL5gUeaxNjdcE3yf+1VUvKmx3Gp X-Developer-Key: i=vbabka@suse.cz; a=openpgp; fpr=A940D434992C2E8E99103D50224FA7E7CC82A664 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A724D20006 X-Stat-Signature: uouxak7xqh1fscya9wdrypwftwyffkbk Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sR6r3SvV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="Gk79NO/J"; dmarc=none; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-HE-Tag: 1641255043-900589 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Matthew Wilcox (Oracle)" page->freelist is for the use of slab. Using page->index is the same set of bits as page->freelist, and by using an integer instead of a pointer, we can avoid casts. Signed-off-by: Matthew Wilcox (Oracle) Signed-off-by: Vlastimil Babka Acked-by: Johannes Weiner Cc: Dave Hansen Cc: Andy Lutomirski Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Cc: "H. Peter Anvin" --- arch/x86/mm/init_64.c | 2 +- include/linux/bootmem_info.h | 2 +- mm/bootmem_info.c | 7 +++---- mm/sparse.c | 2 +- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index 36098226a957..96d34ebb20a9 100644 --- a/arch/x86/mm/init_64.c +++ b/arch/x86/mm/init_64.c @@ -981,7 +981,7 @@ static void __meminit free_pagetable(struct page *pag= e, int order) if (PageReserved(page)) { __ClearPageReserved(page); =20 - magic =3D (unsigned long)page->freelist; + magic =3D page->index; if (magic =3D=3D SECTION_INFO || magic =3D=3D MIX_SECTION_INFO) { while (nr_pages--) put_page_bootmem(page++); diff --git a/include/linux/bootmem_info.h b/include/linux/bootmem_info.h index 2bc8b1f69c93..cc35d010fa94 100644 --- a/include/linux/bootmem_info.h +++ b/include/linux/bootmem_info.h @@ -30,7 +30,7 @@ void put_page_bootmem(struct page *page); */ static inline void free_bootmem_page(struct page *page) { - unsigned long magic =3D (unsigned long)page->freelist; + unsigned long magic =3D page->index; =20 /* * The reserve_bootmem_region sets the reserved flag on bootmem diff --git a/mm/bootmem_info.c b/mm/bootmem_info.c index f03f42f426f6..f18a631e7479 100644 --- a/mm/bootmem_info.c +++ b/mm/bootmem_info.c @@ -15,7 +15,7 @@ =20 void get_page_bootmem(unsigned long info, struct page *page, unsigned lo= ng type) { - page->freelist =3D (void *)type; + page->index =3D type; SetPagePrivate(page); set_page_private(page, info); page_ref_inc(page); @@ -23,14 +23,13 @@ void get_page_bootmem(unsigned long info, struct page= *page, unsigned long type) =20 void put_page_bootmem(struct page *page) { - unsigned long type; + unsigned long type =3D page->index; =20 - type =3D (unsigned long) page->freelist; BUG_ON(type < MEMORY_HOTPLUG_MIN_BOOTMEM_TYPE || type > MEMORY_HOTPLUG_MAX_BOOTMEM_TYPE); =20 if (page_ref_dec_return(page) =3D=3D 1) { - page->freelist =3D NULL; + page->index =3D 0; ClearPagePrivate(page); set_page_private(page, 0); INIT_LIST_HEAD(&page->lru); diff --git a/mm/sparse.c b/mm/sparse.c index e5c84b0cf0c9..d21c6e5910d0 100644 --- a/mm/sparse.c +++ b/mm/sparse.c @@ -722,7 +722,7 @@ static void free_map_bootmem(struct page *memmap) >> PAGE_SHIFT; =20 for (i =3D 0; i < nr_pages; i++, page++) { - magic =3D (unsigned long) page->freelist; + magic =3D page->index; =20 BUG_ON(magic =3D=3D NODE_INFO); =20 --=20 2.34.1