From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Christoph Hellwig <hch@infradead.org>, Matthew Wilcox <matthew@wil.cx>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@zip.com.au>
Subject: Re: [PATCH] Neaten page virtual choice
Date: Thu, 02 Dec 2004 10:42:05 -0800 [thread overview]
Message-ID: <202190000.1102012924@[10.10.2.4]> (raw)
In-Reply-To: <20041202183506.GA32283@infradead.org>
--Christoph Hellwig <hch@infradead.org> wrote (on Thursday, December 02, 2004 18:35:06 +0000):
>> # if defined(WANT_PAGE_VIRTUAL)
>> -#define page_address(page) ((page)->virtual)
>> -#define set_page_address(page, address) \
>> + #define page_address(page) ((page)->virtual)
>> + #define set_page_address(page, address) \
>
> urgg, this is a horrible non-standard indentation.
>
> If you look at other kernel source you see either:
>
> - no indentation inside #ifdef at all (seems like most of the source)
> - indentation after the leading #
To be fair, both of those seem far more horrible than the above ;-)
Though I'd agree it's not exactly standard.
M.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-12-02 18:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-02 16:26 Matthew Wilcox
2004-12-02 18:35 ` Christoph Hellwig
2004-12-02 18:42 ` Martin J. Bligh [this message]
2004-12-02 19:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='202190000.1102012924@[10.10.2.4]' \
--to=mbligh@aracnet.com \
--cc=akpm@zip.com.au \
--cc=hch@infradead.org \
--cc=linux-mm@kvack.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox