From: Andrew Morton <akpm@linux-foundation.org>
To: SeongJae Park <sj@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] Remove the type-unclear target id concept
Date: Thu, 30 Dec 2021 18:20:59 -0800 [thread overview]
Message-ID: <20211230182059.6535f9201eba9e420a08445a@linux-foundation.org> (raw)
In-Reply-To: <20211230100723.2238-1-sj@kernel.org>
On Thu, 30 Dec 2021 10:07:19 +0000 SeongJae Park <sj@kernel.org> wrote:
> DAMON asks each monitoring target ('struct damon_target') to have one
> 'unsigned long' integer called 'id', which should be unique among the
> targets of same monitoring context. Meaning of it is, however, totally
> up to the monitoring primitives that registered to the monitoring
> context. For example, the virtual address spaces monitoring primitives
> treats the id as a 'struct pid' pointer.
>
> This makes the code flexible but ugly, not well-documented, and
> type-unsafe[1]. Also, identification of each target can be done via its
> index. For the reason, this patchset removes the concept and uses clear
> type definition.
Thanks. This doesn't appear to be urgent, so I'll park it until after 5.17-rc1.
next prev parent reply other threads:[~2021-12-31 2:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 10:07 SeongJae Park
2021-12-30 10:07 ` [PATCH 1/4] mm/damon/dbgfs/init_regions: Use target index instead of target id SeongJae Park
2021-12-30 10:07 ` [PATCH 2/4] Docs/admin-guide/mm/damon/usage: Update for changed initail_regions file input SeongJae Park
2021-12-30 10:07 ` [PATCH 3/4] mm/damon/core: Move damon_set_targets() into dbgfs SeongJae Park
2021-12-30 10:07 ` [PATCH 4/4] mm/damon: Remove the target id concept SeongJae Park
2021-12-31 2:20 ` Andrew Morton [this message]
2022-01-26 16:37 ` [PATCH 0/4] Remove the type-unclear " SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211230182059.6535f9201eba9e420a08445a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox