From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 772A2C433F5 for ; Fri, 24 Dec 2021 04:23:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE7BE6B0074; Thu, 23 Dec 2021 23:23:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E973D6B0075; Thu, 23 Dec 2021 23:23:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5E5D6B0078; Thu, 23 Dec 2021 23:23:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id C62C96B0074 for ; Thu, 23 Dec 2021 23:23:20 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7CEB88249980 for ; Fri, 24 Dec 2021 04:23:20 +0000 (UTC) X-FDA: 78951393360.13.AB865D2 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf24.hostedemail.com (Postfix) with ESMTP id 04938180007 for ; Fri, 24 Dec 2021 04:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640319799; x=1671855799; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=GdIKH/iBPvDupvqz2hjBtyd1i8tjlmODP8lZ1Dq9nAY=; b=nA3oWz5ZGfSN7Lyug82ZTiCOnTllulVnGhwLfYVK165ZfLDnBGRljc8V 199hlsb4Zl6muj+MHLWVre/9g63ko27OiGEGfSA4vYWwGArxPraiBEM4M V9NxfKXASGfM3RAO+VCgBVkuFhSa4zUFPoRQcNKKITvppkoeYpXblFquR LuaMQ9VCc+FfHNbjmEqR/z/jSOPPCNJPunpN2gzAIuVflT8DAxo8TTeY/ sDSkFwRkIykCOH1vfZopwHNbpf9w2ERw3/nZ9rPmsiJ4cJ1z+MoNZDFMg LtlXx/B4i49SN6OxBqVjLWkOC8tuIuvviOZXpGp5pLRSsK+R5xhgCM8jz g==; X-IronPort-AV: E=McAfee;i="6200,9189,10207"; a="327250507" X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; d="scan'208";a="327250507" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Dec 2021 20:23:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; d="scan'208";a="664766834" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.192.101]) by fmsmga001.fm.intel.com with ESMTP; 23 Dec 2021 20:23:11 -0800 Date: Fri, 24 Dec 2021 12:22:34 +0800 From: Chao Peng To: Sean Christopherson Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, john.ji@intel.com, susie.li@intel.com, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com Subject: Re: [PATCH v3 kvm/queue 06/16] KVM: Implement fd-based memory using MEMFD_OPS interfaces Message-ID: <20211224042234.GC44042@chaop.bj.intel.com> Reply-To: Chao Peng References: <20211223123011.41044-1-chao.p.peng@linux.intel.com> <20211223123011.41044-7-chao.p.peng@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nA3oWz5Z; spf=none (imf24.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 04938180007 X-Stat-Signature: io5usjnu78cg7mpka3s1qdw5sr6uc7ib X-HE-Tag: 1640319794-9132 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 23, 2021 at 06:34:22PM +0000, Sean Christopherson wrote: > On Thu, Dec 23, 2021, Chao Peng wrote: > > > > -kvm-y := $(KVM)/kvm_main.o $(KVM)/eventfd.o $(KVM)/binary_stats.o > > +kvm-y := $(KVM)/kvm_main.o $(KVM)/eventfd.o $(KVM)/binary_stats.o $(KVM)/memfd.o > > This should be > > kvm-$(CONFIG_MEMFD_OPS) += $(KVM)/memfd.o > > with stubs provided in a header file as needed. I also really dislike naming KVM's > file memfd.c, though I don't have a good alternative off the top of my head. Is memory-backend.c better? if we end up introducing the callback definition in KVM we can call it CONFIG_KVM_MEMORY_BACKEDN_OPS. Chao