From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE92C433F5 for ; Tue, 21 Dec 2021 09:37:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D9FF6B0071; Tue, 21 Dec 2021 04:37:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8623C6B0074; Tue, 21 Dec 2021 04:37:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 702DA6B0078; Tue, 21 Dec 2021 04:37:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 5D3EC6B0071 for ; Tue, 21 Dec 2021 04:37:35 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 23D3089D27 for ; Tue, 21 Dec 2021 09:37:35 +0000 (UTC) X-FDA: 78941298870.15.41CC494 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf13.hostedemail.com (Postfix) with ESMTP id BD45F20038 for ; Tue, 21 Dec 2021 09:37:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 35DE8212CA; Tue, 21 Dec 2021 09:37:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1640079453; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tCgtK9DHkpvc2J2vK1/fmontyepwG1iVH4niDlQBmHw=; b=fiOCw5J4LEwgEmgBvr/0QHY5qs/CMNf6JsHhInHjvwrzjLB6OoS3gLAbCKMXV6gQlvYNP0 dCflP0d6PXcrWL3tA1ZNN0DRp+BRkmE8na+AIN3+FXvTGEExYZsh7opS9Ztq6jWmOIBzl5 WW9YAWLU4GyZB2BKi0KvOuPt08J9E1I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1640079453; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tCgtK9DHkpvc2J2vK1/fmontyepwG1iVH4niDlQBmHw=; b=4vIQ26bnxNPxq5fuYJnbi4PCNTusiz0yFzRXNMGwXYPHH5HPauQihTrSbzX6guRBewhCX2 PBAvFYDcWWsxQoCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C369413A5F; Tue, 21 Dec 2021 09:37:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id h/dMLFygwWFVRwAAMHmgww (envelope-from ); Tue, 21 Dec 2021 09:37:32 +0000 Date: Tue, 21 Dec 2021 10:37:30 +0100 From: Oscar Salvador To: Liu Shixin Cc: Naoya Horiguchi , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mm/hwpoison: clear MF_COUNT_INCREASED before retrying get_any_page() Message-ID: <20211221093730.GA14602@linux> References: <20211221074908.3910286-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211221074908.3910286-1-liushixin2@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: BD45F20038 X-Stat-Signature: ncgcnwzr7j4rgjsu4xyzr1xyr1eac9q5 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fiOCw5J4; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4vIQ26bn; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf13.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de X-Rspamd-Server: rspam02 X-HE-Tag: 1640079446-333152 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 21, 2021 at 03:49:08PM +0800, Liu Shixin wrote: > Hulk Robot reported a panic in put_page_testzero() when testing madvise() > with MADV_SOFT_OFFLINE. The BUG() is triggered when retrying get_any_page(). > This is because we keep MF_COUNT_INCREASED flag in second try but the refcnt > is not increased. > [...] > > Fixes: b94e02822deb ("mm,hwpoison: try to narrow window race for free pages") > Reported-by: Hulk Robot > Signed-off-by: Liu Shixin Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs