From: Oscar Salvador <osalvador@suse.de>
To: Liu Shixin <liushixin2@huawei.com>
Cc: Naoya Horiguchi <naoya.horiguchi@nec.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mm/hwpoison: clear MF_COUNT_INCREASED before retrying get_any_page()
Date: Tue, 21 Dec 2021 10:37:30 +0100 [thread overview]
Message-ID: <20211221093730.GA14602@linux> (raw)
In-Reply-To: <20211221074908.3910286-1-liushixin2@huawei.com>
On Tue, Dec 21, 2021 at 03:49:08PM +0800, Liu Shixin wrote:
> Hulk Robot reported a panic in put_page_testzero() when testing madvise()
> with MADV_SOFT_OFFLINE. The BUG() is triggered when retrying get_any_page().
> This is because we keep MF_COUNT_INCREASED flag in second try but the refcnt
> is not increased.
>
[...]
>
> Fixes: b94e02822deb ("mm,hwpoison: try to narrow window race for free pages")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2021-12-21 9:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 7:49 Liu Shixin
2021-12-21 9:37 ` Oscar Salvador [this message]
2021-12-22 0:37 ` Naoya Horiguchi
2021-12-22 1:49 ` Liu Shixin
2021-12-22 2:14 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211221093730.GA14602@linux \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=naoya.horiguchi@nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox