From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 609B5C433F5
	for <linux-mm@archiver.kernel.org>; Tue, 21 Dec 2021 09:07:51 +0000 (UTC)
Received: by kanga.kvack.org (Postfix)
	id BBB436B0071; Tue, 21 Dec 2021 04:07:50 -0500 (EST)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id B6A0C6B0074; Tue, 21 Dec 2021 04:07:50 -0500 (EST)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id A804A6B0075; Tue, 21 Dec 2021 04:07:50 -0500 (EST)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106])
	by kanga.kvack.org (Postfix) with ESMTP id 9B21B6B0071
	for <linux-mm@kvack.org>; Tue, 21 Dec 2021 04:07:50 -0500 (EST)
Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay02.hostedemail.com (Postfix) with ESMTP id 5333655422
	for <linux-mm@kvack.org>; Tue, 21 Dec 2021 09:07:50 +0000 (UTC)
X-FDA: 78941223900.08.8B5A3DD
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	by imf15.hostedemail.com (Postfix) with ESMTP id 009A4A0024
	for <linux-mm@kvack.org>; Tue, 21 Dec 2021 09:07:42 +0000 (UTC)
Received: by verein.lst.de (Postfix, from userid 2407)
	id 362B168B05; Tue, 21 Dec 2021 10:07:47 +0100 (CET)
Date: Tue, 21 Dec 2021 10:07:46 +0100
From: Christoph Hellwig <hch@lst.de>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
	linux-block@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-mm@kvack.org, iommu@lists.linux-foundation.org,
	Stephen Bates <sbates@raithlin.com>, Christoph Hellwig <hch@lst.de>,
	Dan Williams <dan.j.williams@intel.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
	John Hubbard <jhubbard@nvidia.com>, Don Dutile <ddutile@redhat.com>,
	Matthew Wilcox <willy@infradead.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Jakowski Andrzej <andrzej.jakowski@intel.com>,
	Minturn Dave B <dave.b.minturn@intel.com>,
	Jason Ekstrand <jason@jlekstrand.net>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Xiong Jianxin <jianxin.xiong@intel.com>,
	Bjorn Helgaas <helgaas@kernel.org>, Ira Weiny <ira.weiny@intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Martin Oliveira <martin.oliveira@eideticom.com>,
	Chaitanya Kulkarni <ckulkarnilinux@gmail.com>
Subject: Re: [PATCH v4 23/23] nvme-pci: allow mmaping the CMB in userspace
Message-ID: <20211221090746.GF7949@lst.de>
References: <20211117215410.3695-1-logang@deltatee.com> <20211117215410.3695-24-logang@deltatee.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211117215410.3695-24-logang@deltatee.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
X-Rspamd-Server: rspam05
X-Rspamd-Queue-Id: 009A4A0024
X-Stat-Signature: 8se8gugods4gedt8aa9a7eaceq7orug6
Authentication-Results: imf15.hostedemail.com;
	dkim=none;
	dmarc=none;
	spf=none (imf15.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de
X-HE-Tag: 1640077662-864508
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

>  	file->private_data = ctrl;
> +
> +	if (ctrl->ops->mmap_file_open)
> +		ctrl->ops->mmap_file_open(ctrl, file);
> +

The callout doesn't really have anything to do with mmap, that is just
how you use it.