From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAF62C433EF for ; Tue, 21 Dec 2021 09:00:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F5DA6B0071; Tue, 21 Dec 2021 04:00:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A68E6B0073; Tue, 21 Dec 2021 04:00:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 420926B0074; Tue, 21 Dec 2021 04:00:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id 346756B0071 for ; Tue, 21 Dec 2021 04:00:11 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EFDDE8249980 for ; Tue, 21 Dec 2021 09:00:10 +0000 (UTC) X-FDA: 78941204580.21.49667DB Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf02.hostedemail.com (Postfix) with ESMTP id DAA288002B for ; Tue, 21 Dec 2021 09:00:06 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 7A18568AFE; Tue, 21 Dec 2021 10:00:04 +0100 (CET) Date: Tue, 21 Dec 2021 10:00:03 +0100 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Stephen Bates , Christoph Hellwig , Dan Williams , Jason Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Jakowski Andrzej , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni , Jason Gunthorpe Subject: Re: [PATCH v4 01/23] lib/scatterlist: cleanup macros into static inline functions Message-ID: <20211221090003.GA7949@lst.de> References: <20211117215410.3695-1-logang@deltatee.com> <20211117215410.3695-2-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211117215410.3695-2-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DAA288002B X-Stat-Signature: dbxoz8rodp8hzfqu9hzrhmosbktp6r81 Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=none; spf=none (imf02.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-HE-Tag: 1640077206-252022 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 17, 2021 at 02:53:48PM -0700, Logan Gunthorpe wrote: > Convert the sg_is_chain(), sg_is_last() and sg_chain_ptr() macros > into static inline functions. There's no reason for these to be macros > and static inline are generally preferred these days. > > Also introduce the SG_PAGE_LINK_MASK define so the P2PDMA work, which is > adding another bit to this mask, can do so more easily. > > Suggested-by: Jason Gunthorpe > Signed-off-by: Logan Gunthorpe Looks fine: Reviewed-by: Christoph Hellwig scatterlist.h doesn't have a real maintainer, do you want me to pick this up through the DMA tree?