From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4BF8C433F5 for ; Sat, 18 Dec 2021 14:35:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 529466B0073; Sat, 18 Dec 2021 09:35:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D9846B0074; Sat, 18 Dec 2021 09:35:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 379806B0075; Sat, 18 Dec 2021 09:35:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id 25C746B0073 for ; Sat, 18 Dec 2021 09:35:18 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DBD1D8249980 for ; Sat, 18 Dec 2021 14:35:07 +0000 (UTC) X-FDA: 78931162254.17.E8718FE Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf13.hostedemail.com (Postfix) with ESMTP id 314FF20037 for ; Sat, 18 Dec 2021 14:35:00 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id z7so10806079lfi.11 for ; Sat, 18 Dec 2021 06:35:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pYgC6UbioLpLUDdPygjohyGooIms1qIM+qPuyGqET70=; b=rHhgE6Zlotk8HdSmidDY7wBJeHWSp00Vfo+Aqyou5BgyXPRyKu8LnPMUgXmkKkflzx udb3hkJAw6YSaGTz2tvs0AUdbG9qxcputvPHcQJHMxINHngDuOsk5v1e2RDCfUnB1Ab8 Km2eL88kgKvUp1qHFQIF+u/2wiYm+aqXrJo5w5NWU3ewPCL+RZWQvfMM8aVSybzkQWv2 YznjW4G5pZEtM+9rqSNDOTSDoor1uxwRfciKnnPsd/l/oMeQiT+BBMLp7QmdgammQt4/ 5yoUrYl7NRtmvNpp4QCxknwd6fmsh7MmHlYOIuMeHEPl2JNzg5WgzpB/pIaguDzdx6I4 IGyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pYgC6UbioLpLUDdPygjohyGooIms1qIM+qPuyGqET70=; b=ti6lLMl1xvmXLinAA2Z6cO8AQXv/ZatXmpkQq7KSMeA7hWsv/WW17xfU80qPXQvBJJ xkFAODVFbafmrdYOyTpsUWc8eJhNFQWHx+okO0SuQC74d60KmnuQvEvOyqMMO9d5tmON 8o+kEVgSV2oQsSWCsWt6di8jJsGzamZ4wWnliUWf8ak2H6dJVGfFdm9aLDFPQN+FYJNb kA0Qp2ZXJ2v9OX94N/23Q7ENZRtdrmuqCOQfM9NT11JcGm/EaYujgY5lCx4VPeC6RREC GK9PvipaSE3w1eQumlJCQrzD5QgoO9y+cuw9MEq5pNgv24eHUJLkWl1iQybl+b2faYJ8 pJSQ== X-Gm-Message-State: AOAM530qX9StRbmyLvC7Tt4x4Y2q7cPPVK5f4hiJ2IqTM6d0CvecLjQg IS21J6O7iQgnQWZNW+U9YH6U0w== X-Google-Smtp-Source: ABdhPJyJfweji7/uZmtDXAtvhhz48SwfdSecz//NO1/1kZj2ekmyONM2NijthLcvedNhQHMMoHkBbQ== X-Received: by 2002:a05:6512:ac9:: with SMTP id n9mr462354lfu.460.1639838105757; Sat, 18 Dec 2021 06:35:05 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id s4sm1728641lfp.198.2021.12.18.06.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Dec 2021 06:35:05 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 98E2D103A58; Sat, 18 Dec 2021 17:35:12 +0300 (+03) Date: Sat, 18 Dec 2021 17:35:12 +0300 From: "Kirill A. Shutemov" To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, Andrew Morton , Hugh Dickins , Linus Torvalds , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Vlastimil Babka , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v1 04/11] mm: thp: simlify total_mapcount() Message-ID: <20211218143512.luh7jnd4y7it2yun@box.shutemov.name> References: <20211217113049.23850-1-david@redhat.com> <20211217113049.23850-5-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211217113049.23850-5-david@redhat.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 314FF20037 X-Stat-Signature: pjdnkggqoaey3rnynxkepbpbgyd1ec1j Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=shutemov-name.20210112.gappssmtp.com header.s=20210112 header.b=rHhgE6Zl; spf=none (imf13.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.52) smtp.mailfrom=kirill@shutemov.name; dmarc=none X-HE-Tag: 1639838100-838024 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 17, 2021 at 12:30:42PM +0100, David Hildenbrand wrote: > Let's simplify a bit, returning for PageHuge() early and using > head_compound_page() as we are only getting called for HEAD pages. > > Note the VM_BUG_ON_PAGE(PageTail(page), page) check at the beginning of > total_mapcount(). > > This is a preparation for further changes. > > Reviewed-by: Peter Xu > Signed-off-by: David Hildenbrand Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov