From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52D58C433EF for ; Fri, 17 Dec 2021 04:14:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A90596B0071; Thu, 16 Dec 2021 23:14:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A40106B0072; Thu, 16 Dec 2021 23:14:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 907D76B0073; Thu, 16 Dec 2021 23:14:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id 7BE0A6B0071 for ; Thu, 16 Dec 2021 23:14:30 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 454BD180ABF4A for ; Fri, 17 Dec 2021 04:14:20 +0000 (UTC) X-FDA: 78925969080.03.CF1238F Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by imf14.hostedemail.com (Postfix) with ESMTP id EBE1B100010 for ; Fri, 17 Dec 2021 04:14:17 +0000 (UTC) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1my4d9-0006M3-Vp; Fri, 17 Dec 2021 15:14:05 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 17 Dec 2021 15:14:03 +1100 Date: Fri, 17 Dec 2021 15:14:03 +1100 From: Herbert Xu To: Stephan Mueller Cc: Yujie Liu , Mat Martineau , LKML , Linux Memory Management List , lkp@lists.01.org, lkp@intel.com, "Sang, Oliver" Subject: Re: [security] d3b04a4398: WARNING:at_crypto/kdf_sp800108.c:#crypto_kdf108_init Message-ID: <20211217041403.GA19847@gondor.apana.org.au> References: <20211130080419.GC29514@xsang-OptiPlex-9020> <3438006.aCxCBeP46V@positron.chronox.de> <766e5415-cc94-1b46-2326-d55343a80388@intel.com> <3737408.Lz6Wf2Li4r@tauon.chronox.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3737408.Lz6Wf2Li4r@tauon.chronox.de> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of herbert@gondor.apana.org.au designates 216.24.177.18 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: EBE1B100010 X-Stat-Signature: dtcdx4nke74uux3ks9bpro7qwdjyrmez X-HE-Tag: 1639714457-70175 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 10, 2021 at 03:16:34PM +0100, Stephan Mueller wrote: > > Herbert, what is your preference in handling this: > > - we could SELECT CRYPTO_SHA256 when the KDF is compiled. This would only be > necessary to satisfy the self test. Yet, there is no guarantee that SHA-256 > would truly be needed because the DH code that calls the KDF obtains the > reference to the hash from user space. In the end we could hard compile a > crypto algorithm into the kernel that may never be used. ... > I would prefer to consider the first option to also statically compile > SHA-256. I think KDF800108_CTR should select SHA256 instead of HASH. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt