From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stephan Mueller <smueller@chronox.de>
Cc: Yujie Liu <yujie.liu@intel.com>,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
lkp@lists.01.org, lkp@intel.com, "Sang,
Oliver" <oliver.sang@intel.com>
Subject: Re: [security] d3b04a4398: WARNING:at_crypto/kdf_sp800108.c:#crypto_kdf108_init
Date: Fri, 17 Dec 2021 15:14:03 +1100 [thread overview]
Message-ID: <20211217041403.GA19847@gondor.apana.org.au> (raw)
In-Reply-To: <3737408.Lz6Wf2Li4r@tauon.chronox.de>
On Fri, Dec 10, 2021 at 03:16:34PM +0100, Stephan Mueller wrote:
>
> Herbert, what is your preference in handling this:
>
> - we could SELECT CRYPTO_SHA256 when the KDF is compiled. This would only be
> necessary to satisfy the self test. Yet, there is no guarantee that SHA-256
> would truly be needed because the DH code that calls the KDF obtains the
> reference to the hash from user space. In the end we could hard compile a
> crypto algorithm into the kernel that may never be used.
...
> I would prefer to consider the first option to also statically compile
> SHA-256.
I think KDF800108_CTR should select SHA256 instead of HASH.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2021-12-17 4:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 8:04 kernel test robot
2021-12-05 10:21 ` Stephan Müller
2021-12-10 2:54 ` Yujie Liu
2021-12-10 14:16 ` Stephan Mueller
2021-12-17 4:14 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211217041403.GA19847@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=oliver.sang@intel.com \
--cc=smueller@chronox.de \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox