From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E3A8C433F5 for ; Wed, 15 Dec 2021 19:55:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 076EE6B0071; Wed, 15 Dec 2021 14:54:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 026C16B0072; Wed, 15 Dec 2021 14:54:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E30616B0074; Wed, 15 Dec 2021 14:54:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay027.a.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id D51A06B0071 for ; Wed, 15 Dec 2021 14:54:54 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 9B93B60449 for ; Wed, 15 Dec 2021 19:54:44 +0000 (UTC) X-FDA: 78921081288.05.3B4B2EE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 9F02C180016 for ; Wed, 15 Dec 2021 19:54:41 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1A23961994; Wed, 15 Dec 2021 19:54:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B07FC36AE3; Wed, 15 Dec 2021 19:54:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639598082; bh=xp+KWpfDz8SA/fvYZIF5H1CiOkfWbAGB+XZX0SO4A/k=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=iOSN2NxamgoAQaX4EJsMDuYBWGF7siFWBoLzdWfGtevGb7owDRegZaU0zGmBwdxoi 7/Qua9ZS7BqOkxT4xYMY3C3xeadlgl5rD2r4kRwC3ePi5SxrZBCyPYrPQijPPXGW2V Jp3V/kBp0/pjIcfLkC7hOKfToak2viU9PDmwCXNiP0PBYcQH1y5uAN0S8u+vimFMjo Azn6GC0rnyg1vve5QEZXM1alSNvPN4ISEa0rj5a1vau16DMKVdbblaOGfgDD+kT6WD O4O/irT7NtyxyIFAldVnrwMMZbaVg38XuiBRkv+eqCBlRd0wpLOe58o85jqBfjzRUX zF6hoj9+SVc7Q== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 0AF7C5C1304; Wed, 15 Dec 2021 11:54:42 -0800 (PST) Date: Wed, 15 Dec 2021 11:54:42 -0800 From: "Paul E. McKenney" To: kernel test robot Cc: Neeraj Upadhyay , kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:master 6371/6993] kernel/rcu/tree_nocb.h:1262 rcu_spawn_cpu_nocb_kthread() warn: inconsistent indenting Message-ID: <20211215195442.GH641268@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <202112151130.18unyr6u-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202112151130.18unyr6u-lkp@intel.com> X-Rspamd-Queue-Id: 9F02C180016 X-Stat-Signature: 7b83wxh1f8p8dgfkc3bzx59uoj163nw5 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iOSN2Nxa; spf=pass (imf24.hostedemail.com: domain of "SRS0=L/yC=RA=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=L/yC=RA=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org"; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam10 X-HE-Tag: 1639598081-314772 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 15, 2021 at 11:05:05AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 0bafb8f3ebc84525d0ae0fcea22d12151b99312f > commit: fd1d05c6c00a3a6cbbb7156c1a99396df33f75b6 [6371/6993] rcu/nocb: Handle concurrent nocb kthreads creation > config: x86_64-randconfig-m001-20211214 (https://download.01.org/0day-ci/archive/20211215/202112151130.18unyr6u-lkp@intel.com/config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot I am folding the fix into the original with attribution, thank you! Thanx, Paul > smatch warnings: > kernel/rcu/tree_nocb.h:1262 rcu_spawn_cpu_nocb_kthread() warn: inconsistent indenting > > vim +1262 kernel/rcu/tree_nocb.h > > 1231 > 1232 /* > 1233 * If the specified CPU is a no-CBs CPU that does not already have its > 1234 * rcuo CB kthread, spawn it. Additionally, if the rcuo GP kthread > 1235 * for this CPU's group has not yet been created, spawn it as well. > 1236 */ > 1237 static void rcu_spawn_cpu_nocb_kthread(int cpu) > 1238 { > 1239 struct rcu_data *rdp = per_cpu_ptr(&rcu_data, cpu); > 1240 struct rcu_data *rdp_gp; > 1241 struct task_struct *t; > 1242 > 1243 if (!rcu_scheduler_fully_active || !rcu_nocb_is_setup) > 1244 return; > 1245 > 1246 /* If there already is an rcuo kthread, then nothing to do. */ > 1247 if (rdp->nocb_cb_kthread) > 1248 return; > 1249 > 1250 /* If we didn't spawn the GP kthread first, reorganize! */ > 1251 rdp_gp = rdp->nocb_gp_rdp; > 1252 mutex_lock(&rdp_gp->nocb_gp_kthread_mutex); > 1253 if (!rdp_gp->nocb_gp_kthread) { > 1254 t = kthread_run(rcu_nocb_gp_kthread, rdp_gp, > 1255 "rcuog/%d", rdp_gp->cpu); > 1256 if (WARN_ONCE(IS_ERR(t), "%s: Could not start rcuo GP kthread, OOM is now expected behavior\n", __func__)) { > 1257 mutex_unlock(&rdp_gp->nocb_gp_kthread_mutex); > 1258 return; > 1259 } > 1260 WRITE_ONCE(rdp_gp->nocb_gp_kthread, t); > 1261 } > > 1262 mutex_unlock(&rdp_gp->nocb_gp_kthread_mutex); > 1263 > 1264 /* Spawn the kthread for this CPU. */ > 1265 t = kthread_run(rcu_nocb_cb_kthread, rdp, > 1266 "rcuo%c/%d", rcu_state.abbr, cpu); > 1267 if (WARN_ONCE(IS_ERR(t), "%s: Could not start rcuo CB kthread, OOM is now expected behavior\n", __func__)) > 1268 return; > 1269 WRITE_ONCE(rdp->nocb_cb_kthread, t); > 1270 WRITE_ONCE(rdp->nocb_gp_kthread, rdp_gp->nocb_gp_kthread); > 1271 } > 1272 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org