From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1FA8C433EF for ; Wed, 15 Dec 2021 05:27:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55B1B6B0071; Wed, 15 Dec 2021 00:27:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 50B456B0073; Wed, 15 Dec 2021 00:27:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D2E56B0074; Wed, 15 Dec 2021 00:27:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id 2FEF56B0071 for ; Wed, 15 Dec 2021 00:27:15 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DD64888CC0 for ; Wed, 15 Dec 2021 05:27:04 +0000 (UTC) X-FDA: 78918894768.15.8DDF088 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf28.hostedemail.com (Postfix) with ESMTP id 7CEA7C000C for ; Wed, 15 Dec 2021 05:27:02 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id gj24so2396907pjb.0 for ; Tue, 14 Dec 2021 21:27:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EATF0++rhQQhxWqPyfU2MMj4vBgI3dJhEYF3haLw1w4=; b=bTiDndqWZQ7vtoDIvJRvbcIGF2mcynmMfSDxN9wrBBT8TISsHXtThVK23jl+JgQRrp lWnEW4CgcVRJ/3PfopBSA8XCl9WAoEZfEq9nnMDbkNpatBJRwSY5239O3arnteUjkzW2 D6CFA4q39MBrxOaXJ7pQirg1auy46uHuACr6t+p/81gJLI2Cnos6HsVwHzXssENFEHlF R6kyaf7bUS1FcSPFY5CxtMBZ/SnTpiqWRyGMTFFE7kIvfKS053DGYkDHsrCGWyHvmWU1 MOvyoPsBFuxNefkgcdfHYRy1KiLyqTaaBQu+hoq3jc0jOPFnADd2dIPlmxBZD5vM1g+g 5krQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EATF0++rhQQhxWqPyfU2MMj4vBgI3dJhEYF3haLw1w4=; b=vdNKr3vdzJZNUINJLFrUf5rPABG74X4MRW02u4fbO31/7GX7GiI8WIqf4HvrPgTamn WoNf7Q9dulJNdm5d7IWW0gIKPQhw4+MjdhvaCiGg9qHbFlnold095xNsD5qjaW6Mpbl7 qh9PP/NYj0FWUYLhERBRXYLJrWStCBvyzrfBExzs4czpZI07bXdOmEEp7v0+hPyXjFAM fQNA8quGUaMw5YaaBoOsQQVSWvlPXWpIQhHkhYkejDxnpXOPBtEz12ldLVcaRFkaUNRj TSai8x+Y8kA0eqC0+JghxYWB12rPipMl/6dQ3B3xBDPuCylWmrWEoqgHYiOzgrBZoBjE 1jOg== X-Gm-Message-State: AOAM532u4Im6oeSw4HDhnEgU0IVBhuPs4HdbZ6BKrp1b8b2IiekYYcbU KcGrxd2tMVXAla9U2AKhDV8qcldxMfz9yg== X-Google-Smtp-Source: ABdhPJwApHB7bNNx5kaM60v3MqQT5kLfa+h8WBVe0vHIwtGhzbJjlTgBNz0jwrvYru+c6nmuZKYyQA== X-Received: by 2002:a17:90b:1810:: with SMTP id lw16mr6687286pjb.129.1639546021207; Tue, 14 Dec 2021 21:27:01 -0800 (PST) Received: from C02CPFUZMD6M.bytedance.net ([61.120.150.71]) by smtp.gmail.com with ESMTPSA id ns21sm3853367pjb.37.2021.12.14.21.26.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Dec 2021 21:27:00 -0800 (PST) From: Ting Liu To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, vbabka@suse.cz, shakeelb@google.com, willy@infradead.org, sjpark@amazon.de, liuting.0x7c00@bytedance.com Subject: [PATCH] mm: make some vars and functions static or __init Date: Wed, 15 Dec 2021 13:26:51 +0800 Message-Id: <20211215052651.89544-1-liuting.0x7c00@bytedance.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) MIME-Version: 1.0 X-Rspamd-Queue-Id: 7CEA7C000C X-Stat-Signature: hxqksqfprwdw6g5okrm9d8xj3744k9rb Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=bTiDndqW; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf28.hostedemail.com: domain of liuting.0x7c00@bytedance.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=liuting.0x7c00@bytedance.com X-Rspamd-Server: rspam11 X-HE-Tag: 1639546022-513163 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "liuting.0x7c00" "page_idle_ops" as a global var, but its scope of use within this document. So it should be static. "page_ext_ops" is a var used in the kernel initial phase. And other functions are aslo used in the kernel initial phase. So they should be __init or __initdata to reclaim memory. Signed-off-by: liuting.0x7c00 --- include/linux/page_idle.h | 1 - mm/page_ext.c | 4 ++-- mm/page_owner.c | 4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/include/linux/page_idle.h b/include/linux/page_idle.h index 83abf95e9fa7..4663dfed1293 100644 --- a/include/linux/page_idle.h +++ b/include/linux/page_idle.h @@ -13,7 +13,6 @@ * If there is not enough space to store Idle and Young bits in page fla= gs, use * page ext flags instead. */ -extern struct page_ext_operations page_idle_ops; =20 static inline bool folio_test_young(struct folio *folio) { diff --git a/mm/page_ext.c b/mm/page_ext.c index 6242afb24d84..2193e3f10e56 100644 --- a/mm/page_ext.c +++ b/mm/page_ext.c @@ -63,12 +63,12 @@ static bool need_page_idle(void) { return true; } -struct page_ext_operations page_idle_ops =3D { +static struct page_ext_operations page_idle_ops =3D { .need =3D need_page_idle, }; #endif =20 -static struct page_ext_operations *page_ext_ops[] =3D { +static struct page_ext_operations *page_ext_ops[] __initdata =3D { #ifdef CONFIG_PAGE_OWNER &page_owner_ops, #endif diff --git a/mm/page_owner.c b/mm/page_owner.c index 4f924957ce7a..5eea061bb1e5 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -46,7 +46,7 @@ static int __init early_page_owner_param(char *buf) } early_param("page_owner", early_page_owner_param); =20 -static bool need_page_owner(void) +static __init bool need_page_owner(void) { return page_owner_enabled; } @@ -75,7 +75,7 @@ static noinline void register_early_stack(void) early_handle =3D create_dummy_stack(); } =20 -static void init_page_owner(void) +static __init void init_page_owner(void) { if (!page_owner_enabled) return; --=20 2.20.1