From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8473C433EF for ; Mon, 13 Dec 2021 20:38:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17DA66B0071; Mon, 13 Dec 2021 15:38:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 12C0D6B0073; Mon, 13 Dec 2021 15:38:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0ECA6B0074; Mon, 13 Dec 2021 15:38:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id DDFF06B0071 for ; Mon, 13 Dec 2021 15:38:22 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A359B180D6FBB for ; Mon, 13 Dec 2021 20:38:12 +0000 (UTC) X-FDA: 78913933224.06.7BF41C1 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf23.hostedemail.com (Postfix) with ESMTP id 4133B14000C for ; Mon, 13 Dec 2021 20:38:08 +0000 (UTC) Received: by mail-pf1-f182.google.com with SMTP id k26so15957771pfp.10 for ; Mon, 13 Dec 2021 12:38:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FKvkyPX1bDE2h0Q01c3iENOpP3uB49QbVTU9+BOOcRY=; b=S6eeDQjmjCkWwGcRkWpNMj0zQMC14q6RphCvU5khCboVMxxVucmJWzH8rEPdPQuoUx emxL2yMlxrGaIm2o4duCve98uwxkUkIFKY+noBGkwk7wlXepcp96rQfJHVx5Q1XplX73 W10VDY3Sr/UhdFzGxWJluZrc8VPW7ilyoXbWc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FKvkyPX1bDE2h0Q01c3iENOpP3uB49QbVTU9+BOOcRY=; b=0MWwQYRhDhcS9f9JnTBWR1QXhQd9+F/5Mh7oMwQ0ZSN2/l2nNBICrIcBh21oSyvH6c 9GbiNfp4sDW6cl5vmrwr4VuklIBgx8cYGyL4LiX5J2rO+6QtTpleJQa5CMY9nBqIniEV AlpMGrBQ1IGakSUyWEcps1CGFCaBmNg5HfmRFg21jPFje2t5C/CzenzvXbe+13iuzkFB 8GxTlxYs06gpTs92WfUNYjf6pz7gtg08sI/Jxi/TOu/XGMU/y7C8GlTE1Av1nUEQpYbG dRuD5d3y2OYz70ode2GXDe3w+ZdSH00Diz30JtR1HaoaOE+BVku7wzHsgUDxBtaKCorq rWfQ== X-Gm-Message-State: AOAM532k5azgb/kweKmuaKY6k9cV6fBgjOLvk2TAIiNwZJTeQBenqM5A T4taJnpa8AkZdRSYgL1MVjxVbg== X-Google-Smtp-Source: ABdhPJzTOk2cB0BO46AZlrjTU/JytY7dpEktlEQmTICo+f5zFSYYE2twDKDHZYe0PBqaQ8Rpa3MDww== X-Received: by 2002:a62:88c3:0:b0:4a2:b2d2:7082 with SMTP id l186-20020a6288c3000000b004a2b2d27082mr425147pfd.48.1639427890914; Mon, 13 Dec 2021 12:38:10 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z13sm926069pfj.160.2021.12.13.12.38.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Dec 2021 12:38:10 -0800 (PST) Date: Mon, 13 Dec 2021 12:38:10 -0800 From: Kees Cook To: Shuah Khan Cc: catalin.marinas@arm.com, will@kernel.org, shuah@kernel.org, mic@digikod.net, davem@davemloft.net, kuba@kernel.org, peterz@infradead.org, paulmck@kernel.org, boqun.feng@gmail.com, akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 01/12] tools: fix ARRAY_SIZE defines in tools and selftests hdrs Message-ID: <202112131238.24E1713A0@keescook> References: <30585e0f0acfb523c6f7a93e0b916ae756e0c7e7.1639156389.git.skhan@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <30585e0f0acfb523c6f7a93e0b916ae756e0c7e7.1639156389.git.skhan@linuxfoundation.org> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4133B14000C X-Stat-Signature: okgk5bgi11afgxpjpnsna94gjjd1sjt4 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=S6eeDQjm; spf=pass (imf23.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.182 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-HE-Tag: 1639427888-184814 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000273, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 10, 2021 at 10:33:11AM -0700, Shuah Khan wrote: > tools/include/linux/kernel.h and kselftest_harness.h are missing > ifndef guard around ARRAY_SIZE define. Fix them to avoid duplicate > define errors during compile when another file defines it. This > problem was found when compiling selftests that include a header > with ARRAY_SIZE define. > > ARRAY_SIZE is defined in several selftests. There are about 25+ > duplicate defines in various selftests source and header files. > Add ARRAY_SIZE to kselftest.h in preparation for removing duplicate > ARRAY_SIZE defines from individual test files. > > Signed-off-by: Shuah Khan Reviewed-by: Kees Cook -- Kees Cook