linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
To: <stable@vger.kernel.org>
Cc: <rppt@kernel.org>, <akpm@linux-foundation.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	<linux@armlinux.org.uk>, <rppt@linux.ibm.com>, <tony@atomide.com>,
	<wangkefeng.wang@huawei.com>, <mark-pk.tsai@mediatek.com>,
	<yj.chiang@mediatek.com>
Subject: [PATCH 5.4 2/5] memblock: align freed memory map on pageblock boundaries with SPARSEMEM
Date: Mon, 13 Dec 2021 16:57:07 +0800	[thread overview]
Message-ID: <20211213085710.28962-3-mark-pk.tsai@mediatek.com> (raw)
In-Reply-To: <20211213085710.28962-1-mark-pk.tsai@mediatek.com>

From: Mike Rapoport <rppt@linux.ibm.com>

commit f921f53e089a12a192808ac4319f28727b35dc0f upstream.

When CONFIG_SPARSEMEM=y the ranges of the memory map that are freed are not
aligned to the pageblock boundaries which breaks assumptions about
homogeneity of the memory map throughout core mm code.

Make sure that the freed memory map is always aligned on pageblock
boundaries regardless of the memory model selection.

Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
Tested-by: Tony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/lkml/20210630071211.21011-1-rppt@kernel.org/
[backport upstream modification in mm/memblock.c to arch/arm/mm/init.c]
Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
---
 arch/arm/mm/init.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
index 6905dd8bc03f..c0e70e643f92 100644
--- a/arch/arm/mm/init.c
+++ b/arch/arm/mm/init.c
@@ -379,14 +379,14 @@ static void __init free_unused_memmap(void)
 		 */
 		start = min(start,
 				 ALIGN(prev_end, PAGES_PER_SECTION));
-#else
+#endif
 		/*
 		 * Align down here since many operations in VM subsystem
 		 * presume that there are no holes in the memory map inside
 		 * a pageblock
 		 */
 		start = round_down(start, pageblock_nr_pages);
-#endif
+
 		/*
 		 * If we had a previous bank, and there is a space
 		 * between the current bank and the previous, free it.
@@ -404,9 +404,11 @@ static void __init free_unused_memmap(void)
 	}
 
 #ifdef CONFIG_SPARSEMEM
-	if (!IS_ALIGNED(prev_end, PAGES_PER_SECTION))
+	if (!IS_ALIGNED(prev_end, PAGES_PER_SECTION)) {
+		prev_end = ALIGN(prev_end, pageblock_nr_pages);
 		free_memmap(prev_end,
 			    ALIGN(prev_end, PAGES_PER_SECTION));
+	}
 #endif
 }
 
-- 
2.18.0



  parent reply	other threads:[~2021-12-13  9:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13  8:57 [PATCH 5.4 0/5] memblock, arm: fixes for freeing of the memory map Mark-PK Tsai
2021-12-13  8:57 ` [PATCH 5.4 1/5] memblock: free_unused_memmap: use pageblock units instead of MAX_ORDER Mark-PK Tsai
2021-12-13 10:31   ` Mike Rapoport
2021-12-15 14:09   ` Patch "memblock: free_unused_memmap: use pageblock units instead of MAX_ORDER" has been added to the 5.4-stable tree gregkh
2021-12-13  8:57 ` Mark-PK Tsai [this message]
2021-12-15 14:09   ` Patch "memblock: align freed memory map on pageblock boundaries with SPARSEMEM" " gregkh
2021-12-13  8:57 ` [PATCH 5.4 3/5] memblock: ensure there is no overflow in memblock_overlaps_region() Mark-PK Tsai
2021-12-15 14:09   ` Patch "memblock: ensure there is no overflow in memblock_overlaps_region()" has been added to the 5.4-stable tree gregkh
2021-12-13  8:57 ` [PATCH 5.4 4/5] arm: extend pfn_valid to take into account freed memory map alignment Mark-PK Tsai
2021-12-15 14:09   ` Patch "arm: extend pfn_valid to take into account freed memory map alignment" has been added to the 5.4-stable tree gregkh
2021-12-13  8:57 ` [PATCH 5.4 5/5] arm: ioremap: don't abuse pfn_valid() to check if pfn is in RAM Mark-PK Tsai
2021-12-15 14:09   ` Patch "arm: ioremap: don't abuse pfn_valid() to check if pfn is in RAM" has been added to the 5.4-stable tree gregkh
2021-12-13  9:07 ` [PATCH 5.4 0/5] memblock, arm: fixes for freeing of the memory map Greg KH
2021-12-15 14:02   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211213085710.28962-3-mark-pk.tsai@mediatek.com \
    --to=mark-pk.tsai@mediatek.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@armlinux.org.uk \
    --cc=rppt@kernel.org \
    --cc=rppt@linux.ibm.com \
    --cc=stable@vger.kernel.org \
    --cc=tony@atomide.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=yj.chiang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox