From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BAFDC433F5 for ; Fri, 10 Dec 2021 22:48:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD01E6B0078; Fri, 10 Dec 2021 17:46:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B7EE96B007B; Fri, 10 Dec 2021 17:46:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A47656B007D; Fri, 10 Dec 2021 17:46:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id 96B506B0078 for ; Fri, 10 Dec 2021 17:46:34 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5207982499B9 for ; Fri, 10 Dec 2021 22:46:24 +0000 (UTC) X-FDA: 78903369888.30.0381DA7 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf20.hostedemail.com (Postfix) with ESMTP id 6657B1C0007 for ; Fri, 10 Dec 2021 22:46:23 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 6AA48CE2D8A; Fri, 10 Dec 2021 22:46:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D24EC341C7; Fri, 10 Dec 2021 22:46:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1639176379; bh=lk9J/0f295OfvjPegcDzR+QZj6CrJOjL+jUddAe401c=; h=Date:From:To:Subject:In-Reply-To:From; b=2vQTH4lbtXZ01PjV9Rc6HpJH/Ax63ou2QGQD8kSA969i/yi9QDxKJJYiGcNVjtAO9 /K+f5Gd8eIgXGR9V+9N1WF/I8X+bJ17TFPhAETQKc7M6DJ89QXLRcav5TTN4XTed/g 12ltPqte9Cfp/tPwADEFwkQj9VEcpc3Bt8BmNbFQ= Date: Fri, 10 Dec 2021 14:46:18 -0800 From: Andrew Morton To: akpm@linux-foundation.org, hughd@google.com, kirill.shutemov@linux.intel.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, naoya.horiguchi@nec.com, shy828301@gmail.com, torvalds@linux-foundation.org, willy@infradead.org Subject: [patch 04/21] filemap: remove PageHWPoison check from next_uptodate_page() Message-ID: <20211210224618.-Qsj4uLRi%akpm@linux-foundation.org> In-Reply-To: <20211210144539.663efee2c80d8450e6180230@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6657B1C0007 X-Stat-Signature: egzdc88y1oi8kjbygjcefd1w1jo5c6a5 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=2vQTH4lb; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-HE-Tag: 1639176383-617136 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Matthew Wilcox (Oracle)" Subject: filemap: remove PageHWPoison check from next_uptodate_page() Pages are individually marked as suffering from hardware poisoning. Checking that the head page is not hardware poisoned doesn't make sense; we might be after a subpage. We check each page individually before we use it, so this was an optimisation gone wrong. It will cause us to fall back to the slow path when there was no need to do that Link: https://lkml.kernel.org/r/20211120174429.2596303-1-willy@infradead.org Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Naoya Horiguchi Cc: Yang Shi Cc: "Kirill A . Shutemov" Cc: Hugh Dickins Signed-off-by: Andrew Morton --- mm/filemap.c | 2 -- 1 file changed, 2 deletions(-) --- a/mm/filemap.c~filemap-remove-pagehwpoison-check-from-next_uptodate_page +++ a/mm/filemap.c @@ -3253,8 +3253,6 @@ static struct page *next_uptodate_page(s goto skip; if (!PageUptodate(page) || PageReadahead(page)) goto skip; - if (PageHWPoison(page)) - goto skip; if (!trylock_page(page)) goto skip; if (page->mapping != mapping) _