From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6F24C433EF for ; Thu, 9 Dec 2021 16:46:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C8736B0072; Thu, 9 Dec 2021 11:46:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 478336B0073; Thu, 9 Dec 2021 11:46:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33FD36B0074; Thu, 9 Dec 2021 11:46:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id 251036B0072 for ; Thu, 9 Dec 2021 11:46:29 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DDE4586E87 for ; Thu, 9 Dec 2021 16:46:18 +0000 (UTC) X-FDA: 78898833636.26.59AE545 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf14.hostedemail.com (Postfix) with ESMTP id 63D3A100006 for ; Thu, 9 Dec 2021 16:46:16 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 30903B8251D; Thu, 9 Dec 2021 16:46:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A7E3C004DD; Thu, 9 Dec 2021 16:46:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639068374; bh=mbbPFllg/MmeN5bhUQ1cObIukuqDFANrLK94XhhKWvY=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=tXRJ5r5Twyd87+VUaXbyzEr8htg+4+/yCkJ7MJKC++Rg8lhXLtHbzE11/p7xrE+Py du5Sxp+bYZ1ZDZJukrFKIbWXDq4MsruWzMF3JqdldW8/1LTuG62yDRwYWBLTordovU tdf3zhELBlr8Xyw79TWPn0US4EyXo4CWgXXSm2RWsfvz9iVSKQUl1hKjPdkvgJ9eNt 4LuHfGM8G8yTU5Aq5MgUdy2yDwgTQEELpZ4vAeywL85vmg5/8/TAiPe8eWPFM1oSvh 5jbtwtBKRcgL27Fc+HzjBL5VEyLCC8QahHK53BuF0eySm2zmFHeuhaZpGJSxJZOkDU 4BKK6EYuNJMPw== From: SeongJae Park To: Xin Hao Cc: sj@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V1 2/2] mm/damon: Modify the display form of damon tracepoint Date: Thu, 9 Dec 2021 16:46:11 +0000 Message-Id: <20211209164611.32858-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <1e019e8ffe8c040376ec59e918d301058cc58ade.1639066954.git.xhao@linux.alibaba.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 63D3A100006 X-Stat-Signature: g7hwtcq8mnh4ow6cg756gx9jnnf563wt Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tXRJ5r5T; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1639068376-840465 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 10 Dec 2021 00:33:17 +0800 Xin Hao wrote: > When I use the perf command to record damon monitor data, like below. > # perf record -e damon:damon_aggregated > # perf script > ...target_id=18446462667479739520 nr_regions=13 281472805928960-281472942936064... > ...target_id=18446462667479739520 nr_regions=13 281472942936064-281473080008704... > ...target_id=18446462667479739520 nr_regions=13 281473080008704-281473216634880... > > From a user's point of view, the 'target_id' and 'damon_region' which displays in decimal > are not very friendly, So there do some changes, keep the 'target_id' display consistent > with 'dbgfs/target_ids' interface and 'damon_region' is displayed in hexadecimal, just like > below. > # perf record -e damon:damon_aggregated > # perf script > ...target_id=5522 nr_regions=14 ffff716a3000-ffff79893000... > ...target_id=5522 nr_regions=14 ffff79893000-ffff819dc000... > ...target_id=5522 nr_regions=14 ffff819dc000-ffff89bd9000... > > Signed-off-by: Xin Hao > --- > include/trace/events/damon.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/trace/events/damon.h b/include/trace/events/damon.h > index 99ffa601e351..67de51814f4c 100644 > --- a/include/trace/events/damon.h > +++ b/include/trace/events/damon.h > @@ -17,7 +17,7 @@ TRACE_EVENT(damon_aggregated, > TP_ARGS(t, r, nr_regions), > > TP_STRUCT__entry( > - __field(unsigned long, target_id) > + __field(int, target_id) > __field(unsigned int, nr_regions) > __field(unsigned long, start) > __field(unsigned long, end) > @@ -26,7 +26,7 @@ TRACE_EVENT(damon_aggregated, > ), > > TP_fast_assign( > - __entry->target_id = t->id; > + __entry->target_id = (int)pid_vnr((struct pid *)t->id); I think this would break physical address space monitoring. Have you tested this change for that? Thanks, SJ > __entry->nr_regions = nr_regions; > __entry->start = r->ar.start; > __entry->end = r->ar.end; > @@ -34,7 +34,7 @@ TRACE_EVENT(damon_aggregated, > __entry->age = r->age; > ), > > - TP_printk("target_id=%lu nr_regions=%u %lu-%lu: %u %u", > + TP_printk("target_id=%u nr_regions=%u %lx-%lx: %u %u", > __entry->target_id, __entry->nr_regions, > __entry->start, __entry->end, > __entry->nr_accesses, __entry->age) > -- > 2.31.0