From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4A3BC433EF for ; Wed, 8 Dec 2021 18:43:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69BEC6B0073; Wed, 8 Dec 2021 13:43:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 648E66B0074; Wed, 8 Dec 2021 13:43:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5113F6B0075; Wed, 8 Dec 2021 13:43:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154]) by kanga.kvack.org (Postfix) with ESMTP id 442E76B0073 for ; Wed, 8 Dec 2021 13:43:20 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1568D876F4 for ; Wed, 8 Dec 2021 18:43:10 +0000 (UTC) X-FDA: 78895499340.13.A68870B Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf28.hostedemail.com (Postfix) with ESMTP id 9547090000AD for ; Wed, 8 Dec 2021 18:43:08 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E847CB82271; Wed, 8 Dec 2021 18:43:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3CE8C00446; Wed, 8 Dec 2021 18:43:05 +0000 (UTC) Date: Wed, 8 Dec 2021 13:43:04 -0500 From: Steven Rostedt To: Yafang Shao Cc: akpm@linux-foundation.org, keescook@chromium.org, pmladek@suse.com, david@redhat.com, arnaldo.melo@gmail.com, andrii.nakryiko@gmail.com, linux-mm@kvack.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Mathieu Desnoyers , Alexei Starovoitov , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro Subject: Re: [PATCH -mm 4/5] tools/perf: replace hard-coded 16 with TASK_COMM_LEN Message-ID: <20211208134304.615abbbf@gandalf.local.home> In-Reply-To: <20211204095256.78042-5-laoar.shao@gmail.com> References: <20211204095256.78042-1-laoar.shao@gmail.com> <20211204095256.78042-5-laoar.shao@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9547090000AD X-Stat-Signature: q4bg16t4urr436zz97yecxj6qmsp5y4f Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of "SRS0=9EZ9=QZ=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=9EZ9=QZ=goodmis.org=rostedt@kernel.org"; dmarc=none X-HE-Tag: 1638988988-904189 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 4 Dec 2021 09:52:55 +0000 Yafang Shao wrote: > @@ -43,7 +45,7 @@ static int test__perf_evsel__tp_sched_test(struct test_suite *test __maybe_unuse > return -1; > } > > - if (evsel__test_field(evsel, "prev_comm", 16, false)) > + if (evsel__test_field(evsel, "prev_comm", TASK_COMM_LEN, false)) > ret = -1; > > if (evsel__test_field(evsel, "prev_pid", 4, true)) > @@ -55,7 +57,7 @@ static int test__perf_evsel__tp_sched_test(struct test_suite *test __maybe_unuse > if (evsel__test_field(evsel, "prev_state", sizeof(long), true)) > ret = -1; > > - if (evsel__test_field(evsel, "next_comm", 16, false)) > + if (evsel__test_field(evsel, "next_comm", TASK_COMM_LEN, false)) > ret = -1; > > if (evsel__test_field(evsel, "next_pid", 4, true)) > @@ -73,7 +75,7 @@ static int test__perf_evsel__tp_sched_test(struct test_suite *test __maybe_unuse > return -1; > } > > - if (evsel__test_field(evsel, "comm", 16, false)) > + if (evsel__test_field(evsel, "comm", TASK_COMM_LEN, false)) Shouldn't all these be TASK_COMM_LEN_16? -- Steve > ret = -1; > > if (evsel__test_field(evsel, "pid", 4, true))