From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B578FC433F5 for ; Wed, 8 Dec 2021 18:41:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDA2F6B0073; Wed, 8 Dec 2021 13:41:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E88DD6B0074; Wed, 8 Dec 2021 13:41:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D51BB6B0075; Wed, 8 Dec 2021 13:41:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id C7F036B0073 for ; Wed, 8 Dec 2021 13:41:03 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 813F886991 for ; Wed, 8 Dec 2021 18:40:53 +0000 (UTC) X-FDA: 78895493586.04.CED23BF Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf10.hostedemail.com (Postfix) with ESMTP id 19A906001983 for ; Wed, 8 Dec 2021 18:40:52 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E8A68B8227D; Wed, 8 Dec 2021 18:40:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C26CC341D1; Wed, 8 Dec 2021 18:40:47 +0000 (UTC) Date: Wed, 8 Dec 2021 13:40:45 -0500 From: Steven Rostedt To: Yafang Shao Cc: akpm@linux-foundation.org, keescook@chromium.org, pmladek@suse.com, david@redhat.com, arnaldo.melo@gmail.com, andrii.nakryiko@gmail.com, linux-mm@kvack.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Mathieu Desnoyers , Alexei Starovoitov , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro Subject: Re: [PATCH -mm 2/5] cn_proc: replaced old hard-coded 16 with TASK_COMM_LEN_16 Message-ID: <20211208134045.163052f1@gandalf.local.home> In-Reply-To: <20211204095256.78042-3-laoar.shao@gmail.com> References: <20211204095256.78042-1-laoar.shao@gmail.com> <20211204095256.78042-3-laoar.shao@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 19A906001983 X-Stat-Signature: sq3q1dwufx74u4ydcqfe37gexgiq1ycb Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of "SRS0=9EZ9=QZ=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=9EZ9=QZ=goodmis.org=rostedt@kernel.org"; dmarc=none X-HE-Tag: 1638988852-941511 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 4 Dec 2021 09:52:53 +0000 Yafang Shao wrote: > This TASK_COMM_LEN_16 has the same meaning with the macro defined in > linux/sched.h, but we can't include linux/sched.h in a UAPI header, so > we should specifically define it in the cn_proc.h. > Acked-by: Steven Rostedt (VMware) -- Steve > Signed-off-by: Yafang Shao > Cc: Mathieu Desnoyers > Cc: Arnaldo Carvalho de Melo > Cc: Alexei Starovoitov > Cc: Andrii Nakryiko > Cc: Michal Miroslaw > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: Matthew Wilcox > Cc: David Hildenbrand > Cc: Al Viro > Cc: Kees Cook > Cc: Petr Mladek > --- > include/uapi/linux/cn_proc.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/cn_proc.h b/include/uapi/linux/cn_proc.h > index db210625cee8..6dcccaed383f 100644 > --- a/include/uapi/linux/cn_proc.h > +++ b/include/uapi/linux/cn_proc.h > @@ -21,6 +21,8 @@ > > #include > > +#define TASK_COMM_LEN_16 16 > + > /* > * Userspace sends this enum to register with the kernel that it is listening > * for events on the connector. > @@ -110,7 +112,7 @@ struct proc_event { > struct comm_proc_event { > __kernel_pid_t process_pid; > __kernel_pid_t process_tgid; > - char comm[16]; > + char comm[TASK_COMM_LEN_16]; > } comm; > > struct coredump_proc_event {