From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFB1BC433EF for ; Tue, 7 Dec 2021 06:05:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC6AE6B0085; Tue, 7 Dec 2021 01:05:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C76AC6B0087; Tue, 7 Dec 2021 01:05:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3E506B0088; Tue, 7 Dec 2021 01:05:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id A47996B0085 for ; Tue, 7 Dec 2021 01:05:25 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 665351811E9E3 for ; Tue, 7 Dec 2021 06:05:15 +0000 (UTC) X-FDA: 78889960590.15.C7BD86C Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf01.hostedemail.com (Postfix) with ESMTP id 0788740005 for ; Tue, 7 Dec 2021 06:05:14 +0000 (UTC) Received: by mail-qt1-f177.google.com with SMTP id 8so13304738qtx.5 for ; Mon, 06 Dec 2021 22:05:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZQOzS8BVhQngVP+oTiWyWNJRrUwIkaNZ0R7LTwmPL7Y=; b=U5ltEzk9JX7crR8EeWwBpvgEpfb7gsdsLo0ZhDWLLso0rSoQ74EMmGO1/2cPeC0TLD 977PZ73in1p+m5UuJZipvR12R4I1I0+eMpVgLT9F722/VASU1cyW4PWPBep2rZlQfg0M UMqAKTOtandU+K7oELK8LFYqYVxM3HNAtoK+7spn4XRQmqwYhWF10U0IvdhDNr7Wu8sp Ba5eAW+X67oydvBw6aR0joPlCDv1Qcyvs/7699Arp3GZruGvlCLfZt+EsrizU73tTkIA BT9Nzx1yp0zBbXX27h8/9UdHEE0TG9xxbzmm2ZQKwF0iLwBtPFuj1Nmnt/jwq1ltLuD9 u9HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZQOzS8BVhQngVP+oTiWyWNJRrUwIkaNZ0R7LTwmPL7Y=; b=ws6k8E99qWp1/vGiFhRvTZ7uwTcPe4FIqtM8XUFNbuaCoYaROG2m43ziffEPmYaqjb ByMHY4CVgTv6wNjR/znsQqEzez1VoGMsZxssz8OloTRod2tqVKtyzKG8onhl3BMDTf8a kai9pRvjfLzCXx6uWuutZ9mxgtwYbgEx5DhF21f8dF/LRFLef2ATjx8BeQLHA05jco0B FgtuYgqUxo1yiLw+K9mY/o3rkoEo4Gu9ZaCxydeWLPvQ8nZGIsB2GLuGozdKDPZqhKEo kjuQvXxgRmatFHGUZzTdVH5WXv3d3TvMsbynmvmaH2DkpyYL9wTqF8788/jcAzDxQjSa sQSg== X-Gm-Message-State: AOAM533XBml35XTrzUQuSTU/6+AkoO9a/oWOfvFnzsSVxeb/0v8B1lOh CHdNdHU8t/dflSjWzIbe0kU= X-Google-Smtp-Source: ABdhPJy3bmAKjNsJ0mUglSNW4i1NkdtXBx6TYdt1VpYeF4kaqQj/BOL35Rn5kqN+xrbzfzPyTODWZA== X-Received: by 2002:ac8:7c41:: with SMTP id o1mr46450028qtv.53.1638857114292; Mon, 06 Dec 2021 22:05:14 -0800 (PST) Received: from hasanalmaruf-mbp.thefacebook.com ([2620:10d:c091:480::1:6fa5]) by smtp.gmail.com with ESMTPSA id j126sm7618569qke.103.2021.12.06.22.05.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Dec 2021 22:05:13 -0800 (PST) From: Hasan Al Maruf X-Google-Original-From: Hasan Al Maruf To: ying.huang@intel.com Cc: akpm@linux-foundation.org, dave.hansen@linux.intel.com, feng.tang@intel.com, hasanalmaruf@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mgorman@suse.de, mgorman@techsingularity.net, mhocko@suse.com, osalvador@suse.de, peterz@infradead.org, riel@surriel.com, shakeelb@google.com, shy828301@gmail.com, weixugc@google.com, ziy@nvidia.com Subject: Re: [PATCH -V10 RESEND 1/6] NUMA Balancing: add page promotion counter Date: Tue, 7 Dec 2021 01:05:09 -0500 Message-Id: <20211207060509.79442-1-hasanalmaruf@fb.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211207022757.2523359-2-ying.huang@intel.com> References: <20211207022757.2523359-2-ying.huang@intel.com> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0788740005 X-Stat-Signature: 9nn8gn97sm6g6eqm333xh4qudy5rezc3 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=U5ltEzk9; spf=pass (imf01.hostedemail.com: domain of hasan3050@gmail.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=hasan3050@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1638857114-763824 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Huang, >+#ifdef CONFIG_NUMA_BALANCING >+ PGPROMOTE_SUCCESS, /* promote successfully */ I find a breakdown of Anon and File page promotion can often be useful to understand an application's behavior (i.e. what kind of pages are moved t= o remote node and later being promoted). What do you think about adding counters for such a breakdown? What's your thought on adding counters for failures on different reasons? Best, Hasan