From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 598C0C433FE for ; Sun, 5 Dec 2021 12:32:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E2FC6B0078; Sun, 5 Dec 2021 07:32:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 792B96B007B; Sun, 5 Dec 2021 07:32:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6596F6B007D; Sun, 5 Dec 2021 07:32:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id 533CB6B0078 for ; Sun, 5 Dec 2021 07:32:27 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 13F51876FF for ; Sun, 5 Dec 2021 12:32:17 +0000 (UTC) X-FDA: 78883678314.25.E1828EE Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf30.hostedemail.com (Postfix) with ESMTP id AC2A4E0016B0 for ; Sun, 5 Dec 2021 12:32:16 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EEF84B80E29; Sun, 5 Dec 2021 12:32:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 496FCC341C5; Sun, 5 Dec 2021 12:32:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638707533; bh=Nqo3trBc2SJZQoAL4ACheUFaUN7sy2nYXUWm46+ozys=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iVG9zGvoNgbAzsr6rm6Eg5LGOdO+Cq1UnLpwxd9aZpEaZsGwwkCrkd+may17WVsFA AjCWcW+SNXNVVnhJXGjwVYnBSwQentUgcoWzHyOTSdp8ICVqM7a2mlX+HrEEGqn1FK iotm8PlRajn4GKcaVW5z9FUMXjb0cGByVhxLOeSDB2mon7wGCrTN2pu8wpxzY9IIBl lu9DqskQjGUE1iWEzVOt2yKsIlswXQdVLEzazeUSge0X0P4lNi+FUfrGLZJnXIKH3q DCDi2FRiOBwqcKjlnFla+3KhpQm4OPTmp9Tnk1KdXDyd6TQRdK2g6fDo5rw24100dR 9Cg8zhGFQZMKA== Received: by pali.im (Postfix) id 18F0C88E; Sun, 5 Dec 2021 13:32:10 +0100 (CET) Date: Sun, 5 Dec 2021 13:32:09 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: kernel test robot , Bjorn Helgaas Cc: kbuild-all@lists.01.org, Linux Memory Management List , Lorenzo Pieralisi , "Russell King (Oracle)" , Alexandre Belloni Subject: Re: [linux-next:master 3902/5128] pcie.c:undefined reference to `pci_remap_iospace' Message-ID: <20211205123209.lyx76daqdwzqwex4@pali> References: <202112040150.wvyJZIZO-lkp@intel.com> <20211204022131.bmhla4gkph7s7hy2@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211204022131.bmhla4gkph7s7hy2@pali> User-Agent: NeoMutt/20180716 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iVG9zGvo; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of pali@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=pali@kernel.org X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: AC2A4E0016B0 X-Stat-Signature: gnqzoeptyxcidoishj5de94qbqjz7yzi X-HE-Tag: 1638707536-5080 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: + Bjorn On Saturday 04 December 2021 03:21:31 Pali Roh=C3=A1r wrote: > On Saturday 04 December 2021 01:41:28 kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-ne= xt.git master > > head: 7afeac307a9561e3a93682c1e7eb22f918aa1187 > > commit: 9c8facde9206dc48060a2a016bae7f76b6328030 [3902/5128] arm: ior= emap: Replace pci_ioremap_io() usage by pci_remap_iospace() > > config: arm-buildonly-randconfig-r004-20211203 (https://download.01.o= rg/0day-ci/archive/20211204/202112040150.wvyJZIZO-lkp@intel.com/config) > > compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0 > > reproduce (this is a W=3D1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master= /sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-= next.git/commit/?id=3D9c8facde9206dc48060a2a016bae7f76b6328030 > > git remote add linux-next https://git.kernel.org/pub/scm/linu= x/kernel/git/next/linux-next.git > > git fetch --no-tags linux-next master > > git checkout 9c8facde9206dc48060a2a016bae7f76b6328030 > > # save the config file to linux build tree > > mkdir build_dir > > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make= .cross O=3Dbuild_dir ARCH=3Darm SHELL=3D/bin/bash > >=20 > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > >=20 > > All errors (new ones prefixed by >>): > >=20 > > arm-linux-gnueabi-ld: arch/arm/mach-dove/pcie.o: in function `dove= _pcie_setup': > > >> pcie.c:(.init.text+0x170): undefined reference to `pci_remap_iospa= ce' > > arm-linux-gnueabi-ld: drivers/pci/pci.o: in function `devm_pci_rem= ap_iospace': > > (.text+0x1a84): undefined reference to `pci_remap_iospace' >=20 > I guess that this error is caused by the fact that bot is trying to > compile kernel for Marvell Dove board without CONFIG_MMU. I'm not sure > if such configuration makes sense... Anyway >=20 > File arch/arm/mm/ioremap.c where is defined ARM specific version of > pci_remap_iospace() is compiled only when CONFIG_MMU is enabled. >=20 > What about this patch? >=20 > diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h > index 0c70eb688a00..690f222fc4ef 100644 > --- a/arch/arm/include/asm/io.h > +++ b/arch/arm/include/asm/io.h > @@ -180,10 +180,12 @@ void pci_ioremap_set_mem_type(int mem_type); > static inline void pci_ioremap_set_mem_type(int mem_type) {} > #endif > =20 > +#ifdef CONFIG_MMU > struct resource; > =20 > #define pci_remap_iospace pci_remap_iospace > int pci_remap_iospace(const struct resource *res, phys_addr_t phys_add= r); > +#endif > =20 > /* > * PCI configuration space mapping function. >=20 > It will disable ARM specific version of pci_remap_iospace() and let to > use generic version from drivers/pci/pci.c which always returns error o= n > systems without CONFIG_MMU. Bjorn: Do you know what is intended behavior and usage of function pci_remap_iospace() on kernels without CONFIG_MMU? > >=20 > > --- > > 0-DAY CI Kernel Test Service, Intel Corporation > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org