From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CB32C433F5 for ; Sat, 4 Dec 2021 10:22:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 724AF6B007E; Sat, 4 Dec 2021 05:22:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D47D6B0080; Sat, 4 Dec 2021 05:22:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59CA56B0081; Sat, 4 Dec 2021 05:22:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id 4A45E6B007E for ; Sat, 4 Dec 2021 05:22:03 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id ED33889106 for ; Sat, 4 Dec 2021 10:21:52 +0000 (UTC) X-FDA: 78879720864.08.49D7978 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf04.hostedemail.com (Postfix) with ESMTP id E99DB40004 for ; Sat, 4 Dec 2021 10:21:51 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10187"; a="223982666" X-IronPort-AV: E=Sophos;i="5.87,287,1631602800"; d="scan'208";a="223982666" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2021 02:21:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,287,1631602800"; d="scan'208";a="562047147" Received: from lkp-server02.sh.intel.com (HELO 9e1e9f9b3bcb) ([10.239.97.151]) by fmsmga008.fm.intel.com with ESMTP; 04 Dec 2021 02:21:47 -0800 Received: from kbuild by 9e1e9f9b3bcb with local (Exim 4.92) (envelope-from ) id 1mtSAs-000IrZ-FK; Sat, 04 Dec 2021 10:21:46 +0000 Date: Sat, 4 Dec 2021 18:20:58 +0800 From: kernel test robot To: yongw.pur@gmail.com, bsingharora@gmail.com, akpm@linux-foundation.org, peterz@infradead.org, mingo@kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, yang.yang29@zte.com.cn, wang.yong12@zte.com.cn Subject: Re: [PATCH linux-next] delayacct: track delays from memory compact Message-ID: <202112041804.vsvLifnA-lkp@intel.com> References: <1638542272-15187-1-git-send-email-wang.yong12@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1638542272-15187-1-git-send-email-wang.yong12@zte.com.cn> User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: r4qsd69xp5mbrfu4dzmret9zksbcn5b6 Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none); spf=none (imf04.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=lkp@intel.com X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: E99DB40004 X-HE-Tag: 1638613311-277159 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20211203] url: https://github.com/0day-ci/linux/commits/yongw-pur-gmail-com/delayacct-track-delays-from-memory-compact/20211203-224016 base: 7afeac307a9561e3a93682c1e7eb22f918aa1187 config: x86_64-randconfig-a011-20211203 (https://download.01.org/0day-ci/archive/20211204/202112041804.vsvLifnA-lkp@intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 5f1d1854eb1450d352663ee732235893c5782237) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/ccd829e34aa6aefecf6428975fa82384c6139fd1 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review yongw-pur-gmail-com/delayacct-track-delays-from-memory-compact/20211203-224016 git checkout ccd829e34aa6aefecf6428975fa82384c6139fd1 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from init/main.c:58: >> include/linux/delayacct.h:48:6: error: duplicate member 'freepages_start' u64 freepages_start; ^ include/linux/delayacct.h:39:6: note: previous declaration is here u64 freepages_start; ^ init/main.c:783:20: warning: no previous prototype for function 'mem_encrypt_init' [-Wmissing-prototypes] void __init __weak mem_encrypt_init(void) { } ^ init/main.c:783:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __init __weak mem_encrypt_init(void) { } ^ static 1 warning and 1 error generated. -- In file included from kernel/delayacct.c:14: >> include/linux/delayacct.h:48:6: error: duplicate member 'freepages_start' u64 freepages_start; ^ include/linux/delayacct.h:39:6: note: previous declaration is here u64 freepages_start; ^ 1 error generated. -- In file included from mm/page_alloc.c:77: >> include/linux/delayacct.h:48:6: error: duplicate member 'freepages_start' u64 freepages_start; ^ include/linux/delayacct.h:39:6: note: previous declaration is here u64 freepages_start; ^ mm/page_alloc.c:3820:15: warning: no previous prototype for function 'should_fail_alloc_page' [-Wmissing-prototypes] noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order) ^ mm/page_alloc.c:3820:10: note: declare 'static' if the function is not intended to be used outside of this translation unit noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order) ^ static 1 warning and 1 error generated. -- In file included from kernel/sched/core.c:13: In file included from kernel/sched/sched.h:47: >> include/linux/delayacct.h:48:6: error: duplicate member 'freepages_start' u64 freepages_start; ^ include/linux/delayacct.h:39:6: note: previous declaration is here u64 freepages_start; ^ kernel/sched/core.c:3450:6: warning: no previous prototype for function 'sched_set_stop_task' [-Wmissing-prototypes] void sched_set_stop_task(int cpu, struct task_struct *stop) ^ kernel/sched/core.c:3450:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void sched_set_stop_task(int cpu, struct task_struct *stop) ^ static 1 warning and 1 error generated. -- In file included from kernel/sched/fair.c:23: In file included from kernel/sched/sched.h:47: >> include/linux/delayacct.h:48:6: error: duplicate member 'freepages_start' u64 freepages_start; ^ include/linux/delayacct.h:39:6: note: previous declaration is here u64 freepages_start; ^ kernel/sched/fair.c:11094:6: warning: no previous prototype for function 'task_vruntime_update' [-Wmissing-prototypes] void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi) ^ kernel/sched/fair.c:11094:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi) ^ static 1 warning and 1 error generated. -- In file included from kernel/sched/rt.c:6: In file included from kernel/sched/sched.h:47: >> include/linux/delayacct.h:48:6: error: duplicate member 'freepages_start' u64 freepages_start; ^ include/linux/delayacct.h:39:6: note: previous declaration is here u64 freepages_start; ^ kernel/sched/rt.c:675:6: warning: no previous prototype for function 'sched_rt_bandwidth_account' [-Wmissing-prototypes] bool sched_rt_bandwidth_account(struct rt_rq *rt_rq) ^ kernel/sched/rt.c:675:1: note: declare 'static' if the function is not intended to be used outside of this translation unit bool sched_rt_bandwidth_account(struct rt_rq *rt_rq) ^ static 1 warning and 1 error generated. vim +/freepages_start +48 include/linux/delayacct.h 11 12 #ifdef CONFIG_TASK_DELAY_ACCT 13 struct task_delay_info { 14 raw_spinlock_t lock; 15 16 /* For each stat XXX, add following, aligned appropriately 17 * 18 * struct timespec XXX_start, XXX_end; 19 * u64 XXX_delay; 20 * u32 XXX_count; 21 * 22 * Atomicity of updates to XXX_delay, XXX_count protected by 23 * single lock above (split into XXX_lock if contention is an issue). 24 */ 25 26 /* 27 * XXX_count is incremented on every XXX operation, the delay 28 * associated with the operation is added to XXX_delay. 29 * XXX_delay contains the accumulated delay time in nanoseconds. 30 */ 31 u64 blkio_start; 32 u64 blkio_delay; /* wait for sync block io completion */ 33 u64 swapin_start; 34 u64 swapin_delay; /* wait for swapin */ 35 u32 blkio_count; /* total count of the number of sync block */ 36 /* io operations performed */ 37 u32 swapin_count; /* total count of swapin */ 38 39 u64 freepages_start; 40 u64 freepages_delay; /* wait for memory reclaim */ 41 42 u64 thrashing_start; 43 u64 thrashing_delay; /* wait for thrashing page */ 44 45 u64 compact_start; 46 u64 compact_delay; /* wait for memory compact */ 47 > 48 u64 freepages_start; 49 u32 freepages_count; /* total count of memory reclaim */ 50 u32 thrashing_count; /* total count of thrash waits */ 51 u32 compact_count; /* total count of memory compact */ 52 }; 53 #endif 54 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org