From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6546C433F5 for ; Fri, 3 Dec 2021 07:31:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0A2D6B0072; Fri, 3 Dec 2021 02:31:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DBA336B0074; Fri, 3 Dec 2021 02:31:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5AFE6B0075; Fri, 3 Dec 2021 02:31:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0190.hostedemail.com [216.40.44.190]) by kanga.kvack.org (Postfix) with ESMTP id B2E916B0072 for ; Fri, 3 Dec 2021 02:31:16 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6AFEC1842B023 for ; Fri, 3 Dec 2021 07:31:06 +0000 (UTC) X-FDA: 78875661732.13.E17AB94 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf10.hostedemail.com (Postfix) with ESMTP id 772F46001983 for ; Fri, 3 Dec 2021 07:31:05 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10186"; a="235665071" X-IronPort-AV: E=Sophos;i="5.87,283,1631602800"; d="scan'208";a="235665071" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2021 23:31:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,283,1631602800"; d="scan'208";a="577239709" Received: from lkp-server02.sh.intel.com (HELO 9e1e9f9b3bcb) ([10.239.97.151]) by fmsmga004.fm.intel.com with ESMTP; 02 Dec 2021 23:31:00 -0800 Received: from kbuild by 9e1e9f9b3bcb with local (Exim 4.92) (envelope-from ) id 1mt323-000HEC-QJ; Fri, 03 Dec 2021 07:30:59 +0000 Date: Fri, 3 Dec 2021 15:30:49 +0800 From: kernel test robot To: Joao Martins , linux-mm@kvack.org Cc: kbuild-all@lists.01.org, Dan Williams , Vishal Verma , Dave Jiang , Naoya Horiguchi , Matthew Wilcox , Jason Gunthorpe , John Hubbard , Jane Chu , Muchun Song Subject: Re: [PATCH v7 10/11] device-dax: remove pfn from __dev_dax_{pte,pmd,pud}_fault() Message-ID: <202112031508.uJvmXK7U-lkp@intel.com> References: <20211202204422.26777-11-joao.m.martins@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211202204422.26777-11-joao.m.martins@oracle.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: 8j3uic97uhxywz7rc73xmm9pzoemzgpo Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none); spf=none (imf10.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=lkp@intel.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 772F46001983 X-HE-Tag: 1638516665-659658 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Joao, Thank you for the patch! Yet something to improve: [auto build test ERROR on hnaz-mm/master] url: https://github.com/0day-ci/linux/commits/Joao-Martins/mm-device-dax-Introduce-compound-pages-in-devmap/20211203-044722 base: https://github.com/hnaz/linux-mm master config: i386-randconfig-a013-20211202 (https://download.01.org/0day-ci/archive/20211203/202112031508.uJvmXK7U-lkp@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/ca6ce8fa76f139a8d4021fc95ce7ba1ebb7a06e2 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Joao-Martins/mm-device-dax-Introduce-compound-pages-in-devmap/20211203-044722 git checkout ca6ce8fa76f139a8d4021fc95ce7ba1ebb7a06e2 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/dax/device.c: In function 'dev_dax_huge_fault': >> drivers/dax/device.c:246:8: error: too few arguments to function '__dev_dax_pud_fault' 246 | rc = __dev_dax_pud_fault(dev_dax, vmf); | ^~~~~~~~~~~~~~~~~~~ drivers/dax/device.c:218:19: note: declared here 218 | static vm_fault_t __dev_dax_pud_fault(struct dev_dax *dev_dax, | ^~~~~~~~~~~~~~~~~~~ drivers/dax/device.c: At top level: drivers/dax/device.c:394:5: warning: no previous prototype for 'dev_dax_probe' [-Wmissing-prototypes] 394 | int dev_dax_probe(struct dev_dax *dev_dax) | ^~~~~~~~~~~~~ vim +/__dev_dax_pud_fault +246 drivers/dax/device.c 224 225 static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, 226 enum page_entry_size pe_size) 227 { 228 struct file *filp = vmf->vma->vm_file; 229 vm_fault_t rc = VM_FAULT_SIGBUS; 230 int id; 231 struct dev_dax *dev_dax = filp->private_data; 232 233 dev_dbg(&dev_dax->dev, "%s: %s (%#lx - %#lx) size = %d\n", current->comm, 234 (vmf->flags & FAULT_FLAG_WRITE) ? "write" : "read", 235 vmf->vma->vm_start, vmf->vma->vm_end, pe_size); 236 237 id = dax_read_lock(); 238 switch (pe_size) { 239 case PE_SIZE_PTE: 240 rc = __dev_dax_pte_fault(dev_dax, vmf); 241 break; 242 case PE_SIZE_PMD: 243 rc = __dev_dax_pmd_fault(dev_dax, vmf); 244 break; 245 case PE_SIZE_PUD: > 246 rc = __dev_dax_pud_fault(dev_dax, vmf); 247 break; 248 default: 249 rc = VM_FAULT_SIGBUS; 250 } 251 252 dax_read_unlock(id); 253 254 return rc; 255 } 256 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org