From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBD4AC433EF for ; Fri, 3 Dec 2021 21:02:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48B616B0074; Fri, 3 Dec 2021 16:02:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 43BAC6B0075; Fri, 3 Dec 2021 16:02:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 329B96B0078; Fri, 3 Dec 2021 16:02:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0113.hostedemail.com [216.40.44.113]) by kanga.kvack.org (Postfix) with ESMTP id 255656B0074 for ; Fri, 3 Dec 2021 16:02:27 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E0E6C82499B9 for ; Fri, 3 Dec 2021 21:02:16 +0000 (UTC) X-FDA: 78877705872.20.4486B44 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf22.hostedemail.com (Postfix) with ESMTP id 76628190F for ; Fri, 3 Dec 2021 21:02:18 +0000 (UTC) Received: from mail.kernel.org (unknown [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8B039B82920; Fri, 3 Dec 2021 21:02:14 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id BC8E560E73; Fri, 3 Dec 2021 21:02:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1638565333; bh=Aae9TRQcpxW4Yd/zp6n3Lm0pw3x2oan07wBnj/exvvc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lMampx88aTxtbor/T9R7heUFlzc8mQaYeSKx12NonB7PAIBzqIin1zn6gBxNnAxM8 WnmiSiaB3PJ4807w9faKlQ+SlYhy+wgsGnZSXL5rqjfvk3y34AGG6t4HjLqHqo0cRW SHRbyBQKSCbeDsif7YBNjHqXlvDkxr5hsedq2Huo= Date: Fri, 3 Dec 2021 13:02:10 -0800 From: Andrew Morton To: yongw.pur@gmail.com Cc: bsingharora@gmail.com, peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, yang.yang29@zte.com.cn, wang.yong12@zte.com.cn Subject: Re: [PATCH linux-next] delayacct: track delays from memory compact Message-Id: <20211203130210.f34079f175f28bd1c5c26541@linux-foundation.org> In-Reply-To: <1638542272-15187-1-git-send-email-wang.yong12@zte.com.cn> References: <1638542272-15187-1-git-send-email-wang.yong12@zte.com.cn> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lMampx88; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 76628190F X-Stat-Signature: y9wa6xcsxxknrnrousyrwgegc3ogda9y X-HE-Tag: 1638565338-148486 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 3 Dec 2021 06:37:52 -0800 yongw.pur@gmail.com wrote: > From: wangyong > > Delay accounting does not track the delay of memory compact. > When there is not enough free memory, tasks can spend > a amount of their time waiting for memory compact. > > To get the impact of tasks in direct memory compact, measure > the delay when allocating memory through memory compact. > > ... > > --- a/include/linux/delayacct.h > +++ b/include/linux/delayacct.h > @@ -42,8 +42,13 @@ struct task_delay_info { > u64 thrashing_start; > u64 thrashing_delay; /* wait for thrashing page */ > > + u64 compact_start; > + u64 compact_delay; /* wait for memory compact */ > + > + u64 freepages_start; task_delay_info already has a freepages_start, so it fails to compile. Did you send the correct version?