From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29AE0C4332F for ; Thu, 2 Dec 2021 16:04:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 771F66B0072; Thu, 2 Dec 2021 11:03:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 721B46B0073; Thu, 2 Dec 2021 11:03:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E9C46B0074; Thu, 2 Dec 2021 11:03:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id 515446B0072 for ; Thu, 2 Dec 2021 11:03:51 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0DEF88249980 for ; Thu, 2 Dec 2021 16:03:41 +0000 (UTC) X-FDA: 78873324642.05.4929750 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf18.hostedemail.com (Postfix) with ESMTP id 47090400208F for ; Thu, 2 Dec 2021 16:03:39 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10185"; a="234243923" X-IronPort-AV: E=Sophos;i="5.87,282,1631602800"; d="scan'208";a="234243923" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2021 08:03:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,282,1631602800"; d="scan'208";a="500794876" Received: from lkp-server02.sh.intel.com (HELO 9e1e9f9b3bcb) ([10.239.97.151]) by orsmga007.jf.intel.com with ESMTP; 02 Dec 2021 08:03:34 -0800 Received: from kbuild by 9e1e9f9b3bcb with local (Exim 4.92) (envelope-from ) id 1msoYY-000GT3-8S; Thu, 02 Dec 2021 16:03:34 +0000 Date: Fri, 3 Dec 2021 00:02:49 +0800 From: kernel test robot To: Mel Gorman , Andrew Morton Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List , Michal Hocko , Vlastimil Babka , Alexey Avramov , Rik van Riel , Mike Galbraith , Darrick Wong , regressions@lists.linux.dev, Linux-fsdevel Subject: Re: [PATCH 1/1] mm: vmscan: Reduce throttling due to a failure to make progress Message-ID: <202112030001.HUiErCyK-lkp@intel.com> References: <20211202131842.9217-1-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211202131842.9217-1-mgorman@techsingularity.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 47090400208F X-Stat-Signature: x1urum4qs6argekmy9mq8tyu68n5cja7 Authentication-Results: imf18.hostedemail.com; dkim=none; spf=none (imf18.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=lkp@intel.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none) X-HE-Tag: 1638461019-512900 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mel, I love your patch! Perhaps something to improve: [auto build test WARNING on hnaz-mm/master] url: https://github.com/0day-ci/linux/commits/Mel-Gorman/mm-vmscan-Reduce-throttling-due-to-a-failure-to-make-progress/20211202-212004 base: https://github.com/hnaz/linux-mm master config: x86_64-buildonly-randconfig-r001-20211202 (https://download.01.org/0day-ci/archive/20211203/202112030001.HUiErCyK-lkp@intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b553297ef3ee4dc2119d5429adf3072e90fac38) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/01dada07590ae9c69a9415ba9af96d5ae184d861 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mel-Gorman/mm-vmscan-Reduce-throttling-due-to-a-failure-to-make-progress/20211202-212004 git checkout 01dada07590ae9c69a9415ba9af96d5ae184d861 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> mm/vmscan.c:1024:6: warning: no previous prototype for function 'skip_throttle_noprogress' [-Wmissing-prototypes] bool skip_throttle_noprogress(pg_data_t *pgdat) ^ mm/vmscan.c:1024:1: note: declare 'static' if the function is not intended to be used outside of this translation unit bool skip_throttle_noprogress(pg_data_t *pgdat) ^ static 1 warning generated. vim +/skip_throttle_noprogress +1024 mm/vmscan.c 1023 > 1024 bool skip_throttle_noprogress(pg_data_t *pgdat) 1025 { 1026 int reclaimable = 0, write_pending = 0; 1027 int i; 1028 1029 /* 1030 * If kswapd is disabled, reschedule if necessary but do not 1031 * throttle as the system is likely near OOM. 1032 */ 1033 if (pgdat->kswapd_failures >= MAX_RECLAIM_RETRIES) 1034 return true; 1035 1036 /* 1037 * If there are a lot of dirty/writeback pages then do not 1038 * throttle as throttling will occur when the pages cycle 1039 * towards the end of the LRU if still under writeback. 1040 */ 1041 for (i = 0; i < MAX_NR_ZONES; i++) { 1042 struct zone *zone = pgdat->node_zones + i; 1043 1044 if (!populated_zone(zone)) 1045 continue; 1046 1047 reclaimable += zone_reclaimable_pages(zone); 1048 write_pending += zone_page_state_snapshot(zone, 1049 NR_ZONE_WRITE_PENDING); 1050 } 1051 if (2 * write_pending <= reclaimable) 1052 return true; 1053 1054 return false; 1055 } 1056 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org